Parameter name must match url template parameter. Fix #6

Author: JohanLarsson

AspNetCoreAnalyzers.Tests/ASP001ParameterNameTests/CodeFix.cs

@@ -0,0 +1,186 @@
+namespace AspNetCoreAnalyzers.Tests.ASP001ParameterNameTests
+{
+    using Gu.Roslyn.Asserts;
+    using Microsoft.CodeAnalysis.CodeFixes;
+    using Microsoft.CodeAnalysis.Diagnostics;
+    using NUnit.Framework;
+
+    internal class CodeFix
+    {
+        private static readonly DiagnosticAnalyzer Analyzer = new AttributeAnalyzer();
+        private static readonly ExpectedDiagnostic ExpectedDiagnostic = Gu.Roslyn.Asserts.ExpectedDiagnostic.Create(ASP001ParameterName.Descriptor);
+        private static readonly CodeFixProvider RenameParameterFix = new RenameParameterFix();
+
+        [Test]
+        public void RenameParameterImplicit()
+        {
+            var order = @"
+namespace ValidCode
+{
+    public class Order
+    {
+        public int Id { get; set; }
+    }
+}";
+
+            var db = @"
+namespace ValidCode
+{
+    using Microsoft.EntityFrameworkCore;
+
+    public class Db : DbContext
+    {
+        public DbSet<Order> Orders { get; set; }
+    }
+}";
+            var before = @"
+namespace ValidCode
+{
+    using System.Threading.Tasks;
+    using Microsoft.AspNetCore.Mvc;
+    using Microsoft.EntityFrameworkCore;
+
+    [ApiController]
+    public class OrdersController : Controller
+    {
+        private readonly Db db;
+
+        public OrdersController(Db db)
+        {
+            this.db = db;
+        }
+
+        [HttpGet(""api/orders/{id}"")]
+        public async Task<IActionResult> GetOrder(int ↓wrong)
+        {
+            var match = await this.db.Orders.FirstOrDefaultAsync(x => x.Id == wrong);
+            if (match == null)
+            {
+                return this.NotFound();
+            }
+
+            return this.Ok(match);
+        }
+    }
+}";
+
+            var after = @"
+namespace ValidCode
+{
+    using System.Threading.Tasks;
+    using Microsoft.AspNetCore.Mvc;
+    using Microsoft.EntityFrameworkCore;
+
+    [ApiController]
+    public class OrdersController : Controller
+    {
+        private readonly Db db;
+
+        public OrdersController(Db db)
+        {
+            this.db = db;
+        }
+
+        [HttpGet(""api/orders/{id}"")]
+        public async Task<IActionResult> GetOrder(int id)
+        {
+            var match = await this.db.Orders.FirstOrDefaultAsync(x => x.Id == id);
+            if (match == null)
+            {
+                return this.NotFound();
+            }
+
+            return this.Ok(match);
+        }
+    }
+}";
+            AnalyzerAssert.CodeFix(Analyzer, RenameParameterFix, ExpectedDiagnostic, new[] { order, db, before }, after);
+        }
+
+        [Test]
+        public void RenameParameterExplicit()
+        {
+            var order = @"
+namespace ValidCode
+{
+    public class Order
+    {
+        public int Id { get; set; }
+    }
+}";
+
+            var db = @"
+namespace ValidCode
+{
+    using Microsoft.EntityFrameworkCore;
+
+    public class Db : DbContext
+    {
+        public DbSet<Order> Orders { get; set; }
+    }
+}";
+            var before = @"
+namespace ValidCode
+{
+    using System.Threading.Tasks;
+    using Microsoft.AspNetCore.Mvc;
+    using Microsoft.EntityFrameworkCore;
+
+    [ApiController]
+    public class OrdersController : Controller
+    {
+        private readonly Db db;
+
+        public OrdersController(Db db)
+        {
+            this.db = db;
+        }
+
+        [HttpGet(""api/orders/{id}"")]
+        public async Task<IActionResult> GetOrder([FromRoute]int ↓wrong)
+        {
+            var match = await this.db.Orders.FirstOrDefaultAsync(x => x.Id == wrong);
+            if (match == null)
+            {
+                return this.NotFound();
+            }
+
+            return this.Ok(match);
+        }
+    }
+}";
+
+            var after = @"
+namespace ValidCode
+{
+    using System.Threading.Tasks;
+    using Microsoft.AspNetCore.Mvc;
+    using Microsoft.EntityFrameworkCore;
+
+    [ApiController]
+    public class OrdersController : Controller
+    {
+        private readonly Db db;
+
+        public OrdersController(Db db)
+        {
+            this.db = db;
+        }
+
+        [HttpGet(""api/orders/{id}"")]
+        public async Task<IActionResult> GetOrder([FromRoute]int id)
+        {
+            var match = await this.db.Orders.FirstOrDefaultAsync(x => x.Id == id);
+            if (match == null)
+            {
+                return this.NotFound();
+            }
+
+            return this.Ok(match);
+        }
+    }
+}";
+            AnalyzerAssert.CodeFix(Analyzer, RenameParameterFix, ExpectedDiagnostic, new[] { order, db, before }, after);
+        }
+    }
+}