Check closing parenthesis. #22.

Author: JohanLarsson

AspNetCoreAnalyzers.Tests/ASP004ParameterSyntaxTests/CodeFix.cs

@@ -11,8 +11,16 @@ public class CodeFix
         private static readonly ExpectedDiagnostic ExpectedDiagnostic = ExpectedDiagnostic.Create(ASP004ParameterSyntax.Descriptor);
         private static readonly CodeFixProvider Fix = new ParameterSyntaxFix();
 
-        [TestCase("api/orders/↓id:long}", "api/orders/{id:long}")]
-        [TestCase("api/orders/↓{id:long", "api/orders/{id:long}")]
+        [TestCase("api/orders/↓id:long}",          "api/orders/{id:long}")]
+        [TestCase("api/orders/↓{id:long",          "api/orders/{id:long}")]
+        [TestCase("api/orders/{id:min(1}",         "api/orders/{id:min(1)}")]
+        [TestCase("api/orders/{id:max(1}",         "api/orders/{id:max(1)}")]
+        [TestCase("api/orders/{id:minlength(1}",   "api/orders/{id:minlength(1)}")]
+        [TestCase("api/orders/{id:maxlength(1}",   "api/orders/{id:maxlength(1)}")]
+        [TestCase("api/orders/{id:length(1}",      "api/orders/{id:length(1)}")]
+        [TestCase("api/orders/{id:length(1,2}",    "api/orders/{id:length(1,2)}")]
+        [TestCase("api/orders/{id:range(1,2}",     "api/orders/{id:range(1,2)}")]
+        [TestCase("api/orders/{id:regex((a|b)-c}", "api/orders/{id:regex((a|b)-c)}")]
         public void WhenFixable(string before, string after)
         {
             var code = @"

AspNetCoreAnalyzers/Analyzers/AttributeAnalyzer.cs

@@ -220,23 +220,49 @@ private static bool HasWrongType(ParameterPair pair, out string correctType)
 
         private static bool HasWrongSyntax(PathSegment segment, out Location location, out string correctSyntax)
         {
-            var text = segment.Span.Text;
-            if (text.StartsWith("{", StringComparison.Ordinal) &&
-                !text.EndsWith("}", StringComparison.Ordinal))
+            if (segment.Parameter is TemplateParameter parameter)
             {
-                location = segment.Span.GetLocation();
-                correctSyntax = text + "}";
-                return true;
+                foreach (var constraint in parameter.Constraints)
+                {
+                    var text = constraint.Span.Text;
+                    if (text.StartsWith("min(", StringComparison.OrdinalIgnoreCase) ||
+                        text.StartsWith("max(", StringComparison.OrdinalIgnoreCase) ||
+                        text.StartsWith("minlength(", StringComparison.OrdinalIgnoreCase) ||
+                        text.StartsWith("maxlength(", StringComparison.OrdinalIgnoreCase) ||
+                        text.StartsWith("length(", StringComparison.OrdinalIgnoreCase) ||
+                        text.StartsWith("range(", StringComparison.OrdinalIgnoreCase) ||
+                        text.StartsWith("regex(", StringComparison.OrdinalIgnoreCase))
+                    {
+                        if (!text.EndsWith(")", StringComparison.Ordinal))
+                        {
+                            location = constraint.Span.GetLocation();
+                            correctSyntax = text + ")";
+                            return true;
+                        }
+                    }
+                }
             }
-
-            if (!text.StartsWith("{", StringComparison.Ordinal) &&
-                text.EndsWith("}", StringComparison.Ordinal))
+            else
             {
-                location = segment.Span.GetLocation();
-                correctSyntax = "{" + text;
-                return true;
+                var text = segment.Span.Text;
+                if (text.StartsWith("{", StringComparison.Ordinal) &&
+                    !text.EndsWith("}", StringComparison.Ordinal))
+                {
+                    location = segment.Span.GetLocation();
+                    correctSyntax = text + "}";
+                    return true;
+                }
+
+                if (!text.StartsWith("{", StringComparison.Ordinal) &&
+                    text.EndsWith("}", StringComparison.Ordinal))
+                {
+                    location = segment.Span.GetLocation();
+                    correctSyntax = "{" + text;
+                    return true;
+                }
             }
 
+
             location = null;
             correctSyntax = null;
             return false;