Update test framework to use the latest from StyleCop.Analyzers

Author: sharwell

AsyncUsageAnalyzers/AsyncUsageAnalyzers.Test/AsyncUsageAnalyzers.Test.csproj

@@ -117,6 +117,9 @@
     </Reference>
   </ItemGroup>
   <ItemGroup>
+    <Compile Include="Helpers\DiagnosticResultLocation.cs" />
+    <Compile Include="Helpers\MetadataReferences.cs" />
+    <Compile Include="Helpers\TestDiagnosticProvider.cs" />
     <Compile Include="Naming\AvoidAsyncSuffixUnitTests.cs" />
     <Compile Include="Naming\UseAsyncSuffixUnitTests.cs" />
     <Compile Include="Reliability\AvoidAsyncVoidUnitTests.cs" />

AsyncUsageAnalyzers/AsyncUsageAnalyzers.Test/Helpers/CodeFixVerifier.Helper.cs

@@ -1,15 +1,18 @@
-using Microsoft.CodeAnalysis;
-using Microsoft.CodeAnalysis.CodeActions;
-using Microsoft.CodeAnalysis.Formatting;
-using Microsoft.CodeAnalysis.Simplification;
-using System.Collections.Generic;
-using System.Linq;
-using System.Threading;
-using System.Threading.Tasks;
-using System.Collections.Immutable;
+// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
+// Licensed under the Apache License, Version 2.0. See LICENSE in the project root for license information.
 
 namespace TestHelper
 {
+    using System.Collections.Generic;
+    using System.Collections.Immutable;
+    using System.Linq;
+    using System.Threading;
+    using System.Threading.Tasks;
+    using Microsoft.CodeAnalysis;
+    using Microsoft.CodeAnalysis.CodeActions;
+    using Microsoft.CodeAnalysis.Formatting;
+    using Microsoft.CodeAnalysis.Simplification;
+
     /// <summary>
     /// Diagnostic Producer class with extra methods dealing with applying code fixes.
     /// All methods are static

AsyncUsageAnalyzers/AsyncUsageAnalyzers.Test/Helpers/DiagnosticResult.cs

@@ -1,34 +1,10 @@
-using Microsoft.CodeAnalysis;
-using System;
+// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
+// Licensed under the Apache License, Version 2.0. See LICENSE in the project root for license information.
 
 namespace TestHelper
 {
-    /// <summary>
-    /// Location where the diagnostic appears, as determined by path, line number, and column number.
-    /// </summary>
-    public struct DiagnosticResultLocation
-    {
-        public string Path;
-        public int Line;
-        public int Column;
-
-        public DiagnosticResultLocation(string path, int line, int column)
-        {
-            if (line < 0 && column < 0)
-            {
-                throw new ArgumentOutOfRangeException("At least one of line and column must be > 0");
-            }
-
-            if (line < -1 || column < -1)
-            {
-                throw new ArgumentOutOfRangeException("Both line and column must be >= -1");
-            }
-
-            this.Path = path;
-            this.Line = line;
-            this.Column = column;
-        }
-    }
+    using System;
+    using Microsoft.CodeAnalysis;
 
     /// <summary>
     /// Structure that stores information about a <see cref="Diagnostic"/> appearing in a source.
@@ -142,6 +118,13 @@ public DiagnosticResult WithArguments(params object[] arguments)
             return result;
         }
 
+        public DiagnosticResult WithMessageFormat(LocalizableString messageFormat)
+        {
+            DiagnosticResult result = this;
+            result.MessageFormat = messageFormat;
+            return result;
+        }
+
         public DiagnosticResult WithLocation(int line, int column)
         {
             return this.WithLocation("Test0.cs", line, column);
@@ -154,5 +137,17 @@ public DiagnosticResult WithLocation(string path, int line, int column)
             result.locations[result.locations.Length - 1] = new DiagnosticResultLocation(path, line, column);
             return result;
         }
+
+        public DiagnosticResult WithLineOffset(int offset)
+        {
+            DiagnosticResult result = this;
+            Array.Resize(ref result.locations, result.locations?.Length ?? 0);
+            for (int i = 0; i < result.locations.Length; i++)
+            {
+                result.locations[i].Line += offset;
+            }
+
+            return result;
+        }
     }
-}
+}

AsyncUsageAnalyzers/AsyncUsageAnalyzers.Test/Helpers/DiagnosticResultLocation.cs

@@ -0,0 +1,34 @@
+// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
+// Licensed under the Apache License, Version 2.0. See LICENSE in the project root for license information.
+
+namespace TestHelper
+{
+    using System;
+
+    /// <summary>
+    /// Location where the diagnostic appears, as determined by path, line number, and column number.
+    /// </summary>
+    public struct DiagnosticResultLocation
+    {
+        public string Path;
+        public int Line;
+        public int Column;
+
+        public DiagnosticResultLocation(string path, int line, int column)
+        {
+            if (line < 0 && column < 0)
+            {
+                throw new ArgumentOutOfRangeException("At least one of line and column must be > 0");
+            }
+
+            if (line < -1 || column < -1)
+            {
+                throw new ArgumentOutOfRangeException("Both line and column must be >= -1");
+            }
+
+            this.Path = path;
+            this.Line = line;
+            this.Column = column;
+        }
+    }
+}