use target typed new

small steps to see when it breaks

Author: JohanLarsson

ValidCode/Recursion/InstanceMapRepro/InstanceMap.cs

@@ -10,7 +10,7 @@ namespace ValidCode.Recursion.InstanceMapRepro;
 internal class InstanceMap<TKey, TValue> : IEnumerable<KeyValuePair<TKey, TValue>>
     where TKey : class
 {
-    private readonly Dictionary<Maybe<TKey>, TValue> inner = new Dictionary<Maybe<TKey>, TValue>(KeyComparer.Default);
+    private readonly Dictionary<Maybe<TKey>, TValue> inner = new(KeyComparer.Default);
 
 #pragma warning disable INPC017 // Backing field name must match.
     internal object Gate => this.inner;
@@ -59,14 +59,15 @@ internal bool ContainsKey(TKey key)
 
     private sealed class KeyComparer : IEqualityComparer<Maybe<TKey>>
     {
-        internal static readonly KeyComparer Default = new KeyComparer();
+        internal static readonly KeyComparer Default = new();
 
         private KeyComparer()
         {
         }
 
-        public bool Equals(Maybe<TKey> x, Maybe<TKey> y) => x.HasValue == y.HasValue &&
-                                                                             ReferenceEquals(x.Value, y.Value);
+        public bool Equals(Maybe<TKey> x, Maybe<TKey> y) =>
+            x.HasValue == y.HasValue &&
+            ReferenceEquals(x.Value, y.Value);
 
         public int GetHashCode(Maybe<TKey> obj)
         {

ValidCode/Recursion/InstanceMapRepro/Maybe.cs

@@ -58,7 +58,7 @@ public T Value
     /// <summary>
     /// Create an instance with a value.
     /// </summary>
-    public static Maybe<T> Some(T value) => new Maybe<T>(hasValue: true, value: value);
+    public static Maybe<T> Some(T value) => new(hasValue: true, value: value);
 #pragma warning restore CA1000 // Do not declare static members on generic types
 
     /// <inheritdoc />