Skip to content

Commit 1460d10

Browse files
committed
Amend.
1 parent a6f5368 commit 1460d10

1 file changed

Lines changed: 9 additions & 10 deletions

File tree

IDisposableAnalyzers.Test/Helpers/DisposableMemberTests.cs

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ public void Dispose()
3030
}");
3131
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, MetadataReferences.FromAttributes());
3232
var semanticModel = compilation.GetSemanticModel(syntaxTree);
33-
var field = syntaxTree.FindFieldDeclaration("stream");
34-
var fieldSymbol = semanticModel.GetDeclaredSymbolSafe(field, CancellationToken.None);
35-
Assert.AreEqual(Result.Yes, DisposableMember.IsDisposed(new FieldOrProperty(fieldSymbol), (TypeDeclarationSyntax)field.Parent, semanticModel, CancellationToken.None));
33+
var declaration = syntaxTree.FindFieldDeclaration("stream");
34+
var symbol = semanticModel.GetDeclaredSymbolSafe(declaration, CancellationToken.None);
35+
Assert.AreEqual(Result.Yes, DisposableMember.IsDisposed(new FieldOrPropertyAndDeclaration(symbol, declaration), semanticModel, CancellationToken.None));
3636
}
3737

3838
[Test]
@@ -66,12 +66,11 @@ protected override void M()
6666
}");
6767
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, MetadataReferences.FromAttributes());
6868
var semanticModel = compilation.GetSemanticModel(syntaxTree);
69-
var field = syntaxTree.FindFieldDeclaration("stream");
70-
var fieldSymbol = semanticModel.GetDeclaredSymbolSafe(field, CancellationToken.None);
71-
Assert.AreEqual(Result.Yes, DisposableMember.IsDisposed(new FieldOrProperty(fieldSymbol), (TypeDeclarationSyntax)field.Parent, semanticModel, CancellationToken.None));
69+
var declaration = syntaxTree.FindFieldDeclaration("stream");
70+
var symbol = semanticModel.GetDeclaredSymbolSafe(declaration, CancellationToken.None);
71+
Assert.AreEqual(Result.Yes, DisposableMember.IsDisposed(new FieldOrPropertyAndDeclaration(symbol, declaration), semanticModel, CancellationToken.None));
7272
}
7373

74-
[Ignore("tbd")]
7574
[TestCase("this.components.Add(this.stream)")]
7675
[TestCase("components.Add(stream)")]
7776
public static void FieldAddedToFormComponents(string expression)
@@ -96,9 +95,9 @@ public class Winform : Form
9695
}".AssertReplace("this.components.Add(this.stream)", expression));
9796
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, MetadataReferences.FromAttributes());
9897
var semanticModel = compilation.GetSemanticModel(syntaxTree);
99-
var field = syntaxTree.FindFieldDeclaration("stream");
100-
var fieldSymbol = semanticModel.GetDeclaredSymbolSafe(field, CancellationToken.None);
101-
Assert.AreEqual(Result.Yes, DisposableMember.IsDisposed(new FieldOrProperty(fieldSymbol), (TypeDeclarationSyntax)field.Parent, semanticModel, CancellationToken.None));
98+
var declaration = syntaxTree.FindFieldDeclaration("stream");
99+
var symbol = semanticModel.GetDeclaredSymbolSafe(declaration, CancellationToken.None);
100+
Assert.AreEqual(Result.Yes, DisposableMember.IsDisposed(new FieldOrPropertyAndDeclaration(symbol, declaration), semanticModel, CancellationToken.None));
102101
}
103102
}
104103
}

0 commit comments

Comments
 (0)