Fix warnings.

Author: JohanLarsson

IDisposableAnalyzers.Test/DocumentationTests.cs

@@ -115,12 +115,12 @@ public static void ConfigSeverity(DescriptorInfo descriptorInfo)
             var actual = GetConfigSeverity(descriptorInfo.DocumentationFile.AllText);
             CodeAssert.AreEqual(expected, actual);
 
-            string GetConfigSeverity(string doc)
+            static string GetConfigSeverity(string doc)
             {
                 return GetSection(doc, "<!-- start generated config severity -->", "<!-- end generated config severity -->");
             }
 
-            string GetSection(string doc, string startToken, string endToken)
+            static string GetSection(string doc, string startToken, string endToken)
             {
                 var start = doc.IndexOf(startToken, StringComparison.Ordinal);
                 var end = doc.IndexOf(endToken, StringComparison.Ordinal) + endToken.Length;

IDisposableAnalyzers/Helpers/DisposeCall.cs

@@ -21,30 +21,26 @@ internal static bool TryGetDisposedRootMember(InvocationExpressionSyntax dispose
             if (MemberPath.TryFindRoot(disposeCall, out var rootIdentifier) &&
                (disposedMember = rootIdentifier.Parent as IdentifierNameSyntax) is { })
             {
-                var property = semanticModel.GetSymbolSafe(disposedMember, cancellationToken) as IPropertySymbol;
-                if (property == null ||
-                    property.IsAutoProperty())
+                switch (semanticModel.GetSymbolSafe(disposedMember, cancellationToken))
                 {
-                    return true;
-                }
+                    case IPropertySymbol { GetMethod: null }:
+                        return false;
+                    case IPropertySymbol { GetMethod: { DeclaringSyntaxReferences: { Length: 1 } } getMethod }
+                        when getMethod.TrySingleDeclaration(cancellationToken, out SyntaxNode? getterOrExpressionBody):
+                        {
+                            using var pooled = ReturnValueWalker.Borrow(getterOrExpressionBody, ReturnValueSearch.TopLevel, semanticModel, cancellationToken);
+                            if (pooled.Count == 0)
+                            {
+                                return true;
+                            }
 
-                if (property.GetMethod == null)
-                {
-                    return false;
-                }
+                            return pooled.TrySingle(out var expression) &&
+                                   MemberPath.TryFindRoot(expression, out rootIdentifier) &&
+                                   (disposedMember = rootIdentifier.Parent as IdentifierNameSyntax) is { };
+                        }
 
-                foreach (var reference in property.GetMethod.DeclaringSyntaxReferences)
-                {
-                    var node = reference.GetSyntax(cancellationToken);
-                    using var pooled = ReturnValueWalker.Borrow(node, ReturnValueSearch.TopLevel, semanticModel, cancellationToken);
-                    if (pooled.Count == 0)
-                    {
+                    default:
                         return true;
-                    }
-
-                    return pooled.TrySingle(out var expression) &&
-                           MemberPath.TryFindRoot(expression, out rootIdentifier) &&
-                           (disposedMember = rootIdentifier.Parent as IdentifierNameSyntax) is { };
                 }
             }