Skip to content

Commit 6405be0

Browse files
JeremyMorton-BlizzardJohanLarsson
authored andcommitted
Handle Implicit Object Creation in return values.
1 parent 187fb26 commit 6405be0

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

IDisposableAnalyzers.Test/IDISP013AwaitInUsingTests/Valid.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -424,6 +424,8 @@ public ValueTask<IDisposable> M()
424424
[TestCase("default")]
425425
[TestCase("new ValueTask<int>(1)")]
426426
[TestCase("new ValueTask<int>(disposable.Equals(disposable) ? 1 : 0)")]
427+
[TestCase("new(1)")]
428+
[TestCase("new(disposable.Equals(disposable) ? 1 : 0)")]
427429
public static void ReturnNewValueTask(string expression)
428430
{
429431
var disposable = """

IDisposableAnalyzers/Analyzers/ReturnValueAnalyzer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ InvocationExpressionSyntax invocation
151151
|| memberAccess.IsSymbol(KnownSymbols.ValueTask.CompletedTask, context.SemanticModel, context.CancellationToken)),
152152
DefaultExpressionSyntax => false,
153153
LiteralExpressionSyntax => false,
154-
ObjectCreationExpressionSyntax => false,
154+
BaseObjectCreationExpressionSyntax => false,
155155
_ => true,
156156
};
157157
}

0 commit comments

Comments
 (0)