Add tests for IDISP001 when IAsyncDisposable

#199

Author: JohanLarsson

IDisposableAnalyzers.NetCoreTests/IDISP001DisposeCreatedTests/Valid.cs

@@ -0,0 +1,66 @@
+namespace IDisposableAnalyzers.NetCoreTests.IDISP001DisposeCreatedTests
+{
+    using Gu.Roslyn.Asserts;
+    using Microsoft.CodeAnalysis.Diagnostics;
+    using NUnit.Framework;
+
+    [TestFixture(typeof(LocalDeclarationAnalyzer))]
+    [TestFixture(typeof(ArgumentAnalyzer))]
+    [TestFixture(typeof(AssignmentAnalyzer))]
+    public static class Valid<T>
+        where T : DiagnosticAnalyzer, new()
+    {
+        private static readonly DiagnosticAnalyzer Analyzer = new T();
+
+        [Test]
+        public static void LocalDisposeAsync()
+        {
+            var code = @"
+namespace N
+{
+    using System.IO;
+    using System.Threading.Tasks;
+
+    public class C
+    {
+        public async ValueTask M()
+        {
+            var x = File.OpenRead(string.Empty);
+            await x.DisposeAsync();
+        }
+    }
+}";
+
+            RoslynAssert.Valid(Analyzer, code);
+        }
+
+        [Test]
+        public static void LocalDisposeAsyncInFinally()
+        {
+            var code = @"
+namespace N
+{
+    using System.IO;
+    using System.Threading.Tasks;
+
+    public class C
+    {
+        public async ValueTask M()
+        {
+            var x = File.OpenRead(string.Empty);
+            try
+            {
+
+            }
+            finally
+            {
+                await x.DisposeAsync();
+            }
+        }
+    }
+}";
+
+            RoslynAssert.Valid(Analyzer, code);
+        }
+    }
+}

IDisposableAnalyzers/Helpers/Disposable.Disposes.cs

@@ -180,21 +180,14 @@ when recursion.Target(argument) is { } target
 
             bool IsDisposeOrReturnValueDisposed(InvocationExpressionSyntax invocation)
             {
-                if (IsDispose(invocation))
+                if (DisposeCall.IsMatch(invocation, recursion.SemanticModel, recursion.CancellationToken))
                 {
                     return true;
                 }
 
                 return DisposedByReturnValue(invocation, recursion, out var creation) &&
                        Disposes(creation, recursion);
             }
-
-            static bool IsDispose(InvocationExpressionSyntax invocation)
-            {
-                return invocation is { ArgumentList: { Arguments: { Count: 0 } } } &&
-                        invocation.TryGetMethodName(out var name) &&
-                        name == "Dispose";
-            }
         }
     }
 }