handle target typed new

Author: JohanLarsson

IDisposableAnalyzers.Test/Helpers/DisposableTests.IsCreation.cs

@@ -756,6 +756,7 @@ public void Update()
         }
 
         [TestCase("new S()")]
+        [TestCase("new()")]
         public static void RefStruct(string expression)
         {
             var syntaxTree = CSharpSyntaxTree.ParseText("""

IDisposableAnalyzers.Test/IDISP001DisposeCreatedTests/CodeFix.AddUsing.AddUsingDeclaration.cs

@@ -702,6 +702,7 @@ private static Kernel Create()
         }
 
         [TestCase("new S()")]
+        [TestCase("new()")]
         public static void LocalRefStructToUsingDeclaration(string expression)
         {
             var refStruct = """

IDisposableAnalyzers.Test/IDISP005ReturnTypeShouldBeIDisposableTests/Valid.cs

@@ -168,8 +168,9 @@ private static void M1()
         RoslynAssert.Valid(Analyzer, code);
     }
 
-    [Test]
-    public static void MethodReturningObject()
+    [TestCase("new object()")]
+    [TestCase("new()")]
+    public static void MethodReturningObject(string expression)
     {
         var code = @"
 namespace N
@@ -186,7 +187,7 @@ private static object M1()
             return new object();
         }
     }
-}";
+}".AssertReplace("new object()", expression);
         RoslynAssert.Valid(Analyzer, code);
     }
 

IDisposableAnalyzers/Helpers/Disposable.IsCreation.cs

@@ -153,7 +153,7 @@ internal static bool IsCreation(ExpressionSyntax candidate, SemanticModel semant
             return false;
         }
 
-        if (candidate is ObjectCreationExpressionSyntax)
+        if (candidate is BaseObjectCreationExpressionSyntax)
         {
             return true;
         }

IDisposableAnalyzers/Helpers/Disposable.cs

@@ -13,7 +13,7 @@ internal static partial class Disposable
     {
         { IsMissing: true } => false,
         LiteralExpressionSyntax _ => false,
-        ObjectCreationExpressionSyntax objectCreation
+        BaseObjectCreationExpressionSyntax objectCreation
             => semanticModel.TryGetType(objectCreation, cancellationToken, out var type) &&
                IsAssignableFrom(type, semanticModel.Compilation),
         _ => semanticModel.TryGetType(candidate, cancellationToken, out var type) &&

ValidCode/Returned.cs

@@ -21,6 +21,10 @@ void Consume()
 
     IDisposable FileOpenRead() => File.OpenRead(string.Empty);
 
+    object NewImplicitObject() => new();
+
+    object NewObject() => new object();
+
     IEnumerable<IDisposable> YieldReturnFileOpenRead()
     {
         yield return File.OpenRead(string.Empty);