Skip to content

Commit a804594

Browse files
committed
Fix warnings.
1 parent 4d0b195 commit a804594

File tree

3 files changed

+22
-3
lines changed

3 files changed

+22
-3
lines changed
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
namespace ValidCode.NetCore.AsyncDisposable
2+
{
3+
using System;
4+
using System.IO;
5+
using System.Threading.Tasks;
6+
7+
public class Impl1 : IAsyncDisposable
8+
{
9+
private readonly IAsyncDisposable disposable = File.OpenRead(string.Empty);
10+
11+
public async ValueTask DisposeAsync()
12+
{
13+
await this.disposable.DisposeAsync().ConfigureAwait(false);
14+
}
15+
}
16+
}

ValidCode.NetCore/AsyncDisposable/Impl.cs renamed to ValidCode.NetCore/AsyncDisposable/Impl2.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
using System.IO;
55
using System.Threading.Tasks;
66

7-
public class Impl : IAsyncDisposable
7+
public class Impl2 : IAsyncDisposable
88
{
99
private readonly IAsyncDisposable disposable = File.OpenRead(string.Empty);
1010

ValidCode.NetCore/AsyncDisposable/Issue199.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
public class Issue199 : IAsyncDisposable
88
{
9-
private Timer _timer;
9+
private Timer? _timer;
1010

1111
public async Task ResetTimerAsync()
1212
{
@@ -19,7 +19,10 @@ public async Task ResetTimerAsync()
1919

2020
public async ValueTask DisposeAsync()
2121
{
22-
await _timer.DisposeAsync();
22+
if (this._timer is { })
23+
{
24+
await _timer.DisposeAsync().ConfigureAwait(false);
25+
}
2326
}
2427
}
2528
}

0 commit comments

Comments
 (0)