WIP

Author: JohanLarsson

IDisposableAnalyzers.Test/AssemblyAttributes.cs

@@ -17,6 +17,7 @@
     typeof(System.Xaml.XamlLanguage),
     typeof(Moq.Mock<>),
     typeof(Ninject.KernelConfiguration),
+    typeof(System.Windows.Forms.Form),
     typeof(Gu.Roslyn.AnalyzerExtensions.SyntaxTokenExt),
     typeof(Gu.Roslyn.CodeFixExtensions.Parse),
     typeof(NUnit.Framework.Assert))]

IDisposableAnalyzers.Test/Helpers/DisposableWalkerTests.Disposes.cs

@@ -144,6 +144,33 @@ internal C(string fileName)
                 Assert.AreEqual(true, semanticModel.TryGetSymbol(value, CancellationToken.None, out ILocalSymbol symbol));
                 Assert.AreEqual(true, DisposableWalker.Disposes(symbol, semanticModel, CancellationToken.None));
             }
+
+            [Test]
+            public static void WhenAddedToFormComponents()
+            {
+                var code = @"
+namespace ValidCode
+{
+    using System.IO;
+    using System.Windows.Forms;
+
+    public class Winform : Form
+    {
+        Winform()
+        {
+            var stream = File.OpenRead(string.Empty);
+            // Since this is added to components, it is automatically disposed of with the form.
+            this.components.Add(stream);
+        }
+    }
+}";
+                var syntaxTree = CSharpSyntaxTree.ParseText(code);
+                var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, MetadataReferences.FromAttributes());
+                var semanticModel = compilation.GetSemanticModel(syntaxTree);
+                var value = syntaxTree.FindVariableDeclaration("stream = File.OpenRead(string.Empty)");
+                Assert.AreEqual(true, semanticModel.TryGetSymbol(value, CancellationToken.None, out ILocalSymbol symbol));
+                Assert.AreEqual(true, DisposableWalker.Disposes(symbol, semanticModel, CancellationToken.None));
+            }
         }
     }
 }

IDisposableAnalyzers.Test/IDISP004DoNotIgnoreCreatedTests/Valid.cs

@@ -787,6 +787,28 @@ public async Task M()
             await System.Windows.Threading.Dispatcher.CurrentDispatcher.Invoke(() => Task.FromResult(42)).ConfigureAwait(false);
         }
     }
+}";
+            RoslynAssert.Valid(Analyzer, code);
+        }
+
+        [Test]
+        public static void WhenAddedToFormComponents()
+        {
+            var code = @"
+namespace ValidCode
+{
+    using System.IO;
+    using System.Windows.Forms;
+
+    public class Winform : Form
+    {
+        Winform()
+        {
+            var stream = File.OpenRead(string.Empty);
+            // Since this is added to components, it is automatically disposed of with the form.
+            this.components.Add(stream);
+        }
+    }
 }";
             RoslynAssert.Valid(Analyzer, code);
         }