Add tests for IServiceProvider.GetRequiredService

No repro for #210

Author: JohanLarsson

IDisposableAnalyzers.NetCoreTests/IDISP004DontIgnoreReturnValueOfTypeIDisposableTests/Valid.cs

@@ -32,5 +32,36 @@ public void Configure(
 }";
             RoslynAssert.Valid(Analyzer, code);
         }
+
+        [TestCase("var disposable = serviceProvider.GetRequiredService<Disposable>();")]
+        [TestCase("_ = serviceProvider.GetRequiredService<Disposable>();")]
+        [TestCase("var loggerFactory = serviceProvider.GetRequiredService<ILoggerFactory>();")]
+        [TestCase("_ = serviceProvider.GetRequiredService<ILoggerFactory>();")]
+        public static void IServiceProviderGetRequiredService(string statement)
+        {
+            var code = @"
+namespace N
+{
+    using System;
+    using Microsoft.Extensions.DependencyInjection;
+    using Microsoft.Extensions.Logging;
+
+    public class C
+    {
+        public C(IServiceProvider serviceProvider)
+        {
+            var disposable = serviceProvider.GetRequiredService<Disposable>();
+        }
+
+        public sealed class Disposable : IDisposable
+        {
+            public void Dispose()
+            {
+            }
+        }
+    }
+}".AssertReplace("var disposable = serviceProvider.GetRequiredService<Disposable>();", statement);
+            RoslynAssert.Valid(Analyzer, code);
+        }
     }
 }

IDisposableAnalyzers/Analyzers/FieldAndPropertyDeclarationAnalyzer.cs

@@ -131,7 +131,7 @@ static bool IsAccessible(Accessibility accessibility, INamedTypeSymbol containin
                     Accessibility.ProtectedOrInternal => true,
                     Accessibility.ProtectedAndInternal => true,
                     Accessibility.Public => true,
-                    _ => throw new ArgumentOutOfRangeException(nameof(accessibility), accessibility, "Unhandled accessibility")
+                    _ => throw new ArgumentOutOfRangeException(nameof(accessibility), accessibility, "Unhandled accessibility"),
                 };
             }
         }

IDisposableAnalyzers/Helpers/Disposable.Disposes.cs

@@ -175,7 +175,7 @@ when Winform.IsComponentsAdd(invocation, recursion.SemanticModel, recursion.Canc
                 when recursion.Target(argument) is { } target
                 => DisposedByReturnValue(target, recursion, out var wrapper) &&
                    Disposes(wrapper, recursion),
-                _ => false
+                _ => false,
             };
 
             bool IsDisposeOrReturnValueDisposed(InvocationExpressionSyntax invocation)

IDisposableAnalyzers/Helpers/Disposable.Ignores.cs

@@ -80,7 +80,7 @@ when recursion.Target(argument) is { } target
                 => WrappedAndIgnored(),
                 { Parent: InitializerExpressionSyntax { Parent: ExpressionSyntax creation } }
                 => Ignores(creation, recursion),
-                _ => false
+                _ => false,
             };
 
             bool WrappedAndIgnored()

ValidCode.NetCore/ServiceProviderUsage.cs

@@ -0,0 +1,25 @@
+// ReSharper disable All
+namespace ValidCode.NetCore
+{
+    using System;
+    using Microsoft.Extensions.DependencyInjection;
+    using Microsoft.Extensions.Logging;
+
+    public class ServiceProviderUsage
+    {
+        public ServiceProviderUsage(IServiceProvider serviceProvider)
+        {
+            var disposable = serviceProvider.GetRequiredService<Disposable>();
+            _ = serviceProvider.GetRequiredService<Disposable>();
+            var loggerFactory = serviceProvider.GetRequiredService<ILoggerFactory>();
+            _ = serviceProvider.GetRequiredService<ILoggerFactory>();
+        }
+
+        public sealed class Disposable : IDisposable
+        {
+            public void Dispose()
+            {
+            }
+        }
+    }
+}