Use target typed new

Author: JohanLarsson

PropertyChangedAnalyzers/Analyzers/SetAccessorAnalyzer.cs

@@ -469,7 +469,7 @@ internal static EqualState Create(ExpressionSyntax condition, BackingMemberAndVa
                 }
             }
 
-            internal EqualState Invert() => new EqualState(
+            internal EqualState Invert() => new(
                 this.condition,
                 this.MemberAndValue,
                 this.IsValueEqualToBacking is { } b ? !b : (bool?)null);

PropertyChangedAnalyzers/Helpers/Comparers/SyntaxTokenComparer.cs

@@ -1,11 +1,11 @@
-namespace PropertyChangedAnalyzers
+namespace PropertyChangedAnalyzers
 {
     using System.Collections.Generic;
     using Microsoft.CodeAnalysis;
 
     internal sealed class SyntaxTokenComparer : IEqualityComparer<SyntaxToken>
     {
-        internal static readonly SyntaxTokenComparer ByValueText = new SyntaxTokenComparer();
+        internal static readonly SyntaxTokenComparer ByValueText = new();
 
         private SyntaxTokenComparer()
         {

PropertyChangedAnalyzers/Helpers/KnownSymbols/KnownSymbol.cs

@@ -5,39 +5,39 @@ namespace PropertyChangedAnalyzers
 
     internal static class KnownSymbol
     {
-        internal static readonly ObjectType Object = new ObjectType();
-        internal static readonly StringType String = new StringType();
+        internal static readonly ObjectType Object = new();
+        internal static readonly StringType String = new();
         internal static readonly QualifiedType Boolean = Create("System.Boolean", "bool");
         internal static readonly QualifiedType Attribute = Create("System.Attribute");
         internal static readonly QualifiedType IEnumerator = Create("System.Collections.IEnumerator");
         internal static readonly QualifiedType Stream = Create("System.IO.Stream");
-        internal static readonly NullableType Nullable = new NullableType();
-        internal static readonly NullableOfTType NullableOfT = new NullableOfTType();
-        internal static readonly EqualityComparerOfTType EqualityComparerOfT = new EqualityComparerOfTType();
+        internal static readonly NullableType Nullable = new();
+        internal static readonly NullableOfTType NullableOfT = new();
+        internal static readonly EqualityComparerOfTType EqualityComparerOfT = new();
         internal static readonly QualifiedType LinqExpressionOfT = Create("System.Linq.Expressions.Expression`1");
         internal static readonly QualifiedType ConcurrentDictionaryOfTKeyTValue = Create("System.Collections.Concurrent.ConcurrentDictionary`2");
 
-        internal static readonly QualifiedType CallerMemberNameAttribute = new QualifiedType("System.Runtime.CompilerServices.CallerMemberNameAttribute");
-        internal static readonly INotifyPropertyChangedType INotifyPropertyChanged = new INotifyPropertyChangedType();
-        internal static readonly QualifiedType PropertyChangedEventArgs = new QualifiedType("System.ComponentModel.PropertyChangedEventArgs");
-        internal static readonly QualifiedType BindableAttribute = new QualifiedType("System.ComponentModel.BindableAttribute");
-        internal static readonly PropertyChangedEventHandlerType PropertyChangedEventHandler = new PropertyChangedEventHandlerType();
+        internal static readonly QualifiedType CallerMemberNameAttribute = new("System.Runtime.CompilerServices.CallerMemberNameAttribute");
+        internal static readonly INotifyPropertyChangedType INotifyPropertyChanged = new();
+        internal static readonly QualifiedType PropertyChangedEventArgs = new("System.ComponentModel.PropertyChangedEventArgs");
+        internal static readonly QualifiedType BindableAttribute = new("System.ComponentModel.BindableAttribute");
+        internal static readonly PropertyChangedEventHandlerType PropertyChangedEventHandler = new();
 
-        internal static readonly DependencyObjectType DependencyObject = new DependencyObjectType();
+        internal static readonly DependencyObjectType DependencyObject = new();
         internal static readonly QualifiedType DataTemplateSelector = Create("System.Windows.Controls.DataTemplateSelector");
         internal static readonly QualifiedType MarkupExtension = Create("System.Windows.Markup.MarkupExtension");
         internal static readonly QualifiedType IValueConverter = Create("System.Windows.Data.IValueConverter");
         internal static readonly QualifiedType IMultiValueConverter = Create("System.Windows.Data.IMultiValueConverter");
 
-        internal static readonly MvvmLightViewModelBase MvvmLightViewModelBase = new MvvmLightViewModelBase();
-        internal static readonly MvvmLightObservableObject MvvmLightObservableObject = new MvvmLightObservableObject();
-        internal static readonly CaliburnMicroPropertyChangedBase CaliburnMicroPropertyChangedBase = new CaliburnMicroPropertyChangedBase();
-        internal static readonly StyletPropertyChangedBase StyletPropertyChangedBase = new StyletPropertyChangedBase();
-        internal static readonly MvvmCrossMvxNotifyPropertyChanged MvvmCrossMvxNotifyPropertyChanged = new MvvmCrossMvxNotifyPropertyChanged();
-        internal static readonly MvvmCrossCoreMvxNotifyPropertyChanged MvvmCrossCoreMvxNotifyPropertyChanged = new MvvmCrossCoreMvxNotifyPropertyChanged();
-        internal static readonly MicrosoftPracticesPrismMvvmBindableBase MicrosoftPracticesPrismMvvmBindableBase = new MicrosoftPracticesPrismMvvmBindableBase();
+        internal static readonly MvvmLightViewModelBase MvvmLightViewModelBase = new();
+        internal static readonly MvvmLightObservableObject MvvmLightObservableObject = new();
+        internal static readonly CaliburnMicroPropertyChangedBase CaliburnMicroPropertyChangedBase = new();
+        internal static readonly StyletPropertyChangedBase StyletPropertyChangedBase = new();
+        internal static readonly MvvmCrossMvxNotifyPropertyChanged MvvmCrossMvxNotifyPropertyChanged = new();
+        internal static readonly MvvmCrossCoreMvxNotifyPropertyChanged MvvmCrossCoreMvxNotifyPropertyChanged = new();
+        internal static readonly MicrosoftPracticesPrismMvvmBindableBase MicrosoftPracticesPrismMvvmBindableBase = new();
 
-        internal static readonly QualifiedType JetbrainsNotifyPropertyChangedInvocatorAttribute = new QualifiedType("Jetbrains.Annotations.NotifyPropertyChangedInvocatorAttribute");
+        internal static readonly QualifiedType JetbrainsNotifyPropertyChangedInvocatorAttribute = new("Jetbrains.Annotations.NotifyPropertyChangedInvocatorAttribute");
 
         private static QualifiedType Create(string qualifiedName, string? alias = null)
         {

PropertyChangedAnalyzers/Helpers/PropertyPath.cs

@@ -71,10 +71,10 @@ private static bool Equals(MemberPath.PathWalker xWalker, MemberPath.PathWalker
 
         private sealed class UsedMemberWalker : PooledWalker<UsedMemberWalker>
         {
-            private readonly List<ExpressionSyntax> usedMembers = new List<ExpressionSyntax>();
-            private readonly List<ExpressionSyntax> recursives = new List<ExpressionSyntax>();
-            private readonly HashSet<SyntaxToken> localsAndParameters = new HashSet<SyntaxToken>(SyntaxTokenComparer.ByValueText);
-            private readonly HashSet<SyntaxNode> visited = new HashSet<SyntaxNode>();
+            private readonly List<ExpressionSyntax> usedMembers = new();
+            private readonly List<ExpressionSyntax> recursives = new();
+            private readonly HashSet<SyntaxToken> localsAndParameters = new(SyntaxTokenComparer.ByValueText);
+            private readonly HashSet<SyntaxNode> visited = new();
 
             private SemanticModel semanticModel = null!;
             private CancellationToken cancellationToken;

PropertyChangedAnalyzers/Helpers/Walkers/AssignmentWalker.cs

@@ -1,4 +1,4 @@
-namespace PropertyChangedAnalyzers
+namespace PropertyChangedAnalyzers
 {
     using System.Collections.Generic;
     using Gu.Roslyn.AnalyzerExtensions;
@@ -7,7 +7,7 @@ namespace PropertyChangedAnalyzers
 
     internal sealed class AssignmentWalker : PooledWalker<AssignmentWalker>
     {
-        private readonly List<AssignmentExpressionSyntax> assignments = new List<AssignmentExpressionSyntax>();
+        private readonly List<AssignmentExpressionSyntax> assignments = new();
 
         private AssignmentWalker()
         {

PropertyChangedAnalyzers/Helpers/Walkers/IdentifierNameWalker.cs

@@ -8,7 +8,7 @@
 
     internal sealed class IdentifierNameWalker : PooledWalker<IdentifierNameWalker>
     {
-        private readonly List<IdentifierNameSyntax> identifierNames = new List<IdentifierNameSyntax>();
+        private readonly List<IdentifierNameSyntax> identifierNames = new();
 
         private IdentifierNameWalker()
         {

PropertyChangedAnalyzers/Helpers/Walkers/IdentifierTypeWalker.cs

@@ -6,8 +6,8 @@
 
     internal sealed class IdentifierTypeWalker : PooledWalker<IdentifierTypeWalker>
     {
-        private readonly List<ParameterSyntax> parameters = new List<ParameterSyntax>();
-        private readonly List<VariableDeclaratorSyntax> locals = new List<VariableDeclaratorSyntax>();
+        private readonly List<ParameterSyntax> parameters = new();
+        private readonly List<VariableDeclaratorSyntax> locals = new();
 
         public override void VisitParameter(ParameterSyntax node)
         {

ValidCode/LockInSetter.cs

@@ -7,7 +7,7 @@ namespace ValidCode
 
     public class LockInSetter : INotifyPropertyChanged
     {
-        private readonly object _busyLock = new object();
+        private readonly object _busyLock = new();
         private bool _value;
 
         public event PropertyChangedEventHandler? PropertyChanged;