Fix tests.

JohanLarsson · JohanLarsson · commit 52a5a570d26b · 2021-12-10T08:46:19.000+01:00
diff --git a/PropertyChangedAnalyzers.Test/INPC001ImplementINotifyPropertyChanged/Valid.Ignores.cs b/PropertyChangedAnalyzers.Test/INPC001ImplementINotifyPropertyChanged/Valid.Ignores.cs
@@ -145,6 +145,7 @@ public static void StaticEvent()
             {
                 // maybe this should notify?
                 var code = @"
+#pragma warning disable CS0067
 namespace N
 {
     using System.ComponentModel;
diff --git a/PropertyChangedAnalyzers.Test/INPC002MutablePublicPropertyShouldNotify/CodeFix.Style.cs b/PropertyChangedAnalyzers.Test/INPC002MutablePublicPropertyShouldNotify/CodeFix.Style.cs
@@ -17,16 +17,16 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        public event PropertyChangedEventHandler PropertyChanged;
+        public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string ↓P { get; set; }
+        public int ↓P { get; set; }
 
-        protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)
+        protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)
         {
             this.PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
         }
 
-        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)
+        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)
         {
             if (EqualityComparer<T>.Default.Equals(field, newValue))
             {
@@ -49,18 +49,18 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string p;
+        private int p;
 
-        public event PropertyChangedEventHandler PropertyChanged;
+        public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string P { get => this.p; set => this.TrySet(ref this.p, value); }
+        public int P { get => this.p; set => this.TrySet(ref this.p, value); }
 
-        protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)
+        protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)
         {
             this.PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
         }
 
-        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)
+        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)
         {
             if (EqualityComparer<T>.Default.Equals(field, newValue))
             {
@@ -89,16 +89,16 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        public event PropertyChangedEventHandler PropertyChanged;
+        public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string ↓P { get; set; }
+        public string? ↓P { get; set; }
 
-        protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)
+        protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)
         {
             PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
         }
 
-        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)
+        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)
         {
             if (EqualityComparer<T>.Default.Equals(field, newValue))
             {
@@ -121,18 +121,18 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string _p;
+        private string? _p;
 
-        public event PropertyChangedEventHandler PropertyChanged;
+        public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string P { get => _p; set => TrySet(ref _p, value); }
+        public string? P { get => _p; set => TrySet(ref _p, value); }
 
-        protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)
+        protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)
         {
             PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
         }
 
-        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)
+        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)
         {
             if (EqualityComparer<T>.Default.Equals(field, newValue))
             {
@@ -161,16 +161,16 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        public event PropertyChangedEventHandler PropertyChanged;
+        public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string ↓P { get; set; }
+        public string? ↓P { get; set; }
 
-        protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)
+        protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)
         {
             PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
         }
 
-        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)
+        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)
         {
             if (EqualityComparer<T>.Default.Equals(field, newValue))
             {
@@ -193,18 +193,18 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string _p;
+        private string? _p;
 
-        public event PropertyChangedEventHandler PropertyChanged;
+        public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string P { get => this._p; set => TrySet(ref this._p, value); }
+        public string? P { get => this._p; set => TrySet(ref this._p, value); }
 
-        protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)
+        protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)
         {
             PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
         }
 
-        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)
+        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)
         {
             if (EqualityComparer<T>.Default.Equals(field, newValue))
             {
@@ -233,16 +233,16 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        public event PropertyChangedEventHandler PropertyChanged;
+        public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string ↓P { get; set; }
+        public string? ↓P { get; set; }
 
-        protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)
+        protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)
         {
             PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
         }
 
-        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)
+        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)
         {
             if (EqualityComparer<T>.Default.Equals(field, newValue))
             {
@@ -265,18 +265,18 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string p;
+        private string? p;
 
-        public event PropertyChangedEventHandler PropertyChanged;
+        public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string P { get => p; set => TrySet(ref p, value); }
+        public string? P { get => p; set => TrySet(ref p, value); }
 
-        protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)
+        protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)
         {
             PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
         }
 
-        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)
+        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)
         {
             if (EqualityComparer<T>.Default.Equals(field, newValue))
             {
@@ -305,16 +305,16 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        public event PropertyChangedEventHandler PropertyChanged;
+        public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string ↓P { get; set; }
+        public string? ↓P { get; set; }
 
-        protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)
+        protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)
         {
             PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
         }
 
-        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)
+        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)
         {
             if (EqualityComparer<T>.Default.Equals(field, newValue))
             {
@@ -337,18 +337,18 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string p;
+        private string? p;
 
-        public event PropertyChangedEventHandler PropertyChanged;
+        public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string P { get => this.p; set => TrySet(ref this.p, value); }
+        public string? P { get => this.p; set => TrySet(ref this.p, value); }
 
-        protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)
+        protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)
         {
             PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
         }
 
-        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)
+        protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)
         {
             if (EqualityComparer<T>.Default.Equals(field, newValue))
             {
diff --git a/PropertyChangedAnalyzers.Test/INPC002MutablePublicPropertyShouldNotify/CodeFix.cs b/PropertyChangedAnalyzers.Test/INPC002MutablePublicPropertyShouldNotify/CodeFix.cs

Original file line number	Diff line number	Diff line change
`@@ -145,6 +145,7 @@ public static void StaticEvent()`
`145`	`145`	`{`
`146`	`146`	`// maybe this should notify?`
`147`	`147`	`var code = @"`
	`148`	`+#pragma warning disable CS0067`
`148`	`149`	`namespace N`
`149`	`150`	`{`
`150`	`151`	`using System.ComponentModel;`
Original file line number	Diff line number	Diff line change
`@@ -17,16 +17,16 @@ namespace N`
`17`	`17`
`18`	`18`	`public class C : INotifyPropertyChanged`
`19`	`19`	`{`
`20`		`- public event PropertyChangedEventHandler PropertyChanged;`
	`20`	`+ public event PropertyChangedEventHandler? PropertyChanged;`
`21`	`21`
`22`		`- public string ↓P { get; set; }`
	`22`	`+ public int ↓P { get; set; }`
`23`	`23`
`24`		`- protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)`
	`24`	`+ protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)`
`25`	`25`	`{`
`26`	`26`	`this.PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));`
`27`	`27`	`}`
`28`	`28`
`29`		`- protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)`
	`29`	`+ protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)`
`30`	`30`	`{`
`31`	`31`	`if (EqualityComparer<T>.Default.Equals(field, newValue))`
`32`	`32`	`{`
`@@ -49,18 +49,18 @@ namespace N`
`49`	`49`
`50`	`50`	`public class C : INotifyPropertyChanged`
`51`	`51`	`{`
`52`		`- private string p;`
	`52`	`+ private int p;`
`53`	`53`
`54`		`- public event PropertyChangedEventHandler PropertyChanged;`
	`54`	`+ public event PropertyChangedEventHandler? PropertyChanged;`
`55`	`55`
`56`		`- public string P { get => this.p; set => this.TrySet(ref this.p, value); }`
	`56`	`+ public int P { get => this.p; set => this.TrySet(ref this.p, value); }`
`57`	`57`
`58`		`- protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)`
	`58`	`+ protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)`
`59`	`59`	`{`
`60`	`60`	`this.PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));`
`61`	`61`	`}`
`62`	`62`
`63`		`- protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)`
	`63`	`+ protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)`
`64`	`64`	`{`
`65`	`65`	`if (EqualityComparer<T>.Default.Equals(field, newValue))`
`66`	`66`	`{`
`@@ -89,16 +89,16 @@ namespace N`
`89`	`89`
`90`	`90`	`public class C : INotifyPropertyChanged`
`91`	`91`	`{`
`92`		`- public event PropertyChangedEventHandler PropertyChanged;`
	`92`	`+ public event PropertyChangedEventHandler? PropertyChanged;`
`93`	`93`
`94`		`- public string ↓P { get; set; }`
	`94`	`+ public string? ↓P { get; set; }`
`95`	`95`
`96`		`- protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)`
	`96`	`+ protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)`
`97`	`97`	`{`
`98`	`98`	`PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));`
`99`	`99`	`}`
`100`	`100`
`101`		`- protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)`
	`101`	`+ protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)`
`102`	`102`	`{`
`103`	`103`	`if (EqualityComparer<T>.Default.Equals(field, newValue))`
`104`	`104`	`{`
`@@ -121,18 +121,18 @@ namespace N`
`121`	`121`
`122`	`122`	`public class C : INotifyPropertyChanged`
`123`	`123`	`{`
`124`		`- private string _p;`
	`124`	`+ private string? _p;`
`125`	`125`
`126`		`- public event PropertyChangedEventHandler PropertyChanged;`
	`126`	`+ public event PropertyChangedEventHandler? PropertyChanged;`
`127`	`127`
`128`		`- public string P { get => _p; set => TrySet(ref _p, value); }`
	`128`	`+ public string? P { get => _p; set => TrySet(ref _p, value); }`
`129`	`129`
`130`		`- protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)`
	`130`	`+ protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)`
`131`	`131`	`{`
`132`	`132`	`PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));`
`133`	`133`	`}`
`134`	`134`
`135`		`- protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)`
	`135`	`+ protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)`
`136`	`136`	`{`
`137`	`137`	`if (EqualityComparer<T>.Default.Equals(field, newValue))`
`138`	`138`	`{`
`@@ -161,16 +161,16 @@ namespace N`
`161`	`161`
`162`	`162`	`public class C : INotifyPropertyChanged`
`163`	`163`	`{`
`164`		`- public event PropertyChangedEventHandler PropertyChanged;`
	`164`	`+ public event PropertyChangedEventHandler? PropertyChanged;`
`165`	`165`
`166`		`- public string ↓P { get; set; }`
	`166`	`+ public string? ↓P { get; set; }`
`167`	`167`
`168`		`- protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)`
	`168`	`+ protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)`
`169`	`169`	`{`
`170`	`170`	`PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));`
`171`	`171`	`}`
`172`	`172`
`173`		`- protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)`
	`173`	`+ protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)`
`174`	`174`	`{`
`175`	`175`	`if (EqualityComparer<T>.Default.Equals(field, newValue))`
`176`	`176`	`{`
`@@ -193,18 +193,18 @@ namespace N`
`193`	`193`
`194`	`194`	`public class C : INotifyPropertyChanged`
`195`	`195`	`{`
`196`		`- private string _p;`
	`196`	`+ private string? _p;`
`197`	`197`
`198`		`- public event PropertyChangedEventHandler PropertyChanged;`
	`198`	`+ public event PropertyChangedEventHandler? PropertyChanged;`
`199`	`199`
`200`		`- public string P { get => this._p; set => TrySet(ref this._p, value); }`
	`200`	`+ public string? P { get => this._p; set => TrySet(ref this._p, value); }`
`201`	`201`
`202`		`- protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)`
	`202`	`+ protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)`
`203`	`203`	`{`
`204`	`204`	`PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));`
`205`	`205`	`}`
`206`	`206`
`207`		`- protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)`
	`207`	`+ protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)`
`208`	`208`	`{`
`209`	`209`	`if (EqualityComparer<T>.Default.Equals(field, newValue))`
`210`	`210`	`{`
`@@ -233,16 +233,16 @@ namespace N`
`233`	`233`
`234`	`234`	`public class C : INotifyPropertyChanged`
`235`	`235`	`{`
`236`		`- public event PropertyChangedEventHandler PropertyChanged;`
	`236`	`+ public event PropertyChangedEventHandler? PropertyChanged;`
`237`	`237`
`238`		`- public string ↓P { get; set; }`
	`238`	`+ public string? ↓P { get; set; }`
`239`	`239`
`240`		`- protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)`
	`240`	`+ protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)`
`241`	`241`	`{`
`242`	`242`	`PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));`
`243`	`243`	`}`
`244`	`244`
`245`		`- protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)`
	`245`	`+ protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)`
`246`	`246`	`{`
`247`	`247`	`if (EqualityComparer<T>.Default.Equals(field, newValue))`
`248`	`248`	`{`
`@@ -265,18 +265,18 @@ namespace N`
`265`	`265`
`266`	`266`	`public class C : INotifyPropertyChanged`
`267`	`267`	`{`
`268`		`- private string p;`
	`268`	`+ private string? p;`
`269`	`269`
`270`		`- public event PropertyChangedEventHandler PropertyChanged;`
	`270`	`+ public event PropertyChangedEventHandler? PropertyChanged;`
`271`	`271`
`272`		`- public string P { get => p; set => TrySet(ref p, value); }`
	`272`	`+ public string? P { get => p; set => TrySet(ref p, value); }`
`273`	`273`
`274`		`- protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)`
	`274`	`+ protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)`
`275`	`275`	`{`
`276`	`276`	`PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));`
`277`	`277`	`}`
`278`	`278`
`279`		`- protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)`
	`279`	`+ protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)`
`280`	`280`	`{`
`281`	`281`	`if (EqualityComparer<T>.Default.Equals(field, newValue))`
`282`	`282`	`{`
`@@ -305,16 +305,16 @@ namespace N`
`305`	`305`
`306`	`306`	`public class C : INotifyPropertyChanged`
`307`	`307`	`{`
`308`		`- public event PropertyChangedEventHandler PropertyChanged;`
	`308`	`+ public event PropertyChangedEventHandler? PropertyChanged;`
`309`	`309`
`310`		`- public string ↓P { get; set; }`
	`310`	`+ public string? ↓P { get; set; }`
`311`	`311`
`312`		`- protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)`
	`312`	`+ protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)`
`313`	`313`	`{`
`314`	`314`	`PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));`
`315`	`315`	`}`
`316`	`316`
`317`		`- protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)`
	`317`	`+ protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)`
`318`	`318`	`{`
`319`	`319`	`if (EqualityComparer<T>.Default.Equals(field, newValue))`
`320`	`320`	`{`
`@@ -337,18 +337,18 @@ namespace N`
`337`	`337`
`338`	`338`	`public class C : INotifyPropertyChanged`
`339`	`339`	`{`
`340`		`- private string p;`
	`340`	`+ private string? p;`
`341`	`341`
`342`		`- public event PropertyChangedEventHandler PropertyChanged;`
	`342`	`+ public event PropertyChangedEventHandler? PropertyChanged;`
`343`	`343`
`344`		`- public string P { get => this.p; set => TrySet(ref this.p, value); }`
	`344`	`+ public string? P { get => this.p; set => TrySet(ref this.p, value); }`
`345`	`345`
`346`		`- protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)`
	`346`	`+ protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)`
`347`	`347`	`{`
`348`	`348`	`PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));`
`349`	`349`	`}`
`350`	`350`
`351`		`- protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string propertyName = null)`
	`351`	`+ protected bool TrySet<T>(ref T field, T newValue, [CallerMemberName] string? propertyName = null)`
`352`	`352`	`{`
`353`	`353`	`if (EqualityComparer<T>.Default.Equals(field, newValue))`
`354`	`354`	`{`