Annotate test code.

JohanLarsson · JohanLarsson · commit 64f13e0e4489 · 2021-12-10T12:46:25.000+01:00
diff --git a/PropertyChangedAnalyzers.Test/INPC003NotifyForDependentProperty/CodeFix.cs b/PropertyChangedAnalyzers.Test/INPC003NotifyForDependentProperty/CodeFix.cs
@@ -700,8 +700,8 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string firstName;
-        private string lastName;
+        private string? firstName;
+        private string? lastName;
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
@@ -715,7 +715,7 @@ public string FullName
             }
         }
 
-        public string FirstName
+        public string? FirstName
         {
             get
             {
@@ -735,7 +735,7 @@ public string FirstName
             }
         }
 
-        public string LastName
+        public string? LastName
         {
             get
             {
@@ -771,8 +771,8 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string firstName;
-        private string lastName;
+        private string? firstName;
+        private string? lastName;
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
@@ -786,7 +786,7 @@ public string FullName
             }
         }
 
-        public string FirstName
+        public string? FirstName
         {
             get
             {
@@ -807,7 +807,7 @@ public string FirstName
             }
         }
 
-        public string LastName
+        public string? LastName
         {
             get
             {
@@ -2236,12 +2236,12 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string p2;
-        private string p3;
+        private string? p2;
+        private string? p3;
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
-        public IEnumerable<string> P1
+        public IEnumerable<string?> P1
         {
             get
             {
@@ -2250,7 +2250,7 @@ public IEnumerable<string> P1
             }
         }
 
-        public string P2
+        public string? P2
         {
             get
             {
@@ -2269,7 +2269,7 @@ public string P2
             }
         }
 
-        public string P3
+        public string? P3
         {
             get
             {
@@ -2305,12 +2305,12 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string p2;
-        private string p3;
+        private string? p2;
+        private string? p3;
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
-        public IEnumerable<string> P1
+        public IEnumerable<string?> P1
         {
             get
             {
@@ -2319,7 +2319,7 @@ public IEnumerable<string> P1
             }
         }
 
-        public string P2
+        public string? P2
         {
             get
             {
@@ -2339,7 +2339,7 @@ public string P2
             }
         }
 
-        public string P3
+        public string? P3
         {
             get
             {
@@ -2381,8 +2381,8 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string firstName;
-        private string lastName;
+        private string? firstName;
+        private string? lastName;
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
@@ -2394,7 +2394,7 @@ public string FullName
             }
         }
 
-        public string FirstName
+        public string? FirstName
         {
             get
             {
@@ -2413,7 +2413,7 @@ public string FirstName
             }
         }
 
-        public string LastName
+        public string? LastName
         {
             get
             {
@@ -2448,8 +2448,8 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string firstName;
-        private string lastName;
+        private string? firstName;
+        private string? lastName;
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
@@ -2461,7 +2461,7 @@ public string FullName
             }
         }
 
-        public string FirstName
+        public string? FirstName
         {
             get
             {
@@ -2481,7 +2481,7 @@ public string FirstName
             }
         }
 
-        public string LastName
+        public string? LastName
         {
             get
             {
@@ -2522,11 +2522,11 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string p;
+        private string? p;
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string CalculatedName
+        public string? CalculatedName
         {
             get
             {
@@ -2540,7 +2540,7 @@ public string CalculatedName
             }
         }
 
-        public string P
+        public string? P
         {
             get
             {
@@ -2574,11 +2574,11 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string p;
+        private string? p;
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string CalculatedName
+        public string? CalculatedName
         {
             get
             {
@@ -2592,7 +2592,7 @@ public string CalculatedName
             }
         }
 
-        public string P
+        public string? P
         {
             get
             {
@@ -2633,8 +2633,8 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string _firstName;
-        private string _lastName;
+        private string? _firstName;
+        private string? _lastName;
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
@@ -2646,7 +2646,7 @@ public string FullName
             }
         }
 
-        public string FirstName
+        public string? FirstName
         {
             get
             {
@@ -2665,7 +2665,7 @@ public string FirstName
             }
         }
 
-        public string LastName
+        public string? LastName
         {
             get
             {
@@ -2700,8 +2700,8 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string _firstName;
-        private string _lastName;
+        private string? _firstName;
+        private string? _lastName;
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
@@ -2713,7 +2713,7 @@ public string FullName
             }
         }
 
-        public string FirstName
+        public string? FirstName
         {
             get
             {
@@ -2733,7 +2733,7 @@ public string FirstName
             }
         }
 
-        public string LastName
+        public string? LastName
         {
             get
             {
diff --git a/PropertyChangedAnalyzers.Test/INPC005CheckIfDifferentBeforeNotifying/Valid.CaliburnMicro.cs b/PropertyChangedAnalyzers.Test/INPC005CheckIfDifferentBeforeNotifying/Valid.CaliburnMicro.cs
@@ -18,11 +18,11 @@ namespace N
 {
     public class C : Caliburn.Micro.PropertyChangedBase
     {
-        private string p2;
+        private int p2;
 
         public string P1 => $""Hello {this.P2}"";
 
-        public string P2
+        public int P2
         {
             get { return this.p2; }
             set
@@ -46,11 +46,11 @@ namespace N
 {
     public class C : Caliburn.Micro.PropertyChangedBase
     {
-        private string p2;
+        private int p2;
 
         public string P1 => $""Hello {this.P2}"";
 
-        public string P2
+        public int P2
         {
             get { return this.p2; }
             set
@@ -74,13 +74,13 @@ namespace N
 {
     public class C : Caliburn.Micro.PropertyChangedBase
     {
-        private string p3;
+        private int p3;
 
         public string P1 => $""Hello {this.P3}"";
 
         public string P2 => $""Hej {this.P3}"";
 
-        public string P3
+        public int P3
         {
             get { return this.p3; }
             set
@@ -105,13 +105,13 @@ namespace N
 {
     public class C : Caliburn.Micro.PropertyChangedBase
     {
-        private string p3;
+        private int p3;
 
         public string P1 => $""Hello {this.P3}"";
 
         public string P2 => $""Hej {this.P3}"";
 
-        public string P3
+        public int P3
         {
             get { return this.p3; }
             set
@@ -136,12 +136,12 @@ namespace N
 {
     public class C : Caliburn.Micro.PropertyChangedBase
     {
-        private string firstName;
-        private string lastName;
+        private string? firstName;
+        private string? lastName;
 
         public string FullName => $""{this.FirstName} {this.LastName}"";
 
-        public string FirstName
+        public string? FirstName
         {
             get
             {
@@ -161,7 +161,7 @@ public string FirstName
             }
         }
 
-        public string LastName
+        public string? LastName
         {
             get
             {
@@ -193,11 +193,11 @@ namespace N
 {
     public class C : Caliburn.Micro.PropertyChangedBase
     {
-        private string p2;
+        private int p2;
 
         public string P1 => $""Hello {this.P2}"";
 
-        public string P2
+        public int P2
         {
             get { return this.p2; }
             set
diff --git a/PropertyChangedAnalyzers.Test/INPC005CheckIfDifferentBeforeNotifying/Valid.cs b/PropertyChangedAnalyzers.Test/INPC005CheckIfDifferentBeforeNotifying/Valid.cs

Original file line number	Diff line number	Diff line change
`@@ -700,8 +700,8 @@ namespace N`
`700`	`700`
`701`	`701`	`public class C : INotifyPropertyChanged`
`702`	`702`	`{`
`703`		`- private string firstName;`
`704`		`- private string lastName;`
	`703`	`+ private string? firstName;`
	`704`	`+ private string? lastName;`
`705`	`705`
`706`	`706`	`public event PropertyChangedEventHandler? PropertyChanged;`
`707`	`707`
`@@ -715,7 +715,7 @@ public string FullName`
`715`	`715`	`}`
`716`	`716`	`}`
`717`	`717`
`718`		`- public string FirstName`
	`718`	`+ public string? FirstName`
`719`	`719`	`{`
`720`	`720`	`get`
`721`	`721`	`{`
`@@ -735,7 +735,7 @@ public string FirstName`
`735`	`735`	`}`
`736`	`736`	`}`
`737`	`737`
`738`		`- public string LastName`
	`738`	`+ public string? LastName`
`739`	`739`	`{`
`740`	`740`	`get`
`741`	`741`	`{`
`@@ -771,8 +771,8 @@ namespace N`
`771`	`771`
`772`	`772`	`public class C : INotifyPropertyChanged`
`773`	`773`	`{`
`774`		`- private string firstName;`
`775`		`- private string lastName;`
	`774`	`+ private string? firstName;`
	`775`	`+ private string? lastName;`
`776`	`776`
`777`	`777`	`public event PropertyChangedEventHandler? PropertyChanged;`
`778`	`778`
`@@ -786,7 +786,7 @@ public string FullName`
`786`	`786`	`}`
`787`	`787`	`}`
`788`	`788`
`789`		`- public string FirstName`
	`789`	`+ public string? FirstName`
`790`	`790`	`{`
`791`	`791`	`get`
`792`	`792`	`{`
`@@ -807,7 +807,7 @@ public string FirstName`
`807`	`807`	`}`
`808`	`808`	`}`
`809`	`809`
`810`		`- public string LastName`
	`810`	`+ public string? LastName`
`811`	`811`	`{`
`812`	`812`	`get`
`813`	`813`	`{`
`@@ -2236,12 +2236,12 @@ namespace N`
`2236`	`2236`
`2237`	`2237`	`public class C : INotifyPropertyChanged`
`2238`	`2238`	`{`
`2239`		`- private string p2;`
`2240`		`- private string p3;`
	`2239`	`+ private string? p2;`
	`2240`	`+ private string? p3;`
`2241`	`2241`
`2242`	`2242`	`public event PropertyChangedEventHandler? PropertyChanged;`
`2243`	`2243`
`2244`		`- public IEnumerable<string> P1`
	`2244`	`+ public IEnumerable<string?> P1`
`2245`	`2245`	`{`
`2246`	`2246`	`get`
`2247`	`2247`	`{`
`@@ -2250,7 +2250,7 @@ public IEnumerable<string> P1`
`2250`	`2250`	`}`
`2251`	`2251`	`}`
`2252`	`2252`
`2253`		`- public string P2`
	`2253`	`+ public string? P2`
`2254`	`2254`	`{`
`2255`	`2255`	`get`
`2256`	`2256`	`{`
`@@ -2269,7 +2269,7 @@ public string P2`
`2269`	`2269`	`}`
`2270`	`2270`	`}`
`2271`	`2271`
`2272`		`- public string P3`
	`2272`	`+ public string? P3`
`2273`	`2273`	`{`
`2274`	`2274`	`get`
`2275`	`2275`	`{`
`@@ -2305,12 +2305,12 @@ namespace N`
`2305`	`2305`
`2306`	`2306`	`public class C : INotifyPropertyChanged`
`2307`	`2307`	`{`
`2308`		`- private string p2;`
`2309`		`- private string p3;`
	`2308`	`+ private string? p2;`
	`2309`	`+ private string? p3;`
`2310`	`2310`
`2311`	`2311`	`public event PropertyChangedEventHandler? PropertyChanged;`
`2312`	`2312`
`2313`		`- public IEnumerable<string> P1`
	`2313`	`+ public IEnumerable<string?> P1`
`2314`	`2314`	`{`
`2315`	`2315`	`get`
`2316`	`2316`	`{`
`@@ -2319,7 +2319,7 @@ public IEnumerable<string> P1`
`2319`	`2319`	`}`
`2320`	`2320`	`}`
`2321`	`2321`
`2322`		`- public string P2`
	`2322`	`+ public string? P2`
`2323`	`2323`	`{`
`2324`	`2324`	`get`
`2325`	`2325`	`{`
`@@ -2339,7 +2339,7 @@ public string P2`
`2339`	`2339`	`}`
`2340`	`2340`	`}`
`2341`	`2341`
`2342`		`- public string P3`
	`2342`	`+ public string? P3`
`2343`	`2343`	`{`
`2344`	`2344`	`get`
`2345`	`2345`	`{`
`@@ -2381,8 +2381,8 @@ namespace N`
`2381`	`2381`
`2382`	`2382`	`public class C : INotifyPropertyChanged`
`2383`	`2383`	`{`
`2384`		`- private string firstName;`
`2385`		`- private string lastName;`
	`2384`	`+ private string? firstName;`
	`2385`	`+ private string? lastName;`
`2386`	`2386`
`2387`	`2387`	`public event PropertyChangedEventHandler? PropertyChanged;`
`2388`	`2388`
`@@ -2394,7 +2394,7 @@ public string FullName`
`2394`	`2394`	`}`
`2395`	`2395`	`}`
`2396`	`2396`
`2397`		`- public string FirstName`
	`2397`	`+ public string? FirstName`
`2398`	`2398`	`{`
`2399`	`2399`	`get`
`2400`	`2400`	`{`
`@@ -2413,7 +2413,7 @@ public string FirstName`
`2413`	`2413`	`}`
`2414`	`2414`	`}`
`2415`	`2415`
`2416`		`- public string LastName`
	`2416`	`+ public string? LastName`
`2417`	`2417`	`{`
`2418`	`2418`	`get`
`2419`	`2419`	`{`
`@@ -2448,8 +2448,8 @@ namespace N`
`2448`	`2448`
`2449`	`2449`	`public class C : INotifyPropertyChanged`
`2450`	`2450`	`{`
`2451`		`- private string firstName;`
`2452`		`- private string lastName;`
	`2451`	`+ private string? firstName;`
	`2452`	`+ private string? lastName;`
`2453`	`2453`
`2454`	`2454`	`public event PropertyChangedEventHandler? PropertyChanged;`
`2455`	`2455`
`@@ -2461,7 +2461,7 @@ public string FullName`
`2461`	`2461`	`}`
`2462`	`2462`	`}`
`2463`	`2463`
`2464`		`- public string FirstName`
	`2464`	`+ public string? FirstName`
`2465`	`2465`	`{`
`2466`	`2466`	`get`
`2467`	`2467`	`{`
`@@ -2481,7 +2481,7 @@ public string FirstName`
`2481`	`2481`	`}`
`2482`	`2482`	`}`
`2483`	`2483`
`2484`		`- public string LastName`
	`2484`	`+ public string? LastName`
`2485`	`2485`	`{`
`2486`	`2486`	`get`
`2487`	`2487`	`{`
`@@ -2522,11 +2522,11 @@ namespace N`
`2522`	`2522`
`2523`	`2523`	`public class C : INotifyPropertyChanged`
`2524`	`2524`	`{`
`2525`		`- private string p;`
	`2525`	`+ private string? p;`
`2526`	`2526`
`2527`	`2527`	`public event PropertyChangedEventHandler? PropertyChanged;`
`2528`	`2528`
`2529`		`- public string CalculatedName`
	`2529`	`+ public string? CalculatedName`
`2530`	`2530`	`{`
`2531`	`2531`	`get`
`2532`	`2532`	`{`
`@@ -2540,7 +2540,7 @@ public string CalculatedName`
`2540`	`2540`	`}`
`2541`	`2541`	`}`
`2542`	`2542`
`2543`		`- public string P`
	`2543`	`+ public string? P`
`2544`	`2544`	`{`
`2545`	`2545`	`get`
`2546`	`2546`	`{`
`@@ -2574,11 +2574,11 @@ namespace N`
`2574`	`2574`
`2575`	`2575`	`public class C : INotifyPropertyChanged`
`2576`	`2576`	`{`
`2577`		`- private string p;`
	`2577`	`+ private string? p;`
`2578`	`2578`
`2579`	`2579`	`public event PropertyChangedEventHandler? PropertyChanged;`
`2580`	`2580`
`2581`		`- public string CalculatedName`
	`2581`	`+ public string? CalculatedName`
`2582`	`2582`	`{`
`2583`	`2583`	`get`
`2584`	`2584`	`{`
`@@ -2592,7 +2592,7 @@ public string CalculatedName`
`2592`	`2592`	`}`
`2593`	`2593`	`}`
`2594`	`2594`
`2595`		`- public string P`
	`2595`	`+ public string? P`
`2596`	`2596`	`{`
`2597`	`2597`	`get`
`2598`	`2598`	`{`
`@@ -2633,8 +2633,8 @@ namespace N`
`2633`	`2633`
`2634`	`2634`	`public class C : INotifyPropertyChanged`
`2635`	`2635`	`{`
`2636`		`- private string _firstName;`
`2637`		`- private string _lastName;`
	`2636`	`+ private string? _firstName;`
	`2637`	`+ private string? _lastName;`
`2638`	`2638`
`2639`	`2639`	`public event PropertyChangedEventHandler? PropertyChanged;`
`2640`	`2640`
`@@ -2646,7 +2646,7 @@ public string FullName`
`2646`	`2646`	`}`
`2647`	`2647`	`}`
`2648`	`2648`
`2649`		`- public string FirstName`
	`2649`	`+ public string? FirstName`
`2650`	`2650`	`{`
`2651`	`2651`	`get`
`2652`	`2652`	`{`
`@@ -2665,7 +2665,7 @@ public string FirstName`
`2665`	`2665`	`}`
`2666`	`2666`	`}`
`2667`	`2667`
`2668`		`- public string LastName`
	`2668`	`+ public string? LastName`
`2669`	`2669`	`{`
`2670`	`2670`	`get`
`2671`	`2671`	`{`
`@@ -2700,8 +2700,8 @@ namespace N`
`2700`	`2700`
`2701`	`2701`	`public class C : INotifyPropertyChanged`
`2702`	`2702`	`{`
`2703`		`- private string _firstName;`
`2704`		`- private string _lastName;`
	`2703`	`+ private string? _firstName;`
	`2704`	`+ private string? _lastName;`
`2705`	`2705`
`2706`	`2706`	`public event PropertyChangedEventHandler? PropertyChanged;`
`2707`	`2707`
`@@ -2713,7 +2713,7 @@ public string FullName`
`2713`	`2713`	`}`
`2714`	`2714`	`}`
`2715`	`2715`
`2716`		`- public string FirstName`
	`2716`	`+ public string? FirstName`
`2717`	`2717`	`{`
`2718`	`2718`	`get`
`2719`	`2719`	`{`
`@@ -2733,7 +2733,7 @@ public string FirstName`
`2733`	`2733`	`}`
`2734`	`2734`	`}`
`2735`	`2735`
`2736`		`- public string LastName`
	`2736`	`+ public string? LastName`
`2737`	`2737`	`{`
`2738`	`2738`	`get`
`2739`	`2739`	`{`
Original file line number	Diff line number	Diff line change
`@@ -18,11 +18,11 @@ namespace N`
`18`	`18`	`{`
`19`	`19`	`public class C : Caliburn.Micro.PropertyChangedBase`
`20`	`20`	`{`
`21`		`- private string p2;`
	`21`	`+ private int p2;`
`22`	`22`
`23`	`23`	`public string P1 => $""Hello {this.P2}"";`
`24`	`24`
`25`		`- public string P2`
	`25`	`+ public int P2`
`26`	`26`	`{`
`27`	`27`	`get { return this.p2; }`
`28`	`28`	`set`
`@@ -46,11 +46,11 @@ namespace N`
`46`	`46`	`{`
`47`	`47`	`public class C : Caliburn.Micro.PropertyChangedBase`
`48`	`48`	`{`
`49`		`- private string p2;`
	`49`	`+ private int p2;`
`50`	`50`
`51`	`51`	`public string P1 => $""Hello {this.P2}"";`
`52`	`52`
`53`		`- public string P2`
	`53`	`+ public int P2`
`54`	`54`	`{`
`55`	`55`	`get { return this.p2; }`
`56`	`56`	`set`
`@@ -74,13 +74,13 @@ namespace N`
`74`	`74`	`{`
`75`	`75`	`public class C : Caliburn.Micro.PropertyChangedBase`
`76`	`76`	`{`
`77`		`- private string p3;`
	`77`	`+ private int p3;`
`78`	`78`
`79`	`79`	`public string P1 => $""Hello {this.P3}"";`
`80`	`80`
`81`	`81`	`public string P2 => $""Hej {this.P3}"";`
`82`	`82`
`83`		`- public string P3`
	`83`	`+ public int P3`
`84`	`84`	`{`
`85`	`85`	`get { return this.p3; }`
`86`	`86`	`set`
`@@ -105,13 +105,13 @@ namespace N`
`105`	`105`	`{`
`106`	`106`	`public class C : Caliburn.Micro.PropertyChangedBase`
`107`	`107`	`{`
`108`		`- private string p3;`
	`108`	`+ private int p3;`
`109`	`109`
`110`	`110`	`public string P1 => $""Hello {this.P3}"";`
`111`	`111`
`112`	`112`	`public string P2 => $""Hej {this.P3}"";`
`113`	`113`
`114`		`- public string P3`
	`114`	`+ public int P3`
`115`	`115`	`{`
`116`	`116`	`get { return this.p3; }`
`117`	`117`	`set`
`@@ -136,12 +136,12 @@ namespace N`
`136`	`136`	`{`
`137`	`137`	`public class C : Caliburn.Micro.PropertyChangedBase`
`138`	`138`	`{`
`139`		`- private string firstName;`
`140`		`- private string lastName;`
	`139`	`+ private string? firstName;`
	`140`	`+ private string? lastName;`
`141`	`141`
`142`	`142`	`public string FullName => $""{this.FirstName} {this.LastName}"";`
`143`	`143`
`144`		`- public string FirstName`
	`144`	`+ public string? FirstName`
`145`	`145`	`{`
`146`	`146`	`get`
`147`	`147`	`{`
`@@ -161,7 +161,7 @@ public string FirstName`
`161`	`161`	`}`
`162`	`162`	`}`
`163`	`163`
`164`		`- public string LastName`
	`164`	`+ public string? LastName`
`165`	`165`	`{`
`166`	`166`	`get`
`167`	`167`	`{`
`@@ -193,11 +193,11 @@ namespace N`
`193`	`193`	`{`
`194`	`194`	`public class C : Caliburn.Micro.PropertyChangedBase`
`195`	`195`	`{`
`196`		`- private string p2;`
	`196`	`+ private int p2;`
`197`	`197`
`198`	`198`	`public string P1 => $""Hello {this.P2}"";`
`199`	`199`
`200`		`- public string P2`
	`200`	`+ public int P2`
`201`	`201`	`{`
`202`	`202`	`get { return this.p2; }`
`203`	`203`	`set`