Annotate test code.

JohanLarsson · JohanLarsson · commit c8bb859741c3 · 2021-12-10T10:53:33.000+01:00
diff --git a/PropertyChangedAnalyzers.Test/INPC002MutablePublicPropertyShouldNotify/Valid.MvvmCrossCore.cs b/PropertyChangedAnalyzers.Test/INPC002MutablePublicPropertyShouldNotify/Valid.MvvmCrossCore.cs
@@ -52,7 +52,7 @@ public int P
                 RoslynAssert.Valid(Analyzer, code, settings: Settings);
             }
 
-            [TestCase("(string)null")]
+            [TestCase("(string?)null")]
             [TestCase("string.Empty")]
             [TestCase(@"""P""")]
             [TestCase(@"nameof(P)")]
diff --git a/PropertyChangedAnalyzers.Test/INPC003NotifyForDependentProperty/CodeFix.cs b/PropertyChangedAnalyzers.Test/INPC003NotifyForDependentProperty/CodeFix.cs
@@ -98,7 +98,6 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private static readonly int Two = 2;
         private int _p;
 
         public event PropertyChangedEventHandler? PropertyChanged;
@@ -125,7 +124,6 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private static readonly int Two = 2;
         private int _p;
 
         public event PropertyChangedEventHandler? PropertyChanged;
@@ -959,8 +957,8 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string firstName;
-        private string lastName;
+        private string? firstName;
+        private string? lastName;
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
@@ -974,7 +972,7 @@ public string FullName
             }
         }
 
-        public string FirstName
+        public string? FirstName
         {
             get
             {
@@ -994,7 +992,7 @@ public string FirstName
             }
         }
 
-        public string LastName
+        public string? LastName
         {
             get
             {
@@ -1032,8 +1030,8 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string firstName;
-        private string lastName;
+        private string? firstName;
+        private string? lastName;
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
@@ -1047,7 +1045,7 @@ public string FullName
             }
         }
 
-        public string FirstName
+        public string? FirstName
         {
             get
             {
@@ -1068,7 +1066,7 @@ public string FirstName
             }
         }
 
-        public string LastName
+        public string? LastName
         {
             get
             {
@@ -1785,13 +1783,13 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string p;
+        private string? p;
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string CapsName => this.p.ToUpper();
+        public string? CapsName => this.p?.ToUpper();
 
-        public string P
+        public string? P
         {
             get
             {
@@ -1825,13 +1823,13 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string p;
+        private string? p;
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string CapsName => this.p.ToUpper();
+        public string? CapsName => this.p?.ToUpper();
 
-        public string P
+        public string? P
         {
             get
             {
@@ -2793,9 +2791,9 @@ namespace N.Client
 
     public class C : N.Core.ViewModelBase
     {
-        private string text;
+        private string? text;
 
-        public string Text => this.text;
+        public string? Text => this.text;
 
         public void Update(string text)
         {
@@ -2812,9 +2810,9 @@ namespace N.Client
 
     public class C : N.Core.ViewModelBase
     {
-        private string text;
+        private string? text;
 
-        public string Text => this.text;
+        public string? Text => this.text;
 
         public void Update(string text)
         {
@@ -2839,7 +2837,7 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string p;
+        private string? p;
 
         public C()
         {
@@ -2848,7 +2846,7 @@ public C()
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string P => this.p;
+        public string? P => this.p;
 
         protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)
         {
@@ -2866,7 +2864,7 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string p;
+        private string? p;
 
         public C()
         {
@@ -2879,7 +2877,7 @@ public C()
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string P => this.p;
+        public string? P => this.p;
 
         protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)
         {
@@ -2903,7 +2901,7 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string p;
+        private string? p;
 
         public C()
         {
@@ -2915,7 +2913,7 @@ public C()
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string P => this.p;
+        public string? P => this.p;
 
         protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)
         {
@@ -2933,7 +2931,7 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string p;
+        private string? p;
 
         public C()
         {
@@ -2946,7 +2944,7 @@ public C()
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string P => this.p;
+        public string? P => this.p;
 
         protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)
         {
@@ -2969,7 +2967,7 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string p;
+        private string? p;
 
         public C()
         {
@@ -2978,7 +2976,7 @@ public C()
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string P => this.p;
+        public string? P => this.p;
 
         protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)
         {
@@ -2995,7 +2993,7 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string p;
+        private string? p;
 
         public C()
         {
@@ -3008,7 +3006,7 @@ public C()
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string P => this.p;
+        public string? P => this.p;
 
         protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)
         {
@@ -3031,7 +3029,7 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string p;
+        private string? p;
 
         public C()
         {
@@ -3043,7 +3041,7 @@ public C()
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string P => this.p;
+        public string? P => this.p;
 
         protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)
         {
@@ -3060,7 +3058,7 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string p;
+        private string? p;
 
         public C()
         {
@@ -3073,7 +3071,7 @@ public C()
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
-        public string P => this.p;
+        public string? P => this.p;
 
         protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)
         {
@@ -3096,14 +3094,14 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string p;
+        private int p = 1;
         private int getCount;
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
         public int GetCount => this.getCount;
 
-        public string P
+        public int P
         {
             get
             {
@@ -3127,14 +3125,14 @@ namespace N
 
     public class C : INotifyPropertyChanged
     {
-        private string p;
+        private int p = 1;
         private int getCount;
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
         public int GetCount => this.getCount;
 
-        public string P
+        public int P
         {
             get
             {

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public int P`
`52`	`52`	`RoslynAssert.Valid(Analyzer, code, settings: Settings);`
`53`	`53`	`}`
`54`	`54`
`55`		`- [TestCase("(string)null")]`
	`55`	`+ [TestCase("(string?)null")]`
`56`	`56`	`[TestCase("string.Empty")]`
`57`	`57`	`[TestCase(@"""P""")]`
`58`	`58`	`[TestCase(@"nameof(P)")]`
Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,6 @@ namespace N`
`98`	`98`
`99`	`99`	`public class C : INotifyPropertyChanged`
`100`	`100`	`{`
`101`		`- private static readonly int Two = 2;`
`102`	`101`	`private int _p;`
`103`	`102`
`104`	`103`	`public event PropertyChangedEventHandler? PropertyChanged;`
`@@ -125,7 +124,6 @@ namespace N`
`125`	`124`
`126`	`125`	`public class C : INotifyPropertyChanged`
`127`	`126`	`{`
`128`		`- private static readonly int Two = 2;`
`129`	`127`	`private int _p;`
`130`	`128`
`131`	`129`	`public event PropertyChangedEventHandler? PropertyChanged;`
`@@ -959,8 +957,8 @@ namespace N`
`959`	`957`
`960`	`958`	`public class C : INotifyPropertyChanged`
`961`	`959`	`{`
`962`		`- private string firstName;`
`963`		`- private string lastName;`
	`960`	`+ private string? firstName;`
	`961`	`+ private string? lastName;`
`964`	`962`
`965`	`963`	`public event PropertyChangedEventHandler? PropertyChanged;`
`966`	`964`
`@@ -974,7 +972,7 @@ public string FullName`
`974`	`972`	`}`
`975`	`973`	`}`
`976`	`974`
`977`		`- public string FirstName`
	`975`	`+ public string? FirstName`
`978`	`976`	`{`
`979`	`977`	`get`
`980`	`978`	`{`
`@@ -994,7 +992,7 @@ public string FirstName`
`994`	`992`	`}`
`995`	`993`	`}`
`996`	`994`
`997`		`- public string LastName`
	`995`	`+ public string? LastName`
`998`	`996`	`{`
`999`	`997`	`get`
`1000`	`998`	`{`
`@@ -1032,8 +1030,8 @@ namespace N`
`1032`	`1030`
`1033`	`1031`	`public class C : INotifyPropertyChanged`
`1034`	`1032`	`{`
`1035`		`- private string firstName;`
`1036`		`- private string lastName;`
	`1033`	`+ private string? firstName;`
	`1034`	`+ private string? lastName;`
`1037`	`1035`
`1038`	`1036`	`public event PropertyChangedEventHandler? PropertyChanged;`
`1039`	`1037`
`@@ -1047,7 +1045,7 @@ public string FullName`
`1047`	`1045`	`}`
`1048`	`1046`	`}`
`1049`	`1047`
`1050`		`- public string FirstName`
	`1048`	`+ public string? FirstName`
`1051`	`1049`	`{`
`1052`	`1050`	`get`
`1053`	`1051`	`{`
`@@ -1068,7 +1066,7 @@ public string FirstName`
`1068`	`1066`	`}`
`1069`	`1067`	`}`
`1070`	`1068`
`1071`		`- public string LastName`
	`1069`	`+ public string? LastName`
`1072`	`1070`	`{`
`1073`	`1071`	`get`
`1074`	`1072`	`{`
`@@ -1785,13 +1783,13 @@ namespace N`
`1785`	`1783`
`1786`	`1784`	`public class C : INotifyPropertyChanged`
`1787`	`1785`	`{`
`1788`		`- private string p;`
	`1786`	`+ private string? p;`
`1789`	`1787`
`1790`	`1788`	`public event PropertyChangedEventHandler? PropertyChanged;`
`1791`	`1789`
`1792`		`- public string CapsName => this.p.ToUpper();`
	`1790`	`+ public string? CapsName => this.p?.ToUpper();`
`1793`	`1791`
`1794`		`- public string P`
	`1792`	`+ public string? P`
`1795`	`1793`	`{`
`1796`	`1794`	`get`
`1797`	`1795`	`{`
`@@ -1825,13 +1823,13 @@ namespace N`
`1825`	`1823`
`1826`	`1824`	`public class C : INotifyPropertyChanged`
`1827`	`1825`	`{`
`1828`		`- private string p;`
	`1826`	`+ private string? p;`
`1829`	`1827`
`1830`	`1828`	`public event PropertyChangedEventHandler? PropertyChanged;`
`1831`	`1829`
`1832`		`- public string CapsName => this.p.ToUpper();`
	`1830`	`+ public string? CapsName => this.p?.ToUpper();`
`1833`	`1831`
`1834`		`- public string P`
	`1832`	`+ public string? P`
`1835`	`1833`	`{`
`1836`	`1834`	`get`
`1837`	`1835`	`{`
`@@ -2793,9 +2791,9 @@ namespace N.Client`
`2793`	`2791`
`2794`	`2792`	`public class C : N.Core.ViewModelBase`
`2795`	`2793`	`{`
`2796`		`- private string text;`
	`2794`	`+ private string? text;`
`2797`	`2795`
`2798`		`- public string Text => this.text;`
	`2796`	`+ public string? Text => this.text;`
`2799`	`2797`
`2800`	`2798`	`public void Update(string text)`
`2801`	`2799`	`{`
`@@ -2812,9 +2810,9 @@ namespace N.Client`
`2812`	`2810`
`2813`	`2811`	`public class C : N.Core.ViewModelBase`
`2814`	`2812`	`{`
`2815`		`- private string text;`
	`2813`	`+ private string? text;`
`2816`	`2814`
`2817`		`- public string Text => this.text;`
	`2815`	`+ public string? Text => this.text;`
`2818`	`2816`
`2819`	`2817`	`public void Update(string text)`
`2820`	`2818`	`{`
`@@ -2839,7 +2837,7 @@ namespace N`
`2839`	`2837`
`2840`	`2838`	`public class C : INotifyPropertyChanged`
`2841`	`2839`	`{`
`2842`		`- private string p;`
	`2840`	`+ private string? p;`
`2843`	`2841`
`2844`	`2842`	`public C()`
`2845`	`2843`	`{`
`@@ -2848,7 +2846,7 @@ public C()`
`2848`	`2846`
`2849`	`2847`	`public event PropertyChangedEventHandler? PropertyChanged;`
`2850`	`2848`
`2851`		`- public string P => this.p;`
	`2849`	`+ public string? P => this.p;`
`2852`	`2850`
`2853`	`2851`	`protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)`
`2854`	`2852`	`{`
`@@ -2866,7 +2864,7 @@ namespace N`
`2866`	`2864`
`2867`	`2865`	`public class C : INotifyPropertyChanged`
`2868`	`2866`	`{`
`2869`		`- private string p;`
	`2867`	`+ private string? p;`
`2870`	`2868`
`2871`	`2869`	`public C()`
`2872`	`2870`	`{`
`@@ -2879,7 +2877,7 @@ public C()`
`2879`	`2877`
`2880`	`2878`	`public event PropertyChangedEventHandler? PropertyChanged;`
`2881`	`2879`
`2882`		`- public string P => this.p;`
	`2880`	`+ public string? P => this.p;`
`2883`	`2881`
`2884`	`2882`	`protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)`
`2885`	`2883`	`{`
`@@ -2903,7 +2901,7 @@ namespace N`
`2903`	`2901`
`2904`	`2902`	`public class C : INotifyPropertyChanged`
`2905`	`2903`	`{`
`2906`		`- private string p;`
	`2904`	`+ private string? p;`
`2907`	`2905`
`2908`	`2906`	`public C()`
`2909`	`2907`	`{`
`@@ -2915,7 +2913,7 @@ public C()`
`2915`	`2913`
`2916`	`2914`	`public event PropertyChangedEventHandler? PropertyChanged;`
`2917`	`2915`
`2918`		`- public string P => this.p;`
	`2916`	`+ public string? P => this.p;`
`2919`	`2917`
`2920`	`2918`	`protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)`
`2921`	`2919`	`{`
`@@ -2933,7 +2931,7 @@ namespace N`
`2933`	`2931`
`2934`	`2932`	`public class C : INotifyPropertyChanged`
`2935`	`2933`	`{`
`2936`		`- private string p;`
	`2934`	`+ private string? p;`
`2937`	`2935`
`2938`	`2936`	`public C()`
`2939`	`2937`	`{`
`@@ -2946,7 +2944,7 @@ public C()`
`2946`	`2944`
`2947`	`2945`	`public event PropertyChangedEventHandler? PropertyChanged;`
`2948`	`2946`
`2949`		`- public string P => this.p;`
	`2947`	`+ public string? P => this.p;`
`2950`	`2948`
`2951`	`2949`	`protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)`
`2952`	`2950`	`{`
`@@ -2969,7 +2967,7 @@ namespace N`
`2969`	`2967`
`2970`	`2968`	`public class C : INotifyPropertyChanged`
`2971`	`2969`	`{`
`2972`		`- private string p;`
	`2970`	`+ private string? p;`
`2973`	`2971`
`2974`	`2972`	`public C()`
`2975`	`2973`	`{`
`@@ -2978,7 +2976,7 @@ public C()`
`2978`	`2976`
`2979`	`2977`	`public event PropertyChangedEventHandler? PropertyChanged;`
`2980`	`2978`
`2981`		`- public string P => this.p;`
	`2979`	`+ public string? P => this.p;`
`2982`	`2980`
`2983`	`2981`	`protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)`
`2984`	`2982`	`{`
`@@ -2995,7 +2993,7 @@ namespace N`
`2995`	`2993`
`2996`	`2994`	`public class C : INotifyPropertyChanged`
`2997`	`2995`	`{`
`2998`		`- private string p;`
	`2996`	`+ private string? p;`
`2999`	`2997`
`3000`	`2998`	`public C()`
`3001`	`2999`	`{`
`@@ -3008,7 +3006,7 @@ public C()`
`3008`	`3006`
`3009`	`3007`	`public event PropertyChangedEventHandler? PropertyChanged;`
`3010`	`3008`
`3011`		`- public string P => this.p;`
	`3009`	`+ public string? P => this.p;`
`3012`	`3010`
`3013`	`3011`	`protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)`
`3014`	`3012`	`{`
`@@ -3031,7 +3029,7 @@ namespace N`
`3031`	`3029`
`3032`	`3030`	`public class C : INotifyPropertyChanged`
`3033`	`3031`	`{`
`3034`		`- private string p;`
	`3032`	`+ private string? p;`
`3035`	`3033`
`3036`	`3034`	`public C()`
`3037`	`3035`	`{`
`@@ -3043,7 +3041,7 @@ public C()`
`3043`	`3041`
`3044`	`3042`	`public event PropertyChangedEventHandler? PropertyChanged;`
`3045`	`3043`
`3046`		`- public string P => this.p;`
	`3044`	`+ public string? P => this.p;`
`3047`	`3045`
`3048`	`3046`	`protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)`
`3049`	`3047`	`{`
`@@ -3060,7 +3058,7 @@ namespace N`
`3060`	`3058`
`3061`	`3059`	`public class C : INotifyPropertyChanged`
`3062`	`3060`	`{`
`3063`		`- private string p;`
	`3061`	`+ private string? p;`
`3064`	`3062`
`3065`	`3063`	`public C()`
`3066`	`3064`	`{`
`@@ -3073,7 +3071,7 @@ public C()`
`3073`	`3071`
`3074`	`3072`	`public event PropertyChangedEventHandler? PropertyChanged;`
`3075`	`3073`
`3076`		`- public string P => this.p;`
	`3074`	`+ public string? P => this.p;`
`3077`	`3075`
`3078`	`3076`	`protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)`
`3079`	`3077`	`{`
`@@ -3096,14 +3094,14 @@ namespace N`
`3096`	`3094`
`3097`	`3095`	`public class C : INotifyPropertyChanged`
`3098`	`3096`	`{`
`3099`		`- private string p;`
	`3097`	`+ private int p = 1;`
`3100`	`3098`	`private int getCount;`
`3101`	`3099`
`3102`	`3100`	`public event PropertyChangedEventHandler? PropertyChanged;`
`3103`	`3101`
`3104`	`3102`	`public int GetCount => this.getCount;`
`3105`	`3103`
`3106`		`- public string P`
	`3104`	`+ public int P`
`3107`	`3105`	`{`
`3108`	`3106`	`get`
`3109`	`3107`	`{`
`@@ -3127,14 +3125,14 @@ namespace N`
`3127`	`3125`
`3128`	`3126`	`public class C : INotifyPropertyChanged`
`3129`	`3127`	`{`
`3130`		`- private string p;`
	`3128`	`+ private int p = 1;`
`3131`	`3129`	`private int getCount;`
`3132`	`3130`
`3133`	`3131`	`public event PropertyChangedEventHandler? PropertyChanged;`
`3134`	`3132`
`3135`	`3133`	`public int GetCount => this.getCount;`
`3136`	`3134`
`3137`		`- public string P`
	`3135`	`+ public int P`
`3138`	`3136`	`{`
`3139`	`3137`	`get`
`3140`	`3138`	`{`