Modify original code to work in standalone analyzer context

Author: sharwell

PublicApiAnalyzer/Directory.Build.props

@@ -18,7 +18,7 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <LangVersion>6</LangVersion>
+    <LangVersion>7.1</LangVersion>
     <Features>strict</Features>
   </PropertyGroup>
 

PublicApiAnalyzer/PublicApiAnalyzer.CodeFixes/ApiDesign/DeclarePublicAPIFix.cs

@@ -127,14 +127,14 @@ protected virtual Solution CreateSolution(ProjectId projectId, string language)
             if (publicApi != null)
             {
                 var documentId = DocumentId.CreateNewId(projectId);
-                solution = solution.AddAdditionalDocument(documentId, DeclarePublicAPIAnalyzer.UnshippedFileName, publicApi);
+                solution = solution.AddAdditionalDocument(documentId, DeclarePublicAPIAnalyzer.UnshippedFileName, publicApi, filePath: this.GetUnshippedPublicApiFilePath());
             }
 
             publicApi = this.GetShippedPublicApi();
             if (publicApi != null)
             {
                 var documentId = DocumentId.CreateNewId(projectId);
-                solution = solution.AddAdditionalDocument(documentId, DeclarePublicAPIAnalyzer.ShippedFileName, publicApi);
+                solution = solution.AddAdditionalDocument(documentId, DeclarePublicAPIAnalyzer.ShippedFileName, publicApi, filePath: this.GetShippedPublicApiFilePath());
             }
 
             ParseOptions parseOptions = solution.GetProject(projectId).ParseOptions;
@@ -159,6 +159,11 @@ protected virtual string GetUnshippedPublicApi()
             return null;
         }
 
+        protected virtual string GetUnshippedPublicApiFilePath()
+        {
+            return null;
+        }
+
         /// <summary>
         /// Gets the content of the settings file to use.
         /// </summary>
@@ -168,6 +173,11 @@ protected virtual string GetShippedPublicApi()
             return null;
         }
 
+        protected virtual string GetShippedPublicApiFilePath()
+        {
+            return null;
+        }
+
         protected DiagnosticResult CSharpDiagnostic(string diagnosticId = null)
         {
             var analyzers = this.GetCSharpDiagnosticAnalyzers();

PublicApiAnalyzer/PublicApiAnalyzer.Test/ApiDesign/DeclarePublicAPIAnalyzerTests.cs

@@ -0,0 +1,28 @@
+// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
+// Licensed under the Apache License, Version 2.0. See LICENSE in the project root for license information.
+
+namespace PublicApiAnalyzer.Helpers
+{
+    using System.Collections.Generic;
+    using System.Linq;
+    using Microsoft.CodeAnalysis;
+
+    internal static class IMethodSymbolExtensions
+    {
+        public static bool HasOptionalParameters(this IMethodSymbol methodSymbol)
+        {
+            return methodSymbol.Parameters.Any(p => p.IsOptional);
+        }
+
+        public static IEnumerable<IMethodSymbol> GetOverloads(this IMethodSymbol method)
+        {
+            foreach (var member in method?.ContainingType?.GetMembers(method.Name).OfType<IMethodSymbol>())
+            {
+                if (!member.Equals(method))
+                {
+                    yield return member;
+                }
+            }
+        }
+    }
+}

PublicApiAnalyzer/PublicApiAnalyzer.Test/Helpers/DiagnosticVerifier.Helper.cs

@@ -0,0 +1,29 @@
+// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
+// Licensed under the Apache License, Version 2.0. See LICENSE in the project root for license information.
+
+namespace PublicApiAnalyzer.Helpers
+{
+    using System.Collections.Immutable;
+    using Microsoft.CodeAnalysis;
+
+    internal static class ISymbolExtensions
+    {
+        public static bool IsDefaultConstructor(this ISymbol symbol)
+        {
+            return symbol.IsConstructor() && symbol.GetParameters().Length == 0;
+        }
+
+        public static bool IsConstructor(this ISymbol symbol)
+        {
+            return (symbol as IMethodSymbol)?.MethodKind == MethodKind.Constructor;
+        }
+
+        public static ImmutableArray<IParameterSymbol> GetParameters(this ISymbol symbol)
+        {
+            return symbol.TypeSwitch(
+                (IMethodSymbol m) => m.Parameters,
+                (IPropertySymbol p) => p.Parameters,
+                _ => ImmutableArray.Create<IParameterSymbol>());
+        }
+    }
+}

PublicApiAnalyzer/PublicApiAnalyzer/ApiDesign/DeclarePublicAPIAnalyzer.Impl.cs

@@ -0,0 +1,32 @@
+// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
+// Licensed under the Apache License, Version 2.0. See LICENSE in the project root for license information.
+
+namespace PublicApiAnalyzer.Helpers
+{
+    using System;
+
+    internal static class ObjectExtensions
+    {
+        public static TResult TypeSwitch<TBaseType, TDerivedType1, TDerivedType2, TResult>(this TBaseType obj, Func<TDerivedType1, TResult> matchFunc1, Func<TDerivedType2, TResult> matchFunc2, Func<TBaseType, TResult> defaultFunc = null)
+            where TDerivedType1 : TBaseType
+            where TDerivedType2 : TBaseType
+        {
+            if (obj is TDerivedType1 derived1)
+            {
+                return matchFunc1(derived1);
+            }
+            else if (obj is TDerivedType2 derived2)
+            {
+                return matchFunc2(derived2);
+            }
+            else if (defaultFunc != null)
+            {
+                return defaultFunc(obj);
+            }
+            else
+            {
+                return default;
+            }
+        }
+    }
+}

PublicApiAnalyzer/PublicApiAnalyzer/ApiDesign/DeclarePublicAPIAnalyzer.cs

@@ -10,5 +10,7 @@ internal static class RoslynDiagnosticIds
         public const string ExposedNoninstantiableTypeRuleId = "RS0022";
         public const string PublicApiFilesInvalid = "RS0024";
         public const string DuplicatedSymbolInPublicApiFiles = "RS0025";
+        public const string AvoidMultipleOverloadsWithOptionalParameters = "RS0026";
+        public const string OverloadWithOptionalParametersShouldHaveMostParameters = "RS0027";
     }
 }