Added code fix tests

Author: sharwell

PublicApiAnalyzer/PublicApiAnalyzer.Test/ApiDesign/DeclarePublicAPIAnalyzerTests.cs

@@ -4,10 +4,13 @@
 namespace PublicApiAnalyzer.Test.ApiDesign
 {
     using System.Collections.Generic;
+    using System.Linq;
     using System.Threading;
     using System.Threading.Tasks;
+    using Microsoft.CodeAnalysis.CodeActions;
     using Microsoft.CodeAnalysis.CodeFixes;
     using Microsoft.CodeAnalysis.Diagnostics;
+    using Microsoft.CodeAnalysis.Text;
     using PublicApiAnalyzer.ApiDesign;
     using TestHelper;
     using Xunit;
@@ -31,6 +34,11 @@ public class C
 
             var expected = this.CSharpDiagnostic(DeclarePublicAPIAnalyzer.DeclareNewApiRule).WithArguments("C").WithLocation(2, 14);
             await this.VerifyCSharpDiagnosticAsync(source, expected, CancellationToken.None).ConfigureAwait(false);
+
+            string fixedApi = "C";
+            var updatedApi = await this.GetUpdatedApiAsync(source, 0, CancellationToken.None).ConfigureAwait(false);
+
+            Assert.Equal(fixedApi, updatedApi.ToString());
         }
 
         [Fact]
@@ -67,6 +75,26 @@ public void Method() { }
             };
 
             await this.VerifyCSharpDiagnosticAsync(source, expected, CancellationToken.None).ConfigureAwait(false);
+
+            string fixedApi = "C";
+            var updatedApi = await this.GetUpdatedApiAsync(source, 0, CancellationToken.None).ConfigureAwait(false);
+            Assert.Equal(fixedApi, updatedApi.ToString());
+
+            fixedApi = "C.Field -> int";
+            updatedApi = await this.GetUpdatedApiAsync(source, 1, CancellationToken.None).ConfigureAwait(false);
+            Assert.Equal(fixedApi, updatedApi.ToString());
+
+            fixedApi = "C.Property.get -> int";
+            updatedApi = await this.GetUpdatedApiAsync(source, 2, CancellationToken.None).ConfigureAwait(false);
+            Assert.Equal(fixedApi, updatedApi.ToString());
+
+            fixedApi = "C.Property.set -> void";
+            updatedApi = await this.GetUpdatedApiAsync(source, 3, CancellationToken.None).ConfigureAwait(false);
+            Assert.Equal(fixedApi, updatedApi.ToString());
+
+            fixedApi = "C.Method() -> void";
+            updatedApi = await this.GetUpdatedApiAsync(source, 4, CancellationToken.None).ConfigureAwait(false);
+            Assert.Equal(fixedApi, updatedApi.ToString());
         }
 
         [Fact]
@@ -275,5 +303,26 @@ protected override string GetUnshippedPublicApi()
         {
             return this.unshippedText;
         }
+
+        private async Task<SourceText> GetUpdatedApiAsync(string source, int diagnosticIndex, CancellationToken cancellationToken)
+        {
+            var fixes = await this.GetOfferedCSharpFixesAsync(source, diagnosticIndex, cancellationToken).ConfigureAwait(false);
+            Assert.Equal(1, fixes.Item2.Length);
+
+            var operations = await fixes.Item2[0].GetOperationsAsync(CancellationToken.None).ConfigureAwait(false);
+            Assert.Equal(1, operations.Length);
+            ApplyChangesOperation operation = operations[0] as ApplyChangesOperation;
+            Assert.NotNull(operation);
+
+            var oldSolution = fixes.Item1;
+            var newSolution = operation.ChangedSolution;
+            var solutionChanges = newSolution.GetChanges(oldSolution);
+            var projectChanges = solutionChanges.GetProjectChanges().Single();
+            var changedDocumentId = projectChanges.GetChangedAdditionalDocuments().Single();
+            var newDocument = projectChanges.NewProject.GetAdditionalDocument(changedDocumentId);
+            var newText = await newDocument.GetTextAsync(CancellationToken.None).ConfigureAwait(false);
+
+            return newText;
+        }
     }
 }

PublicApiAnalyzer/PublicApiAnalyzer.Test/Verifiers/CodeFixVerifier.cs

@@ -150,7 +150,7 @@ public bool UseTabs
         /// <param name="diagnosticIndex">Index determining which diagnostic to use for determining the offered code fixes. Uses the first diagnostic if null.</param>
         /// <param name="cancellationToken">The <see cref="CancellationToken"/> that the task will observe.</param>
         /// <returns>The collection of offered code actions. This collection may be empty.</returns>
-        protected async Task<ImmutableArray<CodeAction>> GetOfferedCSharpFixesAsync(string source, int? diagnosticIndex = null, CancellationToken cancellationToken = default(CancellationToken))
+        protected async Task<Tuple<Solution, ImmutableArray<CodeAction>>> GetOfferedCSharpFixesAsync(string source, int? diagnosticIndex = null, CancellationToken cancellationToken = default(CancellationToken))
         {
             return await this.GetOfferedFixesInternalAsync(LanguageNames.CSharp, source, diagnosticIndex, this.GetCSharpDiagnosticAnalyzers().ToImmutableArray(), this.GetCSharpCodeFixProvider(), cancellationToken).ConfigureAwait(false);
         }
@@ -401,7 +401,7 @@ private async Task VerifyFixInternalAsync(
             Assert.Equal(newSource, actual);
         }
 
-        private async Task<ImmutableArray<CodeAction>> GetOfferedFixesInternalAsync(string language, string source, int? diagnosticIndex, ImmutableArray<DiagnosticAnalyzer> analyzers, CodeFixProvider codeFixProvider, CancellationToken cancellationToken)
+        private async Task<Tuple<Solution, ImmutableArray<CodeAction>>> GetOfferedFixesInternalAsync(string language, string source, int? diagnosticIndex, ImmutableArray<DiagnosticAnalyzer> analyzers, CodeFixProvider codeFixProvider, CancellationToken cancellationToken)
         {
             var document = this.CreateDocument(source, language);
             var analyzerDiagnostics = await GetSortedDiagnosticsFromDocumentsAsync(analyzers, new[] { document }, cancellationToken).ConfigureAwait(false);
@@ -419,7 +419,7 @@ private async Task<ImmutableArray<CodeAction>> GetOfferedFixesInternalAsync(stri
                 await codeFixProvider.RegisterCodeFixesAsync(context).ConfigureAwait(false);
             }
 
-            return actions.ToImmutableArray();
+            return Tuple.Create(document.Project.Solution, actions.ToImmutableArray());
         }
     }
 }