Skip to content

Commit 21bf033

Browse files
committed
Simplify
1 parent 77fd042 commit 21bf033

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

ReflectionAnalyzers/Helpers/Reflection/GetProperty.cs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
namespace ReflectionAnalyzers;
22

33
using System.Threading;
4+
45
using Gu.Roslyn.AnalyzerExtensions;
6+
57
using Microsoft.CodeAnalysis;
68
using Microsoft.CodeAnalysis.CSharp;
79
using Microsoft.CodeAnalysis.CSharp.Syntax;
@@ -60,19 +62,18 @@ when semanticModel.TryGetSymbol(identifierName, cancellationToken, out ILocalSym
6062
if (ReflectedMember.TryGetType(candidate, semanticModel, cancellationToken, out var type, out var typeSource) &&
6163
Name.TryCreate(candidate, target, semanticModel, cancellationToken, out var name) &&
6264
Flags.TryCreate(candidate, target, semanticModel, cancellationToken, out var flags) &&
63-
Types.TryCreate(candidate, target, semanticModel, cancellationToken, out var types))
65+
Types.TryCreate(candidate, target, semanticModel, cancellationToken, out var types) &&
66+
ReflectedMember.TryCreate(target, candidate, type, typeSource, name, flags.Effective, types, semanticModel.Compilation, out var member))
6467
{
65-
return ReflectedMember.TryCreate(target, candidate, type, typeSource, name, flags.Effective, types, semanticModel.Compilation, out var member)
66-
? new GetProperty(candidate, target, member, name, flags, types)
67-
: null;
68+
return new GetProperty(candidate, target, member, name, flags, types);
6869
}
6970

7071
if (Flags.TryCreate(candidate, target, semanticModel, cancellationToken, out flags) &&
7172
flags.AreInSufficient)
7273
{
7374
_ = Name.TryCreate(candidate, target, semanticModel, cancellationToken, out name);
7475
_ = Types.TryCreate(candidate, target, semanticModel, cancellationToken, out types);
75-
var member = new ReflectedMember(type, typeSource, null, target, candidate, FilterMatch.InSufficientFlags);
76+
member = new ReflectedMember(type, typeSource, null, target, candidate, FilterMatch.InSufficientFlags);
7677
return new GetProperty(candidate, target, member, name, flags, types);
7778
}
7879
}

0 commit comments

Comments
 (0)