Rename TryGetType

Author: JohanLarsson

ReflectionAnalyzers.Tests/Helpers/GetXTests.cs

@@ -37,7 +37,7 @@ public Foo(Foo foo)
             var semanticModel = compilation.GetSemanticModel(syntaxTree);
             var node = syntaxTree.FindInvocation(call);
             var context = new SyntaxNodeAnalysisContext(null, null, semanticModel, null, null, null, CancellationToken.None);
-            Assert.AreEqual(true, GetX.TryGetTargetType(node, context, out var type, out var instance));
+            Assert.AreEqual(true, GetX.TryGetType(node, context, out var type, out var instance));
             Assert.AreEqual(expected, type.MetadataName);
             if (expectedInstance == null)
             {
@@ -78,7 +78,7 @@ public Foo(Foo foo)
             var semanticModel = compilation.GetSemanticModel(syntaxTree);
             var node = syntaxTree.FindInvocation("GetMethod");
             var context = new SyntaxNodeAnalysisContext(null, null, semanticModel, null, null, null, CancellationToken.None);
-            Assert.AreEqual(true, GetX.TryGetTargetType(node, context, out var type, out var instance));
+            Assert.AreEqual(true, GetX.TryGetType(node, context, out var type, out var instance));
             Assert.AreEqual(expected, type.MetadataName);
             if (expectedInstance == null)
             {
@@ -113,7 +113,7 @@ public Foo()
             var semanticModel = compilation.GetSemanticModel(syntaxTree);
             var node = syntaxTree.FindInvocation("GetMethod");
             var context = new SyntaxNodeAnalysisContext(null, null, semanticModel, null, null, null, CancellationToken.None);
-            Assert.AreEqual(false, GetX.TryGetTargetType(node, context, out _, out _));
+            Assert.AreEqual(false, GetX.TryGetType(node, context, out _, out _));
         }
 
         [Test]

ReflectionAnalyzers/Helpers/GetX.cs

@@ -30,7 +30,7 @@ internal static class GetX
             types = null;
             if (invocation.ArgumentList != null &&
                 invocation.TryGetTarget(KnownSymbol.Type.GetConstructor, context.SemanticModel, context.CancellationToken, out var getX) &&
-                TryGetTargetType(invocation, context, out targetType, out _) &&
+                TryGetType(invocation, context, out targetType, out _) &&
                 IsKnownSignature(invocation, getX) &&
                 TryGetFlagsOrDefault(invocation, getX, context, out flagsArg, out effectiveFlags) &&
                 TryGetTypesOrDefault(invocation, getX, context, out typesArg, out types))
@@ -72,7 +72,7 @@ internal static class GetX
             types = null;
             if (invocation.ArgumentList != null &&
                 invocation.TryGetTarget(KnownSymbol.Type.GetMethod, context.SemanticModel, context.CancellationToken, out var getX) &&
-                TryGetTargetType(invocation, context, out targetType, out _) &&
+                TryGetType(invocation, context, out targetType, out _) &&
                 IsKnownSignature(invocation, getX) &&
                 TryGetName(invocation, getX, context, out nameArg, out targetName) &&
                 TryGetFlagsOrDefault(invocation, getX, context, out flagsArg, out effectiveFlags) &&
@@ -99,7 +99,7 @@ internal static class GetX
             types = null;
             if (invocation.ArgumentList != null &&
                 invocation.TryGetTarget(KnownSymbol.Type.GetMember, context.SemanticModel, context.CancellationToken, out var getX) &&
-                TryGetTargetType(invocation, context, out targetType, out _) &&
+                TryGetType(invocation, context, out targetType, out _) &&
                 IsKnownSignature(invocation, getX) &&
                 TryGetName(invocation, getX, context, out nameArg, out targetName) &&
                 TryGetFlagsOrDefault(invocation, getX, context, out flagsArg, out effectiveFlags) &&
@@ -135,12 +135,12 @@ internal static class GetX
         /// <param name="result">The type.</param>
         /// <param name="instance">The instance the type was called GetType on. Can be null</param>
         /// <returns>True if the type could be determined.</returns>
-        internal static bool TryGetTargetType(InvocationExpressionSyntax getX, SyntaxNodeAnalysisContext context, out ITypeSymbol result, out Optional<IdentifierNameSyntax> instance)
+        internal static bool TryGetType(InvocationExpressionSyntax getX, SyntaxNodeAnalysisContext context, out ITypeSymbol result, out Optional<IdentifierNameSyntax> instance)
         {
             result = null;
             instance = default(Optional<IdentifierNameSyntax>);
             return getX.Expression is MemberAccessExpressionSyntax memberAccess &&
-                   TryGetTargetType(memberAccess.Expression, context, null, out result, out instance);
+                   TryGetType(memberAccess.Expression, context, null, out result, out instance);
         }
 
         internal static GetXResult TryGetMember(IMethodSymbol getX, ITypeSymbol targetType, string targetMetadataName, BindingFlags flags, IReadOnlyList<ITypeSymbol> types, SyntaxNodeAnalysisContext context, out ISymbol member)
@@ -419,7 +419,7 @@ bool IsKnownArgument(IParameterSymbol parameter)
             effectiveFlags = 0;
             if (invocation.ArgumentList != null &&
                 invocation.TryGetTarget(getXMethod, context.SemanticModel, context.CancellationToken, out var getX) &&
-                TryGetTargetType(invocation, context, out targetType, out _) &&
+                TryGetType(invocation, context, out targetType, out _) &&
                 TryGetName(invocation, getX, context, out nameArg, out targetName) &&
                 TryGetFlagsOrDefault(invocation, getX, context, out flagsArg, out effectiveFlags))
             {
@@ -626,7 +626,7 @@ private static bool HasVisibleMembers(ITypeSymbol type, BindingFlags effectiveFl
             return true;
         }
 
-        private static bool TryGetTargetType(ExpressionSyntax expression, SyntaxNodeAnalysisContext context, PooledSet<ExpressionSyntax> visited, out ITypeSymbol result, out Optional<IdentifierNameSyntax> instance)
+        private static bool TryGetType(ExpressionSyntax expression, SyntaxNodeAnalysisContext context, PooledSet<ExpressionSyntax> visited, out ITypeSymbol result, out Optional<IdentifierNameSyntax> instance)
         {
             instance = default(Optional<IdentifierNameSyntax>);
             result = null;
@@ -637,7 +637,7 @@ private static bool TryGetTargetType(ExpressionSyntax expression, SyntaxNodeAnal
                     {
                         return AssignedValueWalker.TryGetSingle(local, context.SemanticModel, context.CancellationToken, out var assignedValue) &&
                                visited.Add(assignedValue) &&
-                               TryGetTargetType(assignedValue, context, visited, out result, out instance);
+                               TryGetType(assignedValue, context, visited, out result, out instance);
                     }
 
                 case TypeOfExpressionSyntax typeOf:

ReflectionAnalyzers/NodeAnalzers/NameofAnalyzer.cs

@@ -123,7 +123,7 @@ private static bool TryGetTarget(InvocationExpressionSyntax invocation, IMethodS
         {
             instance = default(Optional<IdentifierNameSyntax>);
             target = default(Optional<ISymbol>);
-            if (GetX.TryGetTargetType(invocation, context, out var targetType, out instance))
+            if (GetX.TryGetType(invocation, context, out var targetType, out instance))
             {
                 _ = GetX.TryGetMember(getX, targetType, name, BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Static | BindingFlags.Instance | BindingFlags.FlattenHierarchy, GetX.AnyTypes, context, out var targetSymbol);