Use GetConstructor.Match

Author: JohanLarsson

ReflectionAnalyzers/Helpers/Reflection/GetX.cs

@@ -14,20 +14,6 @@
     /// </summary>
     internal static class GetX
     {
-        internal static bool TryGetConstructorInfo(MemberAccessExpressionSyntax memberAccess, SemanticModel semanticModel, CancellationToken cancellationToken, [NotNullWhen(true)] out IMethodSymbol? constructor)
-        {
-            if (TryFindInvocation(memberAccess, KnownSymbol.Type.GetConstructor, semanticModel, cancellationToken, out var invocation) &&
-                TryMatchGetConstructor(invocation, semanticModel, cancellationToken, out var member, out _, out _) &&
-                member is { Match: FilterMatch.Single, Symbol: IMethodSymbol match })
-            {
-                constructor = match;
-                return true;
-            }
-
-            constructor = null;
-            return false;
-        }
-
         internal static bool TryGetNestedType(ExpressionSyntax expression, SemanticModel semanticModel, CancellationToken cancellationToken, [NotNullWhen(true)] out INamedTypeSymbol? type)
         {
             if (expression is MemberAccessExpressionSyntax memberAccess &&

ReflectionAnalyzers/NodeAnalzers/GetXAnalyzer.cs

@@ -265,8 +265,17 @@ private static bool TryGetX(SyntaxNodeAnalysisContext context, out ReflectedMemb
                     return true;
                 }
 
-                return GetX.TryMatchGetConstructor(candidate, context.SemanticModel, context.CancellationToken, out member, out flags, out types) ||
-                       GetX.TryMatchGetEvent(candidate, context.SemanticModel, context.CancellationToken, out member, out name, out flags) ||
+                if (GetConstructor.Match(candidate, context.SemanticModel, context.CancellationToken) is { } getCtor)
+                {
+                    member = getCtor.Member;
+                    name = default;
+                    flags = getCtor.Flags;
+                    types = getCtor.Types;
+                    return true;
+                }
+
+                types = default;
+                return GetX.TryMatchGetEvent(candidate, context.SemanticModel, context.CancellationToken, out member, out name, out flags) ||
                        GetX.TryMatchGetField(candidate, context.SemanticModel, context.CancellationToken, out member, out name, out flags) ||
                        GetX.TryMatchGetNestedType(candidate, context.SemanticModel, context.CancellationToken, out member, out name, out flags) ||
                        GetX.TryMatchGetProperty(candidate, context.SemanticModel, context.CancellationToken, out member, out name, out flags, out types);