Use GetMethod.Match

Author: JohanLarsson

ReflectionAnalyzers/Helpers/Reflection/GetMethod.cs

@@ -55,19 +55,24 @@ when semanticModel.TryGetSymbol(identifierName, cancellationToken, out ILocalSym
     /// </summary>
     internal static GetMethod? Match(InvocationExpressionSyntax candidate, SemanticModel semanticModel, CancellationToken cancellationToken)
     {
-        if (candidate.TryGetTarget(KnownSymbol.Type.GetMethod, semanticModel, cancellationToken, out var target) &&
-            Flags.TryCreate(candidate, target, semanticModel, cancellationToken, out var flags) &&
-            ReflectedMember.TryGetType(candidate, semanticModel, cancellationToken, out var type, out var typeSource))
+        if (candidate.TryGetTarget(KnownSymbol.Type.GetMethod, semanticModel, cancellationToken, out var target))
         {
-            _ = Name.TryCreate(candidate, target, semanticModel, cancellationToken, out var name);
-            _ = Types.TryCreate(candidate, target, semanticModel, cancellationToken, out var types);
-            if (flags.AreInSufficient)
+            if (ReflectedMember.TryGetType(candidate, semanticModel, cancellationToken, out var type, out var typeSource) &&
+                Name.TryCreate(candidate, target, semanticModel, cancellationToken, out var name) &&
+                Flags.TryCreate(candidate, target, semanticModel, cancellationToken, out var flags) &&
+                Types.TryCreate(candidate, target, semanticModel, cancellationToken, out var types))
             {
-                return new GetMethod(candidate, target, new ReflectedMember(type, typeSource, null, target, candidate, FilterMatch.InSufficientFlags), name, flags, types);
+                return ReflectedMember.TryCreate(target, candidate, type, typeSource, name, flags.Effective, types, semanticModel.Compilation, out var member)
+                    ? new GetMethod(candidate, target, member, name, flags, types)
+                    : null;
             }
 
-            if (ReflectedMember.TryCreate(target, candidate, type, typeSource, name, flags.Effective, types, semanticModel.Compilation, out var member))
+            if (Flags.TryCreate(candidate, target, semanticModel, cancellationToken, out flags) &&
+                flags.AreInSufficient)
             {
+                _ = Name.TryCreate(candidate, target, semanticModel, cancellationToken, out name);
+                _ = Types.TryCreate(candidate, target, semanticModel, cancellationToken, out types);
+                var member = new ReflectedMember(type, typeSource, null, target, candidate, FilterMatch.InSufficientFlags);
                 return new GetMethod(candidate, target, member, name, flags, types);
             }
         }

ReflectionAnalyzers/Helpers/Reflection/GetX.cs

@@ -89,39 +89,6 @@ internal static bool TryMatchGetField(InvocationExpressionSyntax invocation, Sem
             return TryMatchGetX(invocation, KnownSymbol.Type.GetField, semanticModel, cancellationToken, out member, out name, out flags);
         }
 
-        /// <summary>
-        /// Check if <paramref name="invocation"/> is a call to Type.GetMethod.
-        /// </summary>
-        internal static bool TryMatchGetMethod(InvocationExpressionSyntax invocation, SemanticModel semanticModel, CancellationToken cancellationToken, out ReflectedMember member, out Name name, out Flags flags, out Types types)
-        {
-            if (invocation.TryGetTarget(KnownSymbol.Type.GetMethod, semanticModel, cancellationToken, out var getX))
-            {
-                if (ReflectedMember.TryGetType(invocation, semanticModel, cancellationToken, out var type, out var typeSource) &&
-                    IsKnownSignature(invocation, getX) &&
-                    Name.TryCreate(invocation, getX, semanticModel, cancellationToken, out name) &&
-                    Flags.TryCreate(invocation, getX, semanticModel, cancellationToken, out flags) &&
-                    Types.TryCreate(invocation, getX, semanticModel, cancellationToken, out types))
-                {
-                    return ReflectedMember.TryCreate(getX, invocation, type, typeSource, name, flags.Effective, types, semanticModel.Compilation, out member);
-                }
-
-                if (Flags.TryCreate(invocation, getX, semanticModel, cancellationToken, out flags) &&
-                    flags.AreInSufficient)
-                {
-                    _ = Name.TryCreate(invocation, getX, semanticModel, cancellationToken, out name);
-                    _ = Types.TryCreate(invocation, getX, semanticModel, cancellationToken, out types);
-                    member = new ReflectedMember(type, typeSource, null, getX, invocation, FilterMatch.InSufficientFlags);
-                    return true;
-                }
-            }
-
-            member = default;
-            flags = default;
-            name = default;
-            types = default;
-            return false;
-        }
-
         /// <summary>
         /// Check if <paramref name="invocation"/> is a call to Type.GetNestedType.
         /// </summary>

ReflectionAnalyzers/NodeAnalzers/GetXAnalyzer.cs

@@ -256,10 +256,18 @@ private static bool TryGetX(SyntaxNodeAnalysisContext context, out ReflectedMemb
             name = default;
             if (context.Node is InvocationExpressionSyntax candidate)
             {
+                if (GetMethod.Match(candidate, context.SemanticModel, context.CancellationToken) is { } getMethod)
+                {
+                    member = getMethod.Member;
+                    name = getMethod.Name;
+                    flags = getMethod.Flags;
+                    types = getMethod.Types;
+                    return true;
+                }
+
                 return GetX.TryMatchGetConstructor(candidate, context.SemanticModel, context.CancellationToken, out member, out flags, out types) ||
                        GetX.TryMatchGetEvent(candidate, context.SemanticModel, context.CancellationToken, out member, out name, out flags) ||
                        GetX.TryMatchGetField(candidate, context.SemanticModel, context.CancellationToken, out member, out name, out flags) ||
-                       GetX.TryMatchGetMethod(candidate, context.SemanticModel, context.CancellationToken, out member, out name, out flags, out types) ||
                        GetX.TryMatchGetNestedType(candidate, context.SemanticModel, context.CancellationToken, out member, out name, out flags) ||
                        GetX.TryMatchGetProperty(candidate, context.SemanticModel, context.CancellationToken, out member, out name, out flags, out types);
             }