Default nullable

Author: JohanLarsson

ReflectionAnalyzers.Tests/AllAnalyzersValid.cs

@@ -26,8 +26,7 @@ public static class AllAnalyzersValid
             settings: LibrarySettings.Roslyn);
 
         private static readonly Solution ValidCodeProject = CodeFactory.CreateSolution(
-            ProjectFile.Find("ValidCode.csproj"),
-            settings: LibrarySettings.NullableEnabled);
+            ProjectFile.Find("ValidCode.csproj"));
 
         [Test]
         public static void NotEmpty()

ReflectionAnalyzers.Tests/LibrarySettings.cs

@@ -4,17 +4,12 @@
 
     using Gu.Roslyn.Asserts;
 
-    using Microsoft.CodeAnalysis;
-
     internal static class LibrarySettings
     {
         internal static readonly Settings Wpf = Settings.Default.WithMetadataReferences(MetadataReferences.Transitive(typeof(System.Windows.Controls.Control)));
 
         internal static readonly Settings WindowsForms = Settings.Default.WithMetadataReferences(MetadataReferences.Transitive(typeof(System.Windows.Forms.Control)));
 
-        internal static readonly Settings NullableEnabled = Settings.Default
-                                                                    .WithCompilationOptions(x => x.WithNullableContextOptions(NullableContextOptions.Enable));
-
         internal static readonly Settings Roslyn = Settings.Default
                                                            .WithCompilationOptions(x => x.WithSuppressedDiagnostics("CS1701"))
                                                            .WithMetadataReferences(MetadataReferences.Transitive(typeof(Microsoft.CodeAnalysis.CodeFixes.CodeFixProvider)));

ReflectionAnalyzers.Tests/REFL001CastReturnValueTests/CodeFix.MethodInfoInvoke.cs

@@ -51,7 +51,7 @@ public C()
         public static int M() => 0;
     }
 }".AssertReplace("typeof(C).GetMethod(nameof(M)).Invoke(null, null)", expression);
-                RoslynAssert.CodeFix(Analyzer, Fix, ExpectedDiagnostic, before, after, settings: LibrarySettings.NullableEnabled);
+                RoslynAssert.CodeFix(Analyzer, Fix, ExpectedDiagnostic, before, after);
             }
 
             [Test]
@@ -80,7 +80,7 @@ public class C
         public static int M() => 0;
     }
 }";
-                RoslynAssert.CodeFix(Analyzer, Fix, ExpectedDiagnostic, before, after, settings: LibrarySettings.NullableEnabled);
+                RoslynAssert.CodeFix(Analyzer, Fix, ExpectedDiagnostic, before, after);
             }
 
             [Test]
@@ -115,7 +115,7 @@ public class C
         public static int M() => 0;
     }
 }";
-                RoslynAssert.CodeFix(Analyzer, Fix, ExpectedDiagnostic, before, after, settings: LibrarySettings.NullableEnabled);
+                RoslynAssert.CodeFix(Analyzer, Fix, ExpectedDiagnostic, before, after);
             }
         }
     }

ReflectionAnalyzers.Tests/REFL001CastReturnValueTests/Valid.ActivatorCreateInstance.cs

@@ -26,7 +26,7 @@ public class C
     }
 }".AssertReplace("CreateInstance<T>()", call);
 
-                RoslynAssert.Valid(Analyzer, Descriptor, code, settings: LibrarySettings.NullableEnabled);
+                RoslynAssert.Valid(Analyzer, Descriptor, code);
             }
 
             [TestCase("Activator.CreateInstance(typeof(C))")]
@@ -45,7 +45,7 @@ public class C
         public static object? M() => (C)Activator.CreateInstance(typeof(C));
     }
 }".AssertReplace("Activator.CreateInstance(typeof(C))", expression);
-                RoslynAssert.Valid(Analyzer, Descriptor, code, settings: LibrarySettings.NullableEnabled);
+                RoslynAssert.Valid(Analyzer, Descriptor, code);
             }
         }
     }

ReflectionAnalyzers.Tests/REFL003MemberDoesNotExistTests/Diagnostics.cs

@@ -169,7 +169,7 @@ class C
         }
 
         [TestCase("typeof(C).GetMethod(↓\"get_P\")")]
-        //[TestCase("typeof(C).GetProperty(nameof(P)).↓GetMethod")]
+        [TestCase("typeof(C).GetProperty(nameof(P)).↓GetMethod")]
         //[TestCase("typeof(C).GetProperty(nameof(P))!.↓GetMethod")]
         //[TestCase("typeof(C).GetProperty(nameof(P))?.↓GetMethod")]
         public static void MissingGetter(string call)
@@ -190,7 +190,7 @@ public int P { set { } }
         }
 
         [TestCase("typeof(C).GetMethod(↓\"set_P\")")]
-        //[TestCase("typeof(C).GetProperty(nameof(P)).↓SetMethod")]
+        [TestCase("typeof(C).GetProperty(nameof(P)).↓SetMethod")]
         //[TestCase("typeof(C).GetProperty(nameof(P))!.↓SetMethod")]
         //[TestCase("typeof(C).GetProperty(nameof(P))?.↓SetMethod")]
         public static void MissingSetter(string call)

ReflectionAnalyzers.Tests/REFL033UseSameTypeAsParameterTests/Valid.cs

@@ -26,7 +26,7 @@ class C
     }
 }";
 
-            RoslynAssert.Valid(Analyzer, Descriptor, code, settings: LibrarySettings.NullableEnabled);
+            RoslynAssert.Valid(Analyzer, Descriptor, code);
         }
 
         [Test]
@@ -46,7 +46,7 @@ class C
     }
 }";
 
-            RoslynAssert.Valid(Analyzer, Descriptor, code, settings: LibrarySettings.NullableEnabled);
+            RoslynAssert.Valid(Analyzer, Descriptor, code);
         }
 
         [Test]