Implement TestEmptySourceAsync and TestHelpLink independently of DiagnosticVerifier

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp7/AnalyzerConfigurationTestsCSharp7.cs

@@ -0,0 +1,9 @@
+// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
+// Licensed under the Apache License, Version 2.0. See LICENSE in the project root for license information.
+
+namespace StyleCop.Analyzers.Test.CSharp7
+{
+    public class AnalyzerConfigurationTestsCSharp7 : AnalyzerConfigurationTests
+    {
+    }
+}

StyleCop.Analyzers/StyleCop.Analyzers.Test/AnalyzerConfigurationTests.cs

@@ -0,0 +1,79 @@
+// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
+// Licensed under the Apache License, Version 2.0. See LICENSE in the project root for license information.
+
+namespace StyleCop.Analyzers.Test
+{
+    using System;
+    using System.Collections.Generic;
+    using System.Linq;
+    using System.Threading;
+    using System.Threading.Tasks;
+    using Microsoft.CodeAnalysis;
+    using Microsoft.CodeAnalysis.CodeFixes;
+    using Microsoft.CodeAnalysis.Diagnostics;
+    using StyleCop.Analyzers.Test.Verifiers;
+    using Xunit;
+
+    public class AnalyzerConfigurationTests
+    {
+        public static IEnumerable<object[]> AllAnalyzers
+        {
+            get
+            {
+                foreach (var type in typeof(AnalyzerCategory).Assembly.DefinedTypes)
+                {
+                    if (type.GetCustomAttributes(typeof(DiagnosticAnalyzerAttribute), true).Any())
+                    {
+                        yield return new object[] { type };
+                    }
+                }
+            }
+        }
+
+        [Theory]
+        [MemberData(nameof(AllAnalyzers))]
+        public async Task TestEmptySourceAsync(Type analyzerType)
+        {
+            await new CSharpTest(analyzerType)
+            {
+                TestCode = string.Empty,
+            }.RunAsync(CancellationToken.None).ConfigureAwait(false);
+        }
+
+        [Theory]
+        [MemberData(nameof(AllAnalyzers))]
+        public void TestHelpLink(Type analyzerType)
+        {
+            var analyzer = (DiagnosticAnalyzer)Activator.CreateInstance(analyzerType);
+            foreach (var diagnostic in analyzer.SupportedDiagnostics)
+            {
+                if (diagnostic.DefaultSeverity == DiagnosticSeverity.Hidden && diagnostic.CustomTags.Contains(WellKnownDiagnosticTags.NotConfigurable))
+                {
+                    // This diagnostic will never appear in the UI
+                    continue;
+                }
+
+                string expected = $"https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/{diagnostic.Id}.md";
+                Assert.Equal(expected, diagnostic.HelpLinkUri);
+            }
+        }
+
+        private class CSharpTest : GenericAnalyzerTest
+        {
+            private readonly Type analyzerType;
+
+            public CSharpTest(Type analyzerType)
+            {
+                this.analyzerType = analyzerType;
+            }
+
+            public override string Language => LanguageNames.CSharp;
+
+            protected override IEnumerable<CodeFixProvider> GetCodeFixProviders()
+                => new CodeFixProvider[0];
+
+            protected override IEnumerable<DiagnosticAnalyzer> GetDiagnosticAnalyzers()
+                => new[] { (DiagnosticAnalyzer)Activator.CreateInstance(this.analyzerType) };
+        }
+    }
+}

StyleCop.Analyzers/StyleCop.Analyzers.Test/Verifiers/DiagnosticVerifier.cs

@@ -72,40 +72,6 @@ public int TabSize
 
         protected static DiagnosticResult[] EmptyDiagnosticResults { get; } = { };
 
-        /// <summary>
-        /// Verifies that the analyzer will properly handle an empty source.
-        /// </summary>
-        /// <returns>A <see cref="Task"/> representing the asynchronous unit test.</returns>
-        [Fact]
-        public async Task TestEmptySourceAsync()
-        {
-            var testCode = string.Empty;
-            await this.VerifyCSharpDiagnosticAsync(testCode, EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
-        }
-
-        /// <summary>
-        /// Verifies that each diagnostics contains a <see cref="DiagnosticDescriptor.HelpLinkUri"/> in the expected
-        /// format.
-        /// </summary>
-        [Fact]
-        public void TestHelpLink()
-        {
-            foreach (var diagnosticAnalyzer in this.GetCSharpDiagnosticAnalyzers())
-            {
-                foreach (var diagnostic in diagnosticAnalyzer.SupportedDiagnostics)
-                {
-                    if (diagnostic.DefaultSeverity == DiagnosticSeverity.Hidden && diagnostic.CustomTags.Contains(WellKnownDiagnosticTags.NotConfigurable))
-                    {
-                        // This diagnostic will never appear in the UI.
-                        continue;
-                    }
-
-                    string expected = $"https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/{diagnostic.Id}.md";
-                    Assert.Equal(expected, diagnostic.HelpLinkUri);
-                }
-            }
-        }
-
         /// <summary>
         /// Gets the C# analyzers being tested.
         /// </summary>