Update wording to reflect rule severity

Fixes #2036
Fixes #2272

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test/Helpers/UseCultureAttribute.cs

@@ -25,9 +25,9 @@ public class UseCultureAttribute : BeforeAfterTestAttribute
     {
         private readonly Lazy<CultureInfo> culture;
 
-#pragma warning disable SA1305 // Field names must not use Hungarian notation
+#pragma warning disable SA1305 // Field names should not use Hungarian notation
         private readonly Lazy<CultureInfo> uiCulture;
-#pragma warning restore SA1305 // Field names must not use Hungarian notation
+#pragma warning restore SA1305 // Field names should not use Hungarian notation
 
         private CultureInfo originalCulture;
 
@@ -49,15 +49,15 @@ public UseCultureAttribute(string culture)
         {
         }
 
-#pragma warning disable SA1305 // Field names must not use Hungarian notation
+#pragma warning disable SA1305 // Field names should not use Hungarian notation
         /// <summary>
         /// Initializes a new instance of the <see cref="UseCultureAttribute"/>
         /// class with a culture and a UI culture.
         /// </summary>
         /// <param name="culture">The name of the culture.</param>
         /// <param name="uiCulture">The name of the UI culture.</param>
         public UseCultureAttribute(string culture, string uiCulture)
-#pragma warning restore SA1305 // Field names must not use Hungarian notation
+#pragma warning restore SA1305 // Field names should not use Hungarian notation
         {
             this.culture = new Lazy<CultureInfo>(() => new CultureInfo(culture));
             this.uiCulture = new Lazy<CultureInfo>(() => new CultureInfo(uiCulture));

StyleCop.Analyzers/StyleCop.Analyzers.Test/LayoutRules/SA1509UnitTests.cs

@@ -860,9 +860,9 @@ public async Task TestInterfaceDeclarationWithSurroundingPragmasAsync()
 namespace TestNamespace
 {
 
-#pragma warning disable SA1302 // Interface names must begin with I
+#pragma warning disable SA1302 // Interface names should begin with I
     public interface ActiveConfiguredProject<out T>
-#pragma warning restore SA1302 // Interface names must begin with I
+#pragma warning restore SA1302 // Interface names should begin with I
     {
         /// <summary>
         /// Gets the ConfiguredProject exported value.

StyleCop.Analyzers/StyleCop.Analyzers.Test/LayoutRules/SA1516UnitTests.cs

@@ -80,7 +80,7 @@ class Foo { }
         [Fact]
         public void DiagnosticMessageFormatIsCorrect()
         {
-            Assert.Equal("Elements must be separated by blank line", this.GetCSharpDiagnosticAnalyzers().Single().SupportedDiagnostics.Single().MessageFormat.ToString());
+            Assert.Equal("Elements should be separated by blank line", this.GetCSharpDiagnosticAnalyzers().Single().SupportedDiagnostics.Single().MessageFormat.ToString());
         }
 
         [Fact]

StyleCop.Analyzers/StyleCop.Analyzers.Test/OrderingRules/SA1202UnitTests.cs

@@ -788,7 +788,7 @@ string IA.T
         get { return null; }
     }
 
-    // SA1202 (All public properties must come before all private properties) wrongly reported here.
+    // SA1202 (All public properties should come before all private properties) wrongly reported here.
     public int W { get; set; }
 
     protected string S { get; set; }
@@ -846,7 +846,7 @@ string IA.T
         get { return null; }
     }
 
-    // SA1202 (All public properties must come before all private properties) wrongly reported here.
+    // SA1202 (All public properties should come before all private properties) wrongly reported here.
     public int W { get; set; }
 
     // SA1202 should be reported here (according to legacy StyleCop), but is not.

StyleCop.Analyzers/StyleCop.Analyzers.Test/OrderingRules/UsingCodeFixProviderRegressionUnitTests.cs

@@ -45,10 +45,10 @@ public async Task VerifyRegressionFor2026Async()
 
 namespace Microsoft.VisualStudio.Shell
 {
-#pragma warning disable SA1200 // Using directives must be placed correctly
+#pragma warning disable SA1200 // Using directives should be placed correctly
     // This is required to work around accessibility issues in documentation comments.
     using NativeMethods = System;
-#pragma warning restore SA1200 // Using directives must be placed correctly
+#pragma warning restore SA1200 // Using directives should be placed correctly
 }
 
 #endif
@@ -73,10 +73,10 @@ namespace Microsoft.VisualStudio.Shell
 
 namespace Microsoft.VisualStudio.Shell
 {
-#pragma warning disable SA1200 // Using directives must be placed correctly
+#pragma warning disable SA1200 // Using directives should be placed correctly
     // This is required to work around accessibility issues in documentation comments.
     using NativeMethods = System;
-#pragma warning restore SA1200 // Using directives must be placed correctly
+#pragma warning restore SA1200 // Using directives should be placed correctly
 }
 
 #endif

StyleCop.Analyzers/StyleCop.Analyzers.Test/SpacingRules/SA1024UnitTests.cs

@@ -213,7 +213,7 @@ private int Bar(int value)
         }
 
         /// <summary>
-        /// Verifies that the analyzer will produce the proper diagnostics when the colons must not preceded by space.
+        /// Verifies that the analyzer will produce the proper diagnostics when the colons should not preceded by space.
         /// </summary>
         /// <returns>A <see cref="Task"/> representing the asynchronous unit test.</returns>
         [Fact]

StyleCop.Analyzers/StyleCop.Analyzers/AnalyzerConstants.cs

@@ -29,7 +29,7 @@ static AnalyzerConstants()
         /// to disable a diagnostic which is currently untested.
         /// </value>
         [ExcludeFromCodeCoverage]
-        [SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1623:Property summary documentation must match accessors.", Justification = "This property behaves more like an opaque value than a Boolean.")]
+        [SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1623:Property summary documentation should match accessors.", Justification = "This property behaves more like an opaque value than a Boolean.")]
         internal static bool DisabledNoTests { get; }
 
         /// <summary>
@@ -44,7 +44,7 @@ static AnalyzerConstants()
         /// to indicate that the diagnostic is disabled by default because it is an alternative to a reference StyleCop
         /// rule.
         /// </value>
-        [SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1623:Property summary documentation must match accessors.", Justification = "This property behaves more like an opaque value than a Boolean.")]
+        [SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1623:Property summary documentation should match accessors.", Justification = "This property behaves more like an opaque value than a Boolean.")]
         internal static bool DisabledAlternative => false;
 
         /// <summary>
@@ -57,7 +57,7 @@ static AnalyzerConstants()
         /// <see cref="DiagnosticDescriptor(string, string, string, string, DiagnosticSeverity, bool, string, string, string[])"/>
         /// to indicate that the diagnostic should be enabled by default.
         /// </value>
-        [SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1623:Property summary documentation must match accessors.", Justification = "This property behaves more like an opaque value than a Boolean.")]
+        [SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1623:Property summary documentation should match accessors.", Justification = "This property behaves more like an opaque value than a Boolean.")]
         internal static bool EnabledByDefault => true;
 
         /// <summary>
@@ -70,7 +70,7 @@ static AnalyzerConstants()
         /// <see cref="DiagnosticDescriptor(string, string, string, string, DiagnosticSeverity, bool, string, string, string[])"/>
         /// to indicate that the diagnostic should be disabled by default.
         /// </value>
-        [SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1623:Property summary documentation must match accessors.", Justification = "This property behaves more like an opaque value than a Boolean.")]
+        [SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1623:Property summary documentation should match accessors.", Justification = "This property behaves more like an opaque value than a Boolean.")]
         internal static bool DisabledByDefault => false;
     }
 }