Fix RS1032 (Define diagnostic message correctly)

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1612UnitTests.cs

@@ -132,7 +132,7 @@ public class ClassName
 }";
 
             var diagnostic = Diagnostic()
-                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}.");
+                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}");
 
             var expected = new[]
             {
@@ -215,7 +215,7 @@ public class ClassName
 }";
 
             var diagnostic = Diagnostic()
-                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}.");
+                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}");
 
             var expected = new[]
             {
@@ -248,7 +248,7 @@ public class ClassName
 }";
 
             var diagnostic = Diagnostic()
-                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}.");
+                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}");
 
             var expected = diagnostic.WithLocation(13, 22).WithArguments("bar", 2);
 
@@ -353,7 +353,7 @@ public class ClassName
 }";
 
             var diagnostic = Diagnostic()
-                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}.");
+                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}");
 
             var expected = new[]
             {
@@ -400,7 +400,7 @@ public class ClassName
 }";
 
             var diagnostic = Diagnostic()
-                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}.");
+                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}");
 
             var expected = diagnostic.WithLocation(8, 22).WithArguments("bar", 2);
 

StyleCop.Analyzers/StyleCop.Analyzers.Test/ReadabilityRules/SA1130UnitTests.cs

@@ -3,6 +3,7 @@
 
 namespace StyleCop.Analyzers.Test.ReadabilityRules
 {
+    using System.Diagnostics.CodeAnalysis;
     using System.Threading;
     using System.Threading.Tasks;
     using Microsoft.CodeAnalysis;
@@ -15,9 +16,11 @@ namespace StyleCop.Analyzers.Test.ReadabilityRules
 
     public class SA1130UnitTests
     {
+        [SuppressMessage("MicrosoftCodeAnalysisDesign", "RS1032:Define diagnostic message correctly", Justification = "The message here matches the compiler.")]
         private static readonly DiagnosticDescriptor CS1065 =
                    new DiagnosticDescriptor(nameof(CS1065), "Title", "Default values are not valid in this context.", "Category", DiagnosticSeverity.Error, AnalyzerConstants.EnabledByDefault);
 
+        [SuppressMessage("MicrosoftCodeAnalysisDesign", "RS1032:Define diagnostic message correctly", Justification = "The message here matches the compiler.")]
         private static readonly DiagnosticDescriptor CS7014 =
                    new DiagnosticDescriptor(nameof(CS7014), "Title", "Attributes are not valid in this context.", "Category", DiagnosticSeverity.Error, AnalyzerConstants.EnabledByDefault);
 

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/DocumentationResources.Designer.cs

@@ -268,10 +268,10 @@
     <value>The documentation describing the parameters to a C# method, constructor, delegate or indexer element does not match the actual parameters on the element.</value>
   </data>
   <data name="SA1612MissingParamForDocumentationMessageFormat" xml:space="preserve">
-    <value>The parameter '{0}' does not exist.</value>
+    <value>The parameter '{0}' does not exist</value>
   </data>
   <data name="SA1612ParamWrongOrderMessageFormat" xml:space="preserve">
-    <value>The parameter documentation for '{0}' should be at position {1}.</value>
+    <value>The parameter documentation for '{0}' should be at position {1}</value>
   </data>
   <data name="SA1612Title" xml:space="preserve">
     <value>Element parameter documentation should match element parameters</value>
@@ -418,7 +418,7 @@
     <value>The XML header documentation for a C# code element contains an empty tag.</value>
   </data>
   <data name="SA1627MessageFormat" xml:space="preserve">
-    <value>The documentation text within the '{0}' tag should not be empty.</value>
+    <value>The documentation text within the '{0}' tag should not be empty</value>
   </data>
   <data name="SA1627Title" xml:space="preserve">
     <value>Documentation text should not be empty</value>
@@ -631,7 +631,7 @@
     <value>The file name of a C# code file does not match the first type declared in the file.</value>
   </data>
   <data name="SA1649MessageFormat" xml:space="preserve">
-    <value>File name should match first type name.</value>
+    <value>File name should match first type name</value>
   </data>
   <data name="SA1649Title" xml:space="preserve">
     <value>File name should match first type name</value>

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/DocumentationResources.resx

@@ -241,7 +241,7 @@
     <value>The opening parenthesis or bracket is not placed on the same line as the method/indexer/attribute/array name.</value>
   </data>
   <data name="SA1110MessageFormat" xml:space="preserve">
-    <value>Opening parenthesis or bracket should be on declaration line.</value>
+    <value>Opening parenthesis or bracket should be on declaration line</value>
   </data>
   <data name="SA1110Title" xml:space="preserve">
     <value>Opening parenthesis or bracket should be on declaration line</value>
@@ -268,7 +268,7 @@
     <value>A comma between two parameters in a call to a C# method or indexer, or in the declaration of a method or indexer, is not placed on the same line as the previous parameter.</value>
   </data>
   <data name="SA1113MessageFormat" xml:space="preserve">
-    <value>Comma should be on the same line as previous parameter.</value>
+    <value>Comma should be on the same line as previous parameter</value>
   </data>
   <data name="SA1113Title" xml:space="preserve">
     <value>Comma should be on the same line as previous parameter</value>
@@ -286,7 +286,7 @@
     <value>A parameter within a C# method or indexer call or declaration does not begin on the same line as the previous parameter, or on the next line.</value>
   </data>
   <data name="SA1115MessageFormat" xml:space="preserve">
-    <value>The parameter should begin on the line after the previous parameter.</value>
+    <value>The parameter should begin on the line after the previous parameter</value>
   </data>
   <data name="SA1115Title" xml:space="preserve">
     <value>Parameter should follow comma</value>
@@ -307,7 +307,7 @@
     <value>The parameters to a C# method or indexer call or declaration are not all on the same line or each on a separate line.</value>
   </data>
   <data name="SA1117MessageFormat" xml:space="preserve">
-    <value>The parameters should all be placed on the same line or each parameter should be placed on its own line.</value>
+    <value>The parameters should all be placed on the same line or each parameter should be placed on its own line</value>
   </data>
   <data name="SA1117Title" xml:space="preserve">
     <value>Parameters should be on same line or separate lines</value>
@@ -361,7 +361,7 @@
     <value>The C# code contains a region within the body of a code element.</value>
   </data>
   <data name="SA1123MessageFormat" xml:space="preserve">
-    <value>Region should not be located within a code element.</value>
+    <value>Region should not be located within a code element</value>
   </data>
   <data name="SA1123Title" xml:space="preserve">
     <value>Do not place regions within elements</value>
@@ -472,7 +472,7 @@
     <value>Each attribute usage should be placed in its own set of square brackets for maximum readability.</value>
   </data>
   <data name="SA1133MessageFormat" xml:space="preserve">
-    <value>Each attribute should be placed in its own set of square brackets.</value>
+    <value>Each attribute should be placed in its own set of square brackets</value>
   </data>
   <data name="SA1133Title" xml:space="preserve">
     <value>Do not combine attributes</value>
@@ -484,7 +484,7 @@
     <value>Each attribute should be placed on its own line of code.</value>
   </data>
   <data name="SA1134MessageFormat" xml:space="preserve">
-    <value>Each attribute should be placed on its own line of code.</value>
+    <value>Each attribute should be placed on its own line of code</value>
   </data>
   <data name="SA1134Title" xml:space="preserve">
     <value>Attributes should not share line</value>