Use DocumentationCulture in SA1643DestructorSummaryDocumentationMustBeginWithStandardText

Christian Käser · Christian Käser · commit 0bab64a81a2b · 2016-09-09T13:33:13.000+02:00
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/DocumentationResources.Designer.cs b/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/DocumentationResources.Designer.cs
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/DocumentationResources.de-DE.resx b/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/DocumentationResources.de-DE.resx
@@ -117,6 +117,12 @@
   <resheader name="writer">
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
+  <data name="DestructorStandardTextFirstPart" xml:space="preserve">
+    <value>Finalisiert eine Instanz der </value>
+  </data>
+  <data name="DestructorStandardTextSecondPart" xml:space="preserve">
+    <value> Klasse.</value>
+  </data>
   <data name="StartingTextGets" xml:space="preserve">
     <value>Holt</value>
   </data>
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/DocumentationResources.resx b/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/DocumentationResources.resx
@@ -117,6 +117,12 @@
   <resheader name="writer">
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
+  <data name="DestructorStandardTextFirstPart" xml:space="preserve">
+    <value>Finalizes an instance of the </value>
+  </data>
+  <data name="DestructorStandardTextSecondPart" xml:space="preserve">
+    <value> class.</value>
+  </data>
   <data name="InheritdocCodeFix" xml:space="preserve">
     <value>Inherit documentation</value>
   </data>
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1643DestructorSummaryDocumentationMustBeginWithStandardText.cs b/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1643DestructorSummaryDocumentationMustBeginWithStandardText.cs
@@ -5,6 +5,9 @@ namespace StyleCop.Analyzers.DocumentationRules
 {
     using System;
     using System.Collections.Immutable;
+    using System.Globalization;
+    using System.Threading;
+
     using Microsoft.CodeAnalysis;
     using Microsoft.CodeAnalysis.CSharp;
     using Microsoft.CodeAnalysis.CSharp.Syntax;
@@ -96,7 +99,15 @@ private static void HandleDestructor(SyntaxNodeAnalysisContext context)
 
             if (destructorDeclaration != null)
             {
-                HandleDeclaration(context, DestructorStandardText[0], DestructorStandardText[1], Descriptor);
+                var settings = context.Options.GetStyleCopSettings(CancellationToken.None);
+                var culture = new CultureInfo(settings.DocumentationRules.DocumentationCulture);
+                var resourceManager = DocumentationResources.ResourceManager;
+
+                HandleDeclaration(
+                    context,
+                    resourceManager.GetString("DestructorStandardTextFirstPart", culture),
+                    resourceManager.GetString("DestructorStandardTextSecondPart", culture),
+                    Descriptor);
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,9 @@ namespace StyleCop.Analyzers.DocumentationRules`
`5`	`5`	`{`
`6`	`6`	`using System;`
`7`	`7`	`using System.Collections.Immutable;`
	`8`	`+ using System.Globalization;`
	`9`	`+ using System.Threading;`
	`10`	`+`
`8`	`11`	`using Microsoft.CodeAnalysis;`
`9`	`12`	`using Microsoft.CodeAnalysis.CSharp;`
`10`	`13`	`using Microsoft.CodeAnalysis.CSharp.Syntax;`
`@@ -96,7 +99,15 @@ private static void HandleDestructor(SyntaxNodeAnalysisContext context)`
`96`	`99`
`97`	`100`	`if (destructorDeclaration != null)`
`98`	`101`	`{`
`99`		`- HandleDeclaration(context, DestructorStandardText[0], DestructorStandardText[1], Descriptor);`
	`102`	`+ var settings = context.Options.GetStyleCopSettings(CancellationToken.None);`
	`103`	`+ var culture = new CultureInfo(settings.DocumentationRules.DocumentationCulture);`
	`104`	`+ var resourceManager = DocumentationResources.ResourceManager;`
	`105`	`+`
	`106`	`+ HandleDeclaration(`
	`107`	`+ context,`
	`108`	`+ resourceManager.GetString("DestructorStandardTextFirstPart", culture),`
	`109`	`+ resourceManager.GetString("DestructorStandardTextSecondPart", culture),`
	`110`	`+ Descriptor);`
`100`	`111`	`}`
`101`	`112`	`}`
`102`	`113`	`}`