Merge pull request #1838 from sharwell/fix-1832

Fix SA1009 handling of closing parenthesis followed by pointer dereference

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test/SpacingRules/SA1009UnitTests.cs

@@ -324,6 +324,17 @@ public async Task TestSpaceMethodCallFollowedByConditionalAccessPropertyGetAsync
             await this.TestWhitespaceInStatementOrDeclAsync(invalidStatement, validStatement, expected).ConfigureAwait(false);
         }
 
+        [Fact]
+        public async Task TestSpaceMethodCallFollowedByPointerDereferenceAsync()
+        {
+            var invalidStatement = @"var o = GetPointer() ->ToString();";
+            var validStatement = @"var o = GetPointer()->ToString();";
+
+            DiagnosticResult expected = this.CSharpDiagnostic().WithArguments(" not", "followed").WithLocation(7, 32);
+
+            await this.TestWhitespaceInStatementOrDeclAsync(invalidStatement, validStatement, expected).ConfigureAwait(false);
+        }
+
         [Fact]
         public async Task TestSpaceOperationInDoubleSetOfParenthesisAsync()
         {
@@ -820,7 +831,7 @@ private async Task TestWhitespaceInStatementOrDeclAsync(string originalStatement
 {{
     class Bar
     {{
-        void DoIt()
+        unsafe void DoIt()
         {{
             {0}
         }}
@@ -835,6 +846,11 @@ Baz GetB()
             return null;
         }}
 
+        unsafe int* GetPointer()
+        {{
+            return null;
+        }}
+
         class Baz
         {{
             public object this[int i]

StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1009ClosingParenthesisMustBeSpacedCorrectly.cs

@@ -128,7 +128,8 @@ private static void HandleCloseParenToken(SyntaxTreeAnalysisContext context, Syn
                 break;
 
             case SyntaxKind.DotToken:
-                // allow a space for this case, but only if the ')' character is the last on the line
+            case SyntaxKind.MinusGreaterThanToken:
+                // allow a space for these cases, but only if the ')' character is the last on the line
                 allowEndOfLine = true;
                 precedesStickyCharacter = true;
                 break;