Provide a capacity when initializing the StringBuilder

sharwell · sharwell · commit 105f1d064d95 · 2015-09-14T06:50:33.000-05:00
The chosen capacity exceeds the true requirement in cases where a trivia
contains both tabs and other characters, but for the most common case of
lines indented with hard tabs is exactly the correct amount.
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1027CodeFixProvider.cs b/StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1027CodeFixProvider.cs
@@ -59,7 +59,7 @@ private static TextChange FixDiagnostic(IndentationOptions indentationOptions, S
 
             TextLine startLine = sourceText.Lines.GetLineFromPosition(span.Start);
             string text = sourceText.ToString(TextSpan.FromBounds(startLine.Start, span.End));
-            StringBuilder replacement = new StringBuilder();
+            StringBuilder replacement = new StringBuilder(indentationOptions.TabSize * span.Length);
             int column = 0;
             for (int i = 0; i < text.Length; i++)
             {

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ private static TextChange FixDiagnostic(IndentationOptions indentationOptions, S`
`59`	`59`
`60`	`60`	`TextLine startLine = sourceText.Lines.GetLineFromPosition(span.Start);`
`61`	`61`	`string text = sourceText.ToString(TextSpan.FromBounds(startLine.Start, span.End));`
`62`		`- StringBuilder replacement = new StringBuilder();`
	`62`	`+ StringBuilder replacement = new StringBuilder(indentationOptions.TabSize * span.Length);`
`63`	`63`	`int column = 0;`
`64`	`64`	`for (int i = 0; i < text.Length; i++)`
`65`	`65`	`{`