Update tests for target-typed conditional expressions

Closes #3974

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp9/MaintainabilityRules/SA1119CSharp9UnitTests.cs

@@ -1,8 +1,6 @@
 // Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
 // Licensed under the MIT License. See LICENSE in the project root for license information.
 
-#nullable disable
-
 namespace StyleCop.Analyzers.Test.CSharp9.MaintainabilityRules
 {
     using System.Threading;
@@ -152,5 +150,38 @@ public object TestMethod(Foo n, int a)
                 TestCode = testCode,
             }.RunAsync(CancellationToken.None).ConfigureAwait(false);
         }
+
+        [Fact]
+        [WorkItem(3974, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3974")]
+        public async Task TestConditionalExpressionWithTargetTypedNewAsync()
+        {
+            const string testCode = @"public class TestClass
+{
+    public object GetValue(bool flag)
+    {
+        return {|#0:{|#1:(|}flag ? null : new(){|#2:)|}|};
+    }
+}";
+
+            const string fixedCode = @"public class TestClass
+{
+    public object GetValue(bool flag)
+    {
+        return flag ? null : new();
+    }
+}";
+
+            await new CSharpTest()
+            {
+                TestCode = testCode,
+                ExpectedDiagnostics =
+                {
+                    Diagnostic(DiagnosticId).WithLocation(0),
+                    Diagnostic(ParenthesesDiagnosticId).WithLocation(1),
+                    Diagnostic(ParenthesesDiagnosticId).WithLocation(2),
+                },
+                FixedCode = fixedCode,
+            }.RunAsync(CancellationToken.None).ConfigureAwait(false);
+        }
     }
 }

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp9/SpacingRules/SA1000CSharp9UnitTests.cs

@@ -1,8 +1,6 @@
 // Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
 // Licensed under the MIT License. See LICENSE in the project root for license information.
 
-#nullable disable
-
 namespace StyleCop.Analyzers.Test.CSharp9.SpacingRules
 {
     using System.Threading.Tasks;
@@ -24,6 +22,15 @@ public async Task TestTargetTypedNewAsync()
             await this.TestKeywordStatementAsync(statementWithoutSpace, DiagnosticResult.EmptyDiagnosticResults, statementWithoutSpace).ConfigureAwait(false);
         }
 
+        [Fact]
+        [WorkItem(3974, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3974")]
+        public async Task TestTargetTypedNewInConditionalExpressionAsync()
+        {
+            string statement = "bool flag = true; object value = flag ? null : new();";
+
+            await this.TestKeywordStatementAsync(statement, DiagnosticResult.EmptyDiagnosticResults, statement).ConfigureAwait(false);
+        }
+
         [Fact]
         [WorkItem(3508, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3508")]
         public async Task TestIsBeforeRelationalPatternAsync()

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp9/SpacingRules/SA1003CSharp9UnitTests.cs

@@ -3,9 +3,48 @@
 
 namespace StyleCop.Analyzers.Test.CSharp9.SpacingRules
 {
+    using System.Threading;
+    using System.Threading.Tasks;
+    using Microsoft.CodeAnalysis.Testing;
     using StyleCop.Analyzers.Test.CSharp8.SpacingRules;
+    using Xunit;
+    using static StyleCop.Analyzers.SpacingRules.SA1003SymbolsMustBeSpacedCorrectly;
+    using static StyleCop.Analyzers.Test.Verifiers.StyleCopCodeFixVerifier<
+        StyleCop.Analyzers.SpacingRules.SA1003SymbolsMustBeSpacedCorrectly,
+        StyleCop.Analyzers.SpacingRules.SA1003CodeFixProvider>;
 
     public partial class SA1003CSharp9UnitTests : SA1003CSharp8UnitTests
     {
+        [Fact]
+        [WorkItem(3974, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3974")]
+        public async Task TestTargetTypedConditionalExpressionSpacingAsync()
+        {
+            var testCode = @"
+class TestClass
+{
+    void M(bool flag)
+    {
+        object value = flag{|#0:?|} null{|#1::|}new();
+    }
+}";
+
+            var fixedCode = @"
+class TestClass
+{
+    void M(bool flag)
+    {
+        object value = flag ? null : new();
+    }
+}";
+
+            DiagnosticResult[] expected =
+            {
+                Diagnostic(DescriptorPrecededByWhitespace).WithArguments("?").WithLocation(0),
+                Diagnostic(DescriptorPrecededByWhitespace).WithArguments(":").WithLocation(1),
+                Diagnostic(DescriptorFollowedByWhitespace).WithArguments(":").WithLocation(1),
+            };
+
+            await VerifyCSharpFixAsync(testCode, expected, fixedCode, CancellationToken.None).ConfigureAwait(false);
+        }
     }
 }

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp9/SpacingRules/SA1024CSharp9UnitTests.cs

@@ -1,8 +1,6 @@
 // Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
 // Licensed under the MIT License. See LICENSE in the project root for license information.
 
-#nullable disable
-
 namespace StyleCop.Analyzers.Test.CSharp9.SpacingRules
 {
     using System.Threading;
@@ -53,5 +51,39 @@ public record MyQuery3() : BaseQuery<object>;";
                 FixedCode = fixedCode,
             }.RunAsync(CancellationToken.None).ConfigureAwait(false);
         }
+
+        [Fact]
+        [WorkItem(3974, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3974")]
+        public async Task TestConditionalExpressionWithTargetTypedNewAsync()
+        {
+            const string testCode = @"
+class TestClass
+{
+    void M(bool flag)
+    {
+        object value = flag ? null{|#0::|}new();
+    }
+}";
+
+            const string fixedCode = @"
+class TestClass
+{
+    void M(bool flag)
+    {
+        object value = flag ? null : new();
+    }
+}";
+
+            await new CSharpTest()
+            {
+                ExpectedDiagnostics =
+                {
+                    Diagnostic(DescriptorPreceded).WithLocation(0),
+                    Diagnostic(DescriptorFollowed).WithLocation(0),
+                },
+                TestCode = testCode,
+                FixedCode = fixedCode,
+            }.RunAsync(CancellationToken.None).ConfigureAwait(false);
+        }
     }
 }