Skip to content

Commit 1147f65

Browse files
committed
Fix broken test (comparing SyntaxNode identity to a wrapper)
1 parent c31beae commit 1147f65

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp7/Lightup/IsPatternExpressionSyntaxWrapperTests.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,10 @@ public void TestProperties()
3737
Assert.Same(syntaxNode, isPatternExpressionSyntax.SyntaxNode);
3838
Assert.Same(syntaxNode.Expression, isPatternExpressionSyntax.Expression);
3939
Assert.True(syntaxNode.IsKeyword.IsEquivalentTo(isPatternExpressionSyntax.IsKeyword));
40-
Assert.Same(syntaxNode.Pattern, isPatternExpressionSyntax.Pattern);
40+
Assert.Same(syntaxNode.Pattern, isPatternExpressionSyntax.Pattern.SyntaxNode);
41+
Assert.Equal(SyntaxKind.NullLiteralExpression, ((ConstantPatternSyntax)isPatternExpressionSyntax.Pattern).Expression.Kind());
4142

42-
var newExpression = SyntaxFactory.LiteralExpression(SyntaxKind.NumericLiteralExpression, SyntaxFactory.Token(default(SyntaxTriviaList), SyntaxKind.NumericLiteralToken, "0", "0", default(SyntaxTriviaList)));
43+
var newExpression = SyntaxFactory.LiteralExpression(SyntaxKind.NumericLiteralExpression, SyntaxFactory.Literal(0));
4344
var modifiedExpression = isPatternExpressionSyntax.WithExpression(newExpression);
4445
Assert.NotNull(modifiedExpression.SyntaxNode);
4546
Assert.NotSame(syntaxNode.Expression, modifiedExpression.Expression);
@@ -54,8 +55,8 @@ public void TestProperties()
5455
var newPattern = SyntaxFactory.ConstantPattern(newExpression);
5556
var modifiedPattern = isPatternExpressionSyntax.WithPattern((PatternSyntaxWrapper)newPattern);
5657
Assert.NotNull(modifiedPattern.SyntaxNode);
57-
Assert.Equal(SyntaxKind.DefaultExpression, modifiedExpression.Expression.Kind());
58-
Assert.Equal(SyntaxKind.NumericLiteralExpression, modifiedPattern.Pattern.SyntaxNode.Kind());
58+
Assert.Equal(SyntaxKind.DefaultExpression, modifiedPattern.Expression.Kind());
59+
Assert.Equal(SyntaxKind.NumericLiteralExpression, ((ConstantPatternSyntax)modifiedPattern.Pattern).Expression.Kind());
5960
}
6061

6162
[Fact]

0 commit comments

Comments
 (0)