Skip to content

Commit 16da6b8

Browse files
committed
Slight refactoring and more test cases for SA1129 code fix
1 parent 292d769 commit 16da6b8

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/ReadabilityRules/SA1129CodeFixProvider.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ private static bool IsEnumWithDefaultMember(INamedTypeSymbol namedTypeSymbol, ou
144144
return false;
145145
}
146146

147-
foundMemberName = foundMembers.Single().Name;
147+
foundMemberName = foundMembers[0].Name;
148148
return true;
149149
}
150150

@@ -155,10 +155,12 @@ private static bool IsEnumWithDefaultMember(INamedTypeSymbol namedTypeSymbol, ou
155155
/// <param name="memberName">The member name.</param>
156156
/// <returns>A new member access expression.</returns>
157157
private static SyntaxNode ConstructMemberAccessSyntax(TypeSyntax typeSyntax, string memberName)
158-
=> SyntaxFactory.MemberAccessExpression(
158+
{
159+
return SyntaxFactory.MemberAccessExpression(
159160
SyntaxKind.SimpleMemberAccessExpression,
160161
typeSyntax,
161162
SyntaxFactory.IdentifierName(memberName));
163+
}
162164

163165
private class FixAll : DocumentBasedFixAllProvider
164166
{

StyleCop.Analyzers/StyleCop.Analyzers.Test/ReadabilityRules/SA1129UnitTests.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -450,6 +450,7 @@ public class TestClass
450450
[InlineData("Member = 0")]
451451
[InlineData("Member = 0, Another = 1")]
452452
[InlineData("Another = 1, Member = 0")]
453+
[InlineData("Member, Another")]
453454
public async Task VerifyEnumMemberReplacementBehaviorAsync(string declarationBody)
454455
{
455456
var testCode = $@"public class TestClass
@@ -491,6 +492,8 @@ private enum MyEnum {{ {declarationBody} }}
491492
[Theory]
492493
[InlineData("Member = 1")]
493494
[InlineData("Member = 1, Another = 2")]
495+
[InlineData("FooMember = 0, BarMember = 0")]
496+
[InlineData("FooMember, BarMember = 0")]
494497
public async Task VerifyEnumMemberDefaultBehaviorAsync(string declarationBody)
495498
{
496499
var testCode = $@"public class TestClass

0 commit comments

Comments
 (0)