Merge pull request #2217 from bjornhellander/Issue2200_SA1118ParameterMustNotSpanMultipleLinesWithNestedConstructor

Updated SA1118 to allow multi-line constructor invocations

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test/ReadabilityRules/SA1118UnitTests.cs

@@ -115,6 +115,32 @@ public void Bar()
             await this.VerifyCSharpDiagnosticAsync(testCode, expected, CancellationToken.None).ConfigureAwait(false);
         }
 
+        [Fact]
+        public async Task TestMethodCallWithTwoParametersSecondSpansMultipleLinesButIsObjectCreationExpressionAsync()
+        {
+            var testCode = @"
+class Foo
+{
+    Foo(int a, int b)
+    {
+    }
+
+    public void FunA(int i, Foo j)
+    {
+    }
+
+    public void FunB()
+    {
+        FunA(1,
+             new Foo(
+                 2,
+                 3));
+    }
+}";
+
+            await this.VerifyCSharpDiagnosticAsync(testCode, EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
+        }
+
         [Fact]
         public async Task TestMethodCallWithTwoParametersFirstIsMultilineSecondIsOneLineAsync()
         {

StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1118ParameterMustNotSpanMultipleLines.cs

@@ -77,7 +77,8 @@ internal class SA1118ParameterMustNotSpanMultipleLines : DiagnosticAnalyzer
             SyntaxKind.AnonymousMethodExpression,
             SyntaxKind.ParenthesizedLambdaExpression,
             SyntaxKind.SimpleLambdaExpression,
-            SyntaxKind.InvocationExpression
+            SyntaxKind.InvocationExpression,
+            SyntaxKind.ObjectCreationExpression
         };
 
         /// <inheritdoc/>

documentation/SA1118.md

@@ -30,6 +30,7 @@ cases:
 * The first parameter may span multiple lines
 * Anonymous methods (including lambda expressions) may span multiple lines
 * Invocation expressions may span multiple lines
+* Object creation expressions may span multiple lines
 
 For example, the following code would violate this rule, since the second parameter spans across multiple lines: