Suppress RS1005 false positives

sharwell · sharwell · commit 1cf7fb812150 · 2020-09-03T12:56:46.000-07:00
See dotnet/roslyn-analyzers#4103
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1612ElementParameterDocumentationMustMatchElementParameters.cs b/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1612ElementParameterDocumentationMustMatchElementParameters.cs
@@ -109,12 +109,14 @@ protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, Styl
 
                     if (parentParameters.Length <= index || parentParameters[index] != parentParameter)
                     {
+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)
                         context.ReportDiagnostic(
                             Diagnostic.Create(
                                 OrderDescriptor,
                                 location,
                                 nameAttributeText,
                                 parentParameters.IndexOf(parentParameter) + 1));
+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor
                     }
                 }
 
@@ -180,12 +182,14 @@ protected override void HandleCompleteDocumentation(SyntaxNodeAnalysisContext co
 
                     if (parentParameters.Length <= index || parentParameters[index] != parentParameter)
                     {
+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)
                         context.ReportDiagnostic(
                             Diagnostic.Create(
                                 OrderDescriptor,
                                 identifierLocation,
                                 nameAttributeText,
                                 parentParameters.IndexOf(parentParameter) + 1));
+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor
                     }
                 }
 
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/OrderingRules/SA1200UsingDirectivesMustBePlacedCorrectly.cs b/StyleCop.Analyzers/StyleCop.Analyzers/OrderingRules/SA1200UsingDirectivesMustBePlacedCorrectly.cs
@@ -261,7 +261,9 @@ private static void HandleNamespaceDeclaration(SyntaxNodeAnalysisContext context
             foreach (UsingDirectiveSyntax directive in syntax.Usings)
             {
                 // Using directive should appear outside a namespace declaration
+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)
                 context.ReportDiagnostic(Diagnostic.Create(DescriptorOutside, directive.GetLocation()));
+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor
             }
         }
     }
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1009ClosingParenthesisMustBeSpacedCorrectly.cs b/StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1009ClosingParenthesisMustBeSpacedCorrectly.cs
@@ -244,13 +244,17 @@ private static void HandleCloseParenToken(SyntaxTreeAnalysisContext context, Syn
                 {
                     // Closing parenthesis should{} be {followed} by a space.
                     var properties = TokenSpacingProperties.InsertFollowing;
+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)
                     context.ReportDiagnostic(Diagnostic.Create(DescriptorFollowed, token.GetLocation(), properties));
+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor
                 }
                 else if (precedesStickyCharacter && followedBySpace && (!lastInLine || !allowEndOfLine))
                 {
                     // Closing parenthesis should{ not} be {followed} by a space.
                     var properties = TokenSpacingProperties.RemoveFollowing;
+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)
                     context.ReportDiagnostic(Diagnostic.Create(DescriptorNotFollowed, token.GetLocation(), properties));
+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor
                 }
             }
         }
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1010OpeningSquareBracketsMustBeSpacedCorrectly.cs b/StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1010OpeningSquareBracketsMustBeSpacedCorrectly.cs
@@ -108,7 +108,9 @@ private static void HandleOpenBracketToken(SyntaxTreeAnalysisContext context, Sy
             if (!lastInLine && followedBySpace)
             {
                 // Opening square bracket should {not be followed} by a space.
+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)
                 context.ReportDiagnostic(Diagnostic.Create(DescriptorNotFollowed, token.GetLocation(), TokenSpacingProperties.RemoveFollowing));
+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor
             }
         }
 
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1015ClosingGenericBracketsMustBeSpacedCorrectly.cs b/StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1015ClosingGenericBracketsMustBeSpacedCorrectly.cs
@@ -156,13 +156,17 @@ private static void HandleGreaterThanToken(SyntaxTreeAnalysisContext context, Sy
                 {
                     // Closing generic bracket should{} be {followed} by a space.
                     var properties = TokenSpacingProperties.InsertFollowing;
+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)
                     context.ReportDiagnostic(Diagnostic.Create(DescriptorFollowed, token.GetLocation(), properties));
+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor
                 }
                 else if (!allowTrailingSpace && followedBySpace)
                 {
                     // Closing generic bracket should{ not} be {followed} by a space.
                     var properties = TokenSpacingProperties.RemoveFollowing;
+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)
                     context.ReportDiagnostic(Diagnostic.Create(DescriptorNotFollowed, token.GetLocation(), properties));
+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor
                 }
             }
         }
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1019MemberAccessSymbolsMustBeSpacedCorrectly.cs b/StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1019MemberAccessSymbolsMustBeSpacedCorrectly.cs
@@ -123,7 +123,9 @@ private static void HandleMemberAccessSymbol(SyntaxTreeAnalysisContext context,
             {
                 // Member access symbol '{.}' should not be {followed} by a space.
                 var properties = TokenSpacingProperties.RemoveFollowing;
+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)
                 context.ReportDiagnostic(Diagnostic.Create(DescriptorNotFollowed, token.GetLocation(), properties, token.Text));
+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor
             }
         }
     }
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1023DereferenceAndAccessOfSymbolsMustBeSpacedCorrectly.cs b/StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1023DereferenceAndAccessOfSymbolsMustBeSpacedCorrectly.cs
@@ -166,7 +166,9 @@ private static void HandleAsteriskToken(SyntaxTreeAnalysisContext context, Synta
             {
                 // Dereference symbol '*' should {not appear at the beginning of a line}.
                 var properties = TokenSpacingProperties.RemovePreceding;
+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)
                 context.ReportDiagnostic(Diagnostic.Create(DescriptorNotAtBeginningOfLine, token.GetLocation(), properties));
+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor
             }
             else if (!allowPrecedingSpace && precededBySpace)
             {
@@ -179,20 +181,26 @@ private static void HandleAsteriskToken(SyntaxTreeAnalysisContext context, Synta
             {
                 // Dereference symbol '*' should {not appear at the end of a line}.
                 var properties = TokenSpacingProperties.RemoveFollowing;
+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)
                 context.ReportDiagnostic(Diagnostic.Create(DescriptorNotAtEndOfLine, token.GetLocation(), properties));
+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor
             }
             else if (!allowTrailingSpace && followedBySpace)
             {
                 // Dereference symbol '*' should {not be followed by a space}.
                 var properties = TokenSpacingProperties.RemoveFollowing;
+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)
                 context.ReportDiagnostic(Diagnostic.Create(DescriptorNotFollowed, token.GetLocation(), properties));
+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor
             }
 
             if (!followedBySpace && allowTrailingSpace)
             {
                 // Dereference symbol '*' should {be followed by a space}.
                 var properties = TokenSpacingProperties.InsertFollowing;
+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)
                 context.ReportDiagnostic(Diagnostic.Create(DescriptorFollowed, token.GetLocation(), properties));
+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor
             }
         }
     }
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1024ColonsMustBeSpacedCorrectly.cs b/StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1024ColonsMustBeSpacedCorrectly.cs
@@ -183,7 +183,9 @@ private static void HandleColonToken(SyntaxTreeAnalysisContext context, SyntaxTo
             if (missingFollowingSpace && checkRequireAfter)
             {
                 // colon should{} be {followed}{} by a space
+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)
                 context.ReportDiagnostic(Diagnostic.Create(DescriptorFollowed, token.GetLocation(), TokenSpacingProperties.InsertFollowing));
+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -109,12 +109,14 @@ protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, Styl`
`109`	`109`
`110`	`110`	`if (parentParameters.Length <= index \|\| parentParameters[index] != parentParameter)`
`111`	`111`	`{`
	`112`	`+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)`
`112`	`113`	`context.ReportDiagnostic(`
`113`	`114`	`Diagnostic.Create(`
`114`	`115`	`OrderDescriptor,`
`115`	`116`	`location,`
`116`	`117`	`nameAttributeText,`
`117`	`118`	`parentParameters.IndexOf(parentParameter) + 1));`
	`119`	`+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor`
`118`	`120`	`}`
`119`	`121`	`}`
`120`	`122`
`@@ -180,12 +182,14 @@ protected override void HandleCompleteDocumentation(SyntaxNodeAnalysisContext co`
`180`	`182`
`181`	`183`	`if (parentParameters.Length <= index \|\| parentParameters[index] != parentParameter)`
`182`	`184`	`{`
	`185`	`+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)`
`183`	`186`	`context.ReportDiagnostic(`
`184`	`187`	`Diagnostic.Create(`
`185`	`188`	`OrderDescriptor,`
`186`	`189`	`identifierLocation,`
`187`	`190`	`nameAttributeText,`
`188`	`191`	`parentParameters.IndexOf(parentParameter) + 1));`
	`192`	`+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor`
`189`	`193`	`}`
`190`	`194`	`}`
`191`	`195`
Original file line number	Diff line number	Diff line change
`@@ -261,7 +261,9 @@ private static void HandleNamespaceDeclaration(SyntaxNodeAnalysisContext context`
`261`	`261`	`foreach (UsingDirectiveSyntax directive in syntax.Usings)`
`262`	`262`	`{`
`263`	`263`	`// Using directive should appear outside a namespace declaration`
	`264`	`+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)`
`264`	`265`	`context.ReportDiagnostic(Diagnostic.Create(DescriptorOutside, directive.GetLocation()));`
	`266`	`+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor`
`265`	`267`	`}`
`266`	`268`	`}`
`267`	`269`	`}`
Original file line number	Diff line number	Diff line change
`@@ -244,13 +244,17 @@ private static void HandleCloseParenToken(SyntaxTreeAnalysisContext context, Syn`
`244`	`244`	`{`
`245`	`245`	`// Closing parenthesis should{} be {followed} by a space.`
`246`	`246`	`var properties = TokenSpacingProperties.InsertFollowing;`
	`247`	`+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)`
`247`	`248`	`context.ReportDiagnostic(Diagnostic.Create(DescriptorFollowed, token.GetLocation(), properties));`
	`249`	`+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor`
`248`	`250`	`}`
`249`	`251`	`else if (precedesStickyCharacter && followedBySpace && (!lastInLine \|\| !allowEndOfLine))`
`250`	`252`	`{`
`251`	`253`	`// Closing parenthesis should{ not} be {followed} by a space.`
`252`	`254`	`var properties = TokenSpacingProperties.RemoveFollowing;`
	`255`	`+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)`
`253`	`256`	`context.ReportDiagnostic(Diagnostic.Create(DescriptorNotFollowed, token.GetLocation(), properties));`
	`257`	`+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor`
`254`	`258`	`}`
`255`	`259`	`}`
`256`	`260`	`}`
Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,9 @@ private static void HandleOpenBracketToken(SyntaxTreeAnalysisContext context, Sy`
`108`	`108`	`if (!lastInLine && followedBySpace)`
`109`	`109`	`{`
`110`	`110`	`// Opening square bracket should {not be followed} by a space.`
	`111`	`+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)`
`111`	`112`	`context.ReportDiagnostic(Diagnostic.Create(DescriptorNotFollowed, token.GetLocation(), TokenSpacingProperties.RemoveFollowing));`
	`113`	`+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor`
`112`	`114`	`}`
`113`	`115`	`}`
`114`	`116`
Original file line number	Diff line number	Diff line change
`@@ -156,13 +156,17 @@ private static void HandleGreaterThanToken(SyntaxTreeAnalysisContext context, Sy`
`156`	`156`	`{`
`157`	`157`	`// Closing generic bracket should{} be {followed} by a space.`
`158`	`158`	`var properties = TokenSpacingProperties.InsertFollowing;`
	`159`	`+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)`
`159`	`160`	`context.ReportDiagnostic(Diagnostic.Create(DescriptorFollowed, token.GetLocation(), properties));`
	`161`	`+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor`
`160`	`162`	`}`
`161`	`163`	`else if (!allowTrailingSpace && followedBySpace)`
`162`	`164`	`{`
`163`	`165`	`// Closing generic bracket should{ not} be {followed} by a space.`
`164`	`166`	`var properties = TokenSpacingProperties.RemoveFollowing;`
	`167`	`+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)`
`165`	`168`	`context.ReportDiagnostic(Diagnostic.Create(DescriptorNotFollowed, token.GetLocation(), properties));`
	`169`	`+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor`
`166`	`170`	`}`
`167`	`171`	`}`
`168`	`172`	`}`
Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,9 @@ private static void HandleMemberAccessSymbol(SyntaxTreeAnalysisContext context,`
`123`	`123`	`{`
`124`	`124`	`// Member access symbol '{.}' should not be {followed} by a space.`
`125`	`125`	`var properties = TokenSpacingProperties.RemoveFollowing;`
	`126`	`+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)`
`126`	`127`	`context.ReportDiagnostic(Diagnostic.Create(DescriptorNotFollowed, token.GetLocation(), properties, token.Text));`
	`128`	`+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor`
`127`	`129`	`}`
`128`	`130`	`}`
`129`	`131`	`}`
Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,9 @@ private static void HandleAsteriskToken(SyntaxTreeAnalysisContext context, Synta`
`166`	`166`	`{`
`167`	`167`	`// Dereference symbol '*' should {not appear at the beginning of a line}.`
`168`	`168`	`var properties = TokenSpacingProperties.RemovePreceding;`
	`169`	`+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)`
`169`	`170`	`context.ReportDiagnostic(Diagnostic.Create(DescriptorNotAtBeginningOfLine, token.GetLocation(), properties));`
	`171`	`+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor`
`170`	`172`	`}`
`171`	`173`	`else if (!allowPrecedingSpace && precededBySpace)`
`172`	`174`	`{`
`@@ -179,20 +181,26 @@ private static void HandleAsteriskToken(SyntaxTreeAnalysisContext context, Synta`
`179`	`181`	`{`
`180`	`182`	`// Dereference symbol '*' should {not appear at the end of a line}.`
`181`	`183`	`var properties = TokenSpacingProperties.RemoveFollowing;`
	`184`	`+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)`
`182`	`185`	`context.ReportDiagnostic(Diagnostic.Create(DescriptorNotAtEndOfLine, token.GetLocation(), properties));`
	`186`	`+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor`
`183`	`187`	`}`
`184`	`188`	`else if (!allowTrailingSpace && followedBySpace)`
`185`	`189`	`{`
`186`	`190`	`// Dereference symbol '*' should {not be followed by a space}.`
`187`	`191`	`var properties = TokenSpacingProperties.RemoveFollowing;`
	`192`	`+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)`
`188`	`193`	`context.ReportDiagnostic(Diagnostic.Create(DescriptorNotFollowed, token.GetLocation(), properties));`
	`194`	`+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor`
`189`	`195`	`}`
`190`	`196`
`191`	`197`	`if (!followedBySpace && allowTrailingSpace)`
`192`	`198`	`{`
`193`	`199`	`// Dereference symbol '*' should {be followed by a space}.`
`194`	`200`	`var properties = TokenSpacingProperties.InsertFollowing;`
	`201`	`+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)`
`195`	`202`	`context.ReportDiagnostic(Diagnostic.Create(DescriptorFollowed, token.GetLocation(), properties));`
	`203`	`+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor`
`196`	`204`	`}`
`197`	`205`	`}`
`198`	`206`	`}`
Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,9 @@ private static void HandleColonToken(SyntaxTreeAnalysisContext context, SyntaxTo`
`183`	`183`	`if (missingFollowingSpace && checkRequireAfter)`
`184`	`184`	`{`
`185`	`185`	`// colon should{} be {followed}{} by a space`
	`186`	`+#pragma warning disable RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor (https://github.com/dotnet/roslyn-analyzers/issues/4103)`
`186`	`187`	`context.ReportDiagnostic(Diagnostic.Create(DescriptorFollowed, token.GetLocation(), TokenSpacingProperties.InsertFollowing));`
	`188`	`+#pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor`
`187`	`189`	`}`
`188`	`190`	`}`
`189`	`191`	`}`