Fix that SA1003 does not allow postfix unary expressions as last elements in an anonymous object creation or initializers

Author: pdelvo

StyleCop.Analyzers/StyleCop.Analyzers.Test/SpacingRules/SA1003UnitTests.cs

@@ -52,6 +52,24 @@ public void Bar()
         var v9_2 = v4[v1++];
         var v9_3 = $""{v1++}"";
         var v9_4 = v1++;
+        var v9_5 = new
+        {
+            Property = v1++
+        };
+        var v9_6 = new
+        {
+            Property = v1--
+        };
+        var v9_7 = new int[]
+        {
+            v1++,
+            v1++
+        };
+        var v9_8 = new int[]
+        {
+            v1--,
+            v1--
+        };
     }
 }
 ";
@@ -84,6 +102,29 @@ public void Bar()
         var v6 = new[] { 1, 2, 3 };
         var v7 = ( (byte)v1 == 0);
         var v8 = v6[ ~v1];
+
+        var v9_1 = new
+        {
+            Property = v1++
+,
+        };
+        var v9_2 = new
+        {
+            Property = v1--
+,
+        };
+        var v9_3 = new int[]
+        {
+            v1++,
+            v1++
+,
+        };
+        var v9_4 = new int[]
+        {
+            v1--,
+            v1--
+,
+        };
     }
 }
 ";
@@ -106,6 +147,25 @@ public void Bar()
         var v6 = new[] { 1, 2, 3 };
         var v7 = ((byte)v1 == 0);
         var v8 = v6[~v1];
+
+        var v9_1 = new
+        {
+            Property = v1++,
+        };
+        var v9_2 = new
+        {
+            Property = v1--,
+        };
+        var v9_3 = new int[]
+        {
+            v1++,
+            v1++,
+        };
+        var v9_4 = new int[]
+        {
+            v1--,
+            v1--,
+        };
     }
 }
 ";
@@ -116,7 +176,11 @@ public void Bar()
                 this.CSharpDiagnostic(DescriptorNotFollowedByComment).WithLocation(13, 18).WithArguments("~"),
                 this.CSharpDiagnostic(DescriptorNotFollowedByComment).WithLocation(15, 18).WithArguments("~"),
                 this.CSharpDiagnostic(DescriptorNotPrecededByWhitespace).WithLocation(17, 20).WithArguments("(byte)"),
-                this.CSharpDiagnostic(DescriptorNotPrecededByWhitespace).WithLocation(18, 22).WithArguments("~")
+                this.CSharpDiagnostic(DescriptorNotPrecededByWhitespace).WithLocation(18, 22).WithArguments("~"),
+                this.CSharpDiagnostic(DescriptorNotAtEndOfLine).WithLocation(22, 26).WithArguments("++"),
+                this.CSharpDiagnostic(DescriptorNotAtEndOfLine).WithLocation(27, 26).WithArguments("--"),
+                this.CSharpDiagnostic(DescriptorNotAtEndOfLine).WithLocation(33, 15).WithArguments("++"),
+                this.CSharpDiagnostic(DescriptorNotAtEndOfLine).WithLocation(39, 15).WithArguments("--")
             };
 
             DiagnosticResult[] fixedExpected =

StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1003SymbolsMustBeSpacedCorrectly.cs

@@ -238,7 +238,11 @@ private static void HandlePostfixUnaryExpression(SyntaxNodeAnalysisContext conte
                 && !followingToken.IsKind(SyntaxKind.CommaToken)
                 && !(followingToken.IsKind(SyntaxKind.CloseBraceToken) && (followingToken.Parent is InterpolationSyntax));
 
-            CheckToken(context, unaryExpression.OperatorToken, false, false, mustHaveTrailingWhitespace);
+            // If the next token is a close brace token we are in an anonymous object creation or an initialization.
+            // Then we allow a new line
+            bool allowEndOfLine = followingToken.IsKind(SyntaxKind.CloseBraceToken);
+
+            CheckToken(context, unaryExpression.OperatorToken, false, allowEndOfLine, mustHaveTrailingWhitespace);
         }
 
         private static void HandleAssignmentExpression(SyntaxNodeAnalysisContext context)