Add NamingSettings to StyleCopSettings

Author: Noryoko

StyleCop.Analyzers/StyleCop.Analyzers.Test/Settings/SettingsUnitTests.cs

@@ -25,6 +25,8 @@ public void VerifySettingsDefaults()
 
             Assert.Equal("PlaceholderCompany", styleCopSettings.DocumentationRules.CompanyName);
             Assert.Equal("Copyright (c) PlaceholderCompany. All rights reserved.", styleCopSettings.DocumentationRules.CopyrightText);
+            Assert.True(styleCopSettings.NamingRules.AllowCommonHungarianPrefixes);
+            Assert.Equal(0, styleCopSettings.NamingRules.AllowedHungarianPrefixes.Length);
         }
 
         /// <summary>
@@ -40,6 +42,10 @@ public async Task VerifySettingsAreReadCorrectlyAsync()
     ""documentationRules"": {
       ""companyName"": ""TestCompany"",
       ""copyrightText"": ""Custom copyright text.""
+    },
+    ""namingRules"": {
+        ""allowCommonHungarianPrefixes"": false,
+        ""allowedHungarianPrefixes"": [""a"", ""ab""]
     }
   }
 }
@@ -50,6 +56,8 @@ public async Task VerifySettingsAreReadCorrectlyAsync()
 
             Assert.Equal("TestCompany", styleCopSettings.DocumentationRules.CompanyName);
             Assert.Equal("Custom copyright text.", styleCopSettings.DocumentationRules.CopyrightText);
+            Assert.False(styleCopSettings.NamingRules.AllowCommonHungarianPrefixes);
+            Assert.Equal(new[] { "a", "ab" }, styleCopSettings.NamingRules.AllowedHungarianPrefixes);
         }
 
         /// <summary>

StyleCop.Analyzers/StyleCop.Analyzers/Settings/ObjectModel/NamingSettings.cs

@@ -0,0 +1,45 @@
+// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
+// Licensed under the Apache License, Version 2.0. See LICENSE in the project root for license information.
+
+namespace StyleCop.Analyzers.Settings.ObjectModel
+{
+    using System.Collections.Immutable;
+    using Newtonsoft.Json;
+
+    [JsonObject(MemberSerialization.OptIn)]
+    internal class NamingSettings
+    {
+        /// <summary>
+        /// This is the backing field for the <see cref="AllowCommonHungarianPrefixes"/> property.
+        /// </summary>
+        [JsonProperty("allowCommonHungarianPrefixes", DefaultValueHandling = DefaultValueHandling.Include)]
+        private bool allowCommonHungarianPrefixes;
+
+        /// <summary>
+        /// This is the backing field for the <see cref="AllowedHungarianPrefixes"/> property.
+        /// </summary>
+        [JsonProperty("allowedHungarianPrefixes", DefaultValueHandling = DefaultValueHandling.Ignore)]
+        private ImmutableArray<string>.Builder allowedHungarianPrefixes;
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="NamingSettings"/> class during JSON deserialization.
+        /// </summary>
+        [JsonConstructor]
+        protected internal NamingSettings()
+        {
+            this.allowCommonHungarianPrefixes = true;
+            this.allowedHungarianPrefixes = ImmutableArray<string>.Empty.ToBuilder();
+        }
+
+        public bool AllowCommonHungarianPrefixes =>
+            this.allowCommonHungarianPrefixes;
+
+        public ImmutableArray<string> AllowedHungarianPrefixes
+        {
+            get
+            {
+                return this.allowedHungarianPrefixes.ToImmutable();
+            }
+        }
+    }
+}

StyleCop.Analyzers/StyleCop.Analyzers/Settings/ObjectModel/StyleCopSettings.cs

@@ -14,13 +14,20 @@ internal class StyleCopSettings
         [JsonProperty("documentationRules", DefaultValueHandling = DefaultValueHandling.Ignore)]
         private DocumentationSettings documentationRules;
 
+        /// <summary>
+        /// This is the backing field for the <see cref="NamingRules"/> property.
+        /// </summary>
+        [JsonProperty("namingRules", DefaultValueHandling = DefaultValueHandling.Ignore)]
+        private NamingSettings namingRules;
+
         /// <summary>
         /// Initializes a new instance of the <see cref="StyleCopSettings"/> class during JSON deserialization.
         /// </summary>
         [JsonConstructor]
         protected internal StyleCopSettings()
         {
             this.documentationRules = new DocumentationSettings();
+            this.namingRules = new NamingSettings();
         }
 
         public DocumentationSettings DocumentationRules
@@ -30,5 +37,13 @@ public DocumentationSettings DocumentationRules
                 return this.documentationRules;
             }
         }
+
+        public NamingSettings NamingRules
+        {
+            get
+            {
+                return this.namingRules;
+            }
+        }
     }
 }

StyleCop.Analyzers/StyleCop.Analyzers/Settings/stylecop.schema.json

@@ -80,6 +80,7 @@
               "default": [ ],
               "items": {
                 "type": "string",
+                "pattern": "^[a-z]{1,2}$",
                 "uniqueItems": true
               }
             }

StyleCop.Analyzers/StyleCop.Analyzers/StyleCop.Analyzers.csproj

@@ -330,6 +330,7 @@
     <Compile Include="ReadabilityRules\SA1133DoNotCombineAttributes.cs" />
     <Compile Include="ReadabilityRules\SA1134AttributesMustNotShareLine.cs" />
     <Compile Include="Settings\ObjectModel\DocumentationSettings.cs" />
+    <Compile Include="Settings\ObjectModel\NamingSettings.cs" />
     <Compile Include="Settings\ObjectModel\SettingsFile.cs" />
     <Compile Include="Settings\ObjectModel\StyleCopSettings.cs" />
     <Compile Include="Settings\SettingsFileCodeFixProvider.cs" />