Update SA1300 for static local functions

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp7/NamingRules/SA1300CSharp7UnitTests.cs

@@ -1,8 +1,6 @@
 // Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
 // Licensed under the MIT License. See LICENSE in the project root for license information.
 
-#nullable disable
-
 namespace StyleCop.Analyzers.Test.CSharp7.NamingRules
 {
     using System.Threading;
@@ -16,30 +14,14 @@ namespace StyleCop.Analyzers.Test.CSharp7.NamingRules
 
     public partial class SA1300CSharp7UnitTests : SA1300UnitTests
     {
-        [Fact]
-        public async Task TestUpperCaseLocalFunctionAsync()
-        {
-            var testCode = @"public class TestClass
-{
-    public void Method()
-    {
-        void LocalFunction()
-        {
-        }
-    }
-}";
-
-            await VerifyCSharpDiagnosticAsync(testCode, DiagnosticResult.EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
-        }
-
         [Fact]
         public async Task TestLowerCaseLocalFunctionAsync()
         {
             var testCode = @"public class TestClass
 {
     public void Method()
     {
-        void localFunction()
+        void {|#0:localFunction|}()
         {
         }
     }
@@ -54,7 +36,7 @@ void LocalFunction()
     }
 }";
 
-            DiagnosticResult expected = Diagnostic().WithArguments("localFunction").WithLocation(5, 14);
+            DiagnosticResult expected = Diagnostic().WithArguments("localFunction").WithLocation(0);
             await VerifyCSharpFixAsync(testCode, expected, fixedCode, CancellationToken.None).ConfigureAwait(false);
         }
 
@@ -66,7 +48,7 @@ public async Task TestLowerCaseLocalFunctionWithConflictAsync()
 {
     public void Method()
     {
-        void localFunction()
+        void {|#0:localFunction|}()
         {
         }
 
@@ -85,7 +67,7 @@ void LocalFunction1()
     }
 }";
 
-            DiagnosticResult expected = Diagnostic().WithArguments("localFunction").WithLocation(5, 14);
+            DiagnosticResult expected = Diagnostic().WithArguments("localFunction").WithLocation(0);
             await VerifyCSharpFixAsync(testCode, expected, fixedCode, CancellationToken.None).ConfigureAwait(false);
         }
     }

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp8/NamingRules/SA1300CSharp8UnitTests.cs

@@ -3,9 +3,42 @@
 
 namespace StyleCop.Analyzers.Test.CSharp8.NamingRules
 {
+    using System.Threading;
+    using System.Threading.Tasks;
+    using Microsoft.CodeAnalysis.Testing;
     using StyleCop.Analyzers.Test.CSharp7.NamingRules;
+    using Xunit;
+    using static StyleCop.Analyzers.Test.Verifiers.StyleCopCodeFixVerifier<
+        StyleCop.Analyzers.NamingRules.SA1300ElementMustBeginWithUpperCaseLetter,
+        StyleCop.Analyzers.NamingRules.RenameToUpperCaseCodeFixProvider>;
 
     public partial class SA1300CSharp8UnitTests : SA1300CSharp7UnitTests
     {
+        [Fact]
+        [WorkItem(3005, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3005")]
+        public async Task TestLowerCaseStaticLocalFunctionAsync()
+        {
+            var testCode = @"public class TestClass
+{
+    public void Method()
+    {
+        static void {|#0:localFunction|}()
+        {
+        }
+    }
+}";
+            var fixedCode = @"public class TestClass
+{
+    public void Method()
+    {
+        static void LocalFunction()
+        {
+        }
+    }
+}";
+
+            DiagnosticResult expected = Diagnostic().WithArguments("localFunction").WithLocation(0);
+            await VerifyCSharpFixAsync(testCode, expected, fixedCode, CancellationToken.None).ConfigureAwait(false);
+        }
     }
 }

documentation/SA1300.md

@@ -33,6 +33,7 @@ following types of elements should use an upper-case letter as the first letter
 * Events
 * Methods
 * Properties
+* Local functions (including static local functions)
 
 In addition, any field which is public, internal, or marked with the const attribute should begin with an upper-case
 letter. Non-private readonly fields should also be named using an upper-case letter.