Implement CR feedback

pdelvo · pdelvo · commit 2febf0b7fa09 · 2015-09-21T12:01:11.000+02:00
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1642SA1643CodeFixProvider.cs b/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1642SA1643CodeFixProvider.cs
@@ -54,7 +54,7 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
                     continue;
                 }
 
-                var node = root.FindNode(diagnostic.Location.SourceSpan, findInsideTrivia: true) as XmlNodeSyntax;
+                var node = root.FindNode(diagnostic.Location.SourceSpan, findInsideTrivia: true, getInnermostNodeForTie: true);
 
                 var xmlElementSyntax = node as XmlElementSyntax;
 
@@ -64,7 +64,7 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
                 }
                 else
                 {
-                    var xmlEmptyElementSyntax = node as XmlEmptyElementSyntax;
+                    var xmlEmptyElementSyntax = (XmlEmptyElementSyntax)node;
                     context.RegisterCodeFix(CodeAction.Create(DocumentationResources.SA1642SA1643CodeFix, token => GetTransformedDocumentAsync(context.Document, root, xmlEmptyElementSyntax), equivalenceKey: nameof(SA1642SA1643CodeFixProvider)), diagnostic);
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)`
`54`	`54`	`continue;`
`55`	`55`	`}`
`56`	`56`
`57`		`- var node = root.FindNode(diagnostic.Location.SourceSpan, findInsideTrivia: true) as XmlNodeSyntax;`
	`57`	`+ var node = root.FindNode(diagnostic.Location.SourceSpan, findInsideTrivia: true, getInnermostNodeForTie: true);`
`58`	`58`
`59`	`59`	`var xmlElementSyntax = node as XmlElementSyntax;`
`60`	`60`
`@@ -64,7 +64,7 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)`
`64`	`64`	`}`
`65`	`65`	`else`
`66`	`66`	`{`
`67`		`- var xmlEmptyElementSyntax = node as XmlEmptyElementSyntax;`
	`67`	`+ var xmlEmptyElementSyntax = (XmlEmptyElementSyntax)node;`
`68`	`68`	`context.RegisterCodeFix(CodeAction.Create(DocumentationResources.SA1642SA1643CodeFix, token => GetTransformedDocumentAsync(context.Document, root, xmlEmptyElementSyntax), equivalenceKey: nameof(SA1642SA1643CodeFixProvider)), diagnostic);`
`69`	`69`	`}`
`70`	`70`	`}`