Simplify documentation inheritation check in ElementDocumentationBase

angelobreuer · sharwell · web-flow · commit 3b590953084e · 2020-07-23T21:14:33.000+02:00
Co-authored-by: Sam Harwell &lt;sam@tunnelvisionlabs.com&gt;
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/ElementDocumentationBase.cs b/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/ElementDocumentationBase.cs
@@ -235,8 +235,8 @@ private void HandleDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettin
                     .Where(x => !string.Equals(x.GetName()?.ToString(), XmlCommentHelper.IncludeXmlTag, StringComparison.Ordinal))
                 : documentation.Content.GetXmlElements(this.matchElementName);
 
-            var isInheritingDocumentation = documentation.Content
-                .Any(x => string.Equals(x.GetName()?.ToString(), XmlCommentHelper.IncludeXmlTag, StringComparison.Ordinal));
+            var isInheritingDocumentation =
+                documentation.Content.GetFirstXmlElement(XmlCommentHelper.IncludeXmlTag) is object;
 
             if (isInheritingDocumentation)
             {

Original file line number	Diff line number	Diff line change
`@@ -235,8 +235,8 @@ private void HandleDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettin`
`235`	`235`	`.Where(x => !string.Equals(x.GetName()?.ToString(), XmlCommentHelper.IncludeXmlTag, StringComparison.Ordinal))`
`236`	`236`	`: documentation.Content.GetXmlElements(this.matchElementName);`
`237`	`237`
`238`		`- var isInheritingDocumentation = documentation.Content`
`239`		`- .Any(x => string.Equals(x.GetName()?.ToString(), XmlCommentHelper.IncludeXmlTag, StringComparison.Ordinal));`
	`238`	`+ var isInheritingDocumentation =`
	`239`	`+ documentation.Content.GetFirstXmlElement(XmlCommentHelper.IncludeXmlTag) is object;`
`240`	`240`
`241`	`241`	`if (isInheritingDocumentation)`
`242`	`242`	`{`