Add tests for AddArguments and AddElements

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp7/Lightup/TupleExpressionSyntaxWrapperTests.cs

@@ -27,6 +27,7 @@ public void TestNull()
                 ImmutableArray.Create(
                     SyntaxFactory.Argument(SyntaxFactory.LiteralExpression(SyntaxKind.TrueLiteralExpression)),
                     SyntaxFactory.Argument(SyntaxFactory.LiteralExpression(SyntaxKind.FalseLiteralExpression))))));
+            Assert.Throws<NullReferenceException>(() => wrapper.AddArguments());
             Assert.Throws<NullReferenceException>(() => wrapper.WithCloseParenToken(SyntaxFactory.Token(SyntaxKind.CloseParenToken)));
         }
 
@@ -55,6 +56,12 @@ public void TestProperties()
             Assert.NotSame(syntaxNode.Arguments[0], wrapperWithModifiedArguments.Arguments[0]);
             Assert.Equal(SyntaxKind.NullLiteralExpression, wrapperWithModifiedArguments.Arguments[0].Expression.Kind());
 
+            var wrapperWithAddedArguments = wrapper.AddArguments(SyntaxFactory.Argument(SyntaxFactory.LiteralExpression(SyntaxKind.NumericLiteralExpression, SyntaxFactory.Literal(42))));
+            Assert.NotNull(wrapperWithAddedArguments.SyntaxNode);
+            Assert.Equal(wrapper.Arguments.Count + 1, wrapperWithAddedArguments.Arguments.Count);
+            Assert.Equal(SyntaxKind.NumericLiteralExpression, wrapperWithAddedArguments.Arguments.Last().Expression.Kind());
+            Assert.Equal("42", wrapperWithAddedArguments.Arguments.Last().ToString());
+
             var newCloseParenToken = SyntaxFactory.Token(SyntaxKind.CloseParenToken).WithLeadingTrivia(SyntaxFactory.Space);
             var wrapperWithModifiedCloseParenToken = wrapper.WithCloseParenToken(newCloseParenToken);
             Assert.NotNull(wrapperWithModifiedCloseParenToken.SyntaxNode);

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp7/Lightup/TupleTypeSyntaxWrapperTests.cs

@@ -24,6 +24,7 @@ public void TestNull()
             Assert.Throws<NullReferenceException>(() => wrapper.CloseParenToken);
             Assert.Throws<NullReferenceException>(() => wrapper.WithOpenParenToken(SyntaxFactory.Token(SyntaxKind.OpenParenToken)));
             Assert.Throws<NullReferenceException>(() => wrapper.WithElements(SeparatedSyntaxListWrapper<TupleElementSyntaxWrapper>.UnsupportedEmpty));
+            Assert.Throws<NullReferenceException>(() => wrapper.AddElements());
             Assert.Throws<NullReferenceException>(() => wrapper.WithCloseParenToken(SyntaxFactory.Token(SyntaxKind.CloseParenToken)));
         }
 
@@ -52,6 +53,12 @@ public void TestProperties()
             Assert.NotSame(syntaxNode.Elements[0], wrapperWithModifiedElements.Elements[0]);
             Assert.Equal(SyntaxKind.StringKeyword, ((PredefinedTypeSyntax)wrapperWithModifiedElements.Elements[0].Type).Keyword.Kind());
 
+            var wrapperWithAddedElements = wrapper.AddElements((TupleElementSyntaxWrapper)SyntaxFactory.TupleElement(SyntaxFactory.PredefinedType(SyntaxFactory.Token(SyntaxKind.ShortKeyword))));
+            Assert.NotNull(wrapperWithAddedElements.SyntaxNode);
+            Assert.Equal(wrapper.Elements.Count + 1, wrapperWithAddedElements.Elements.Count);
+            Assert.Equal(SyntaxKind.PredefinedType, wrapperWithAddedElements.Elements.Last().Type.Kind());
+            Assert.Equal(SyntaxKind.ShortKeyword, ((PredefinedTypeSyntax)wrapperWithAddedElements.Elements.Last().Type).Keyword.Kind());
+
             var newCloseParenToken = SyntaxFactory.Token(SyntaxKind.CloseParenToken).WithLeadingTrivia(SyntaxFactory.Space);
             var wrapperWithModifiedCloseParenToken = wrapper.WithCloseParenToken(newCloseParenToken);
             Assert.NotNull(wrapperWithModifiedCloseParenToken.SyntaxNode);

StyleCop.Analyzers/StyleCop.Analyzers.Test/Lightup/TupleExpressionSyntaxWrapperTests.cs

@@ -27,6 +27,7 @@ public void TestNull()
                 ImmutableArray.Create(
                     SyntaxFactory.Argument(SyntaxFactory.LiteralExpression(SyntaxKind.TrueLiteralExpression)),
                     SyntaxFactory.Argument(SyntaxFactory.LiteralExpression(SyntaxKind.FalseLiteralExpression))))));
+            Assert.Throws<NullReferenceException>(() => wrapper.AddArguments());
             Assert.Throws<NullReferenceException>(() => wrapper.WithCloseParenToken(SyntaxFactory.Token(SyntaxKind.CloseParenToken)));
         }
 

StyleCop.Analyzers/StyleCop.Analyzers.Test/Lightup/TupleTypeSyntaxWrapperTests.cs

@@ -23,6 +23,7 @@ public void TestNull()
             Assert.Throws<NullReferenceException>(() => wrapper.CloseParenToken);
             Assert.Throws<NullReferenceException>(() => wrapper.WithOpenParenToken(SyntaxFactory.Token(SyntaxKind.OpenParenToken)));
             Assert.Throws<NullReferenceException>(() => wrapper.WithElements(SeparatedSyntaxListWrapper<TupleElementSyntaxWrapper>.UnsupportedEmpty));
+            Assert.Throws<NullReferenceException>(() => wrapper.AddElements());
             Assert.Throws<NullReferenceException>(() => wrapper.WithCloseParenToken(SyntaxFactory.Token(SyntaxKind.CloseParenToken)));
         }
 

StyleCop.Analyzers/StyleCop.Analyzers/Lightup/SeparatedSyntaxListWrapper`1.cs

@@ -66,9 +66,7 @@ public abstract TNode this[int index]
         //   node:
         //     The node to add.
         public SeparatedSyntaxListWrapper<TNode> Add(TNode node)
-        {
-            throw new NotImplementedException();
-        }
+            => this.Insert(this.Count, node);
 
         // Summary:
         //     Creates a new list with the specified nodes added to the end.
@@ -77,9 +75,7 @@ public SeparatedSyntaxListWrapper<TNode> Add(TNode node)
         //   nodes:
         //     The nodes to add.
         public SeparatedSyntaxListWrapper<TNode> AddRange(IEnumerable<TNode> nodes)
-        {
-            throw new NotImplementedException();
-        }
+            => this.InsertRange(this.Count, nodes);
 
         public abstract bool Any();