Merge pull request #2559 from dlemstra/fix-2534

Fixed false report for named tuple elements.

Author: vweijsters

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp7/ReadabilityRules/SA1101CSharp7UnitTests.cs

@@ -3,9 +3,31 @@
 
 namespace StyleCop.Analyzers.Test.CSharp7.ReadabilityRules
 {
+    using System.Threading;
+    using System.Threading.Tasks;
     using StyleCop.Analyzers.Test.ReadabilityRules;
+    using Xunit;
 
     public class SA1101CSharp7UnitTests : SA1101UnitTests
     {
+        /// <summary>
+        /// Verifies that a value tuple is handled properly.
+        /// </summary>
+        /// <returns>A <see cref="Task"/> representing the asynchronous unit test.</returns>
+        [Fact]
+        [WorkItem(2534, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/2534")]
+        public async Task TestValueTupleAsync()
+        {
+            var testCode = @"public class Foo
+{
+    protected (bool a, bool b) Bar()
+    {
+        return (a: true, b: false);
+    }
+}
+";
+
+            await this.VerifyCSharpDiagnosticAsync(testCode, EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
+        }
     }
 }

StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1101PrefixLocalCallsWithThis.cs

@@ -83,6 +83,8 @@ private static void HandleSimpleName(SyntaxNodeAnalysisContext context)
                 // this is handled separately
                 return;
 
+            case SyntaxKind.MemberBindingExpression:
+            case SyntaxKind.NameColon:
             case SyntaxKind.PointerMemberAccessExpression:
                 // this doesn't need to be handled
                 return;
@@ -122,10 +124,6 @@ private static void HandleSimpleName(SyntaxNodeAnalysisContext context)
 
                 break;
 
-            case SyntaxKind.MemberBindingExpression:
-                // this doesn't need to be handled
-                return;
-
             default:
                 break;
             }