Refactor and clean up SA1614

Author: nbarbettini

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1614ElementParameterDocumentationMustHaveText.cs

@@ -55,47 +55,32 @@ public SA1614ElementParameterDocumentationMustHaveText()
         /// <inheritdoc/>
         protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, IEnumerable<XmlNodeSyntax> syntaxList, params Location[] diagnosticLocations)
         {
-            var xmlParameterNames = syntaxList
-                .Where(x => string.Equals(x.GetName()?.ToString(), XmlCommentHelper.ParamXmlTag))
-                .Select(x =>
-                {
-                    bool isEmpty = x is XmlEmptyElementSyntax || XmlCommentHelper.IsConsideredEmpty(x);
-                    var location = x.GetLocation();
-
-                    return new Tuple<bool, Location>(isEmpty, location);
-                })
-                .ToImmutableArray();
+            foreach (var syntax in syntaxList)
+            {
+                bool isEmpty = syntax is XmlEmptyElementSyntax || XmlCommentHelper.IsConsideredEmpty(syntax);
 
-            VerifyParameters(context, xmlParameterNames, diagnosticLocations.First());
+                if (isEmpty)
+                {
+                    context.ReportDiagnostic(Diagnostic.Create(Descriptor, syntax.GetLocation()));
+                }
+            }
         }
 
         /// <inheritdoc/>
         protected override void HandleCompleteDocumentation(SyntaxNodeAnalysisContext context, XElement completeDocumentation, params Location[] diagnosticLocations)
         {
-            var xmlParameterNames = completeDocumentation.Nodes()
+            var xmlParamTags = completeDocumentation.Nodes()
                 .OfType<XElement>()
-                .Where(e => e.Name == XmlCommentHelper.ParamXmlTag)
-                .Select(x =>
-                {
-                    return new Tuple<bool, Location>(XmlCommentHelper.IsConsideredEmpty(x), null);
-                })
-                .ToImmutableArray();
+                .Where(e => e.Name == XmlCommentHelper.ParamXmlTag);
 
-            VerifyParameters(context, xmlParameterNames, diagnosticLocations.First());
-        }
-
-        private static void VerifyParameters(SyntaxNodeAnalysisContext context, ImmutableArray<Tuple<bool, Location>> documentationParameters, Location identifierLocation)
-        {
-            var index = 0;
-
-            foreach (var documentedParameter in documentationParameters)
+            foreach (var paramTag in xmlParamTags)
             {
-                if (documentedParameter.Item1)
+                bool isEmpty = XmlCommentHelper.IsConsideredEmpty(paramTag);
+
+                if (isEmpty)
                 {
-                    context.ReportDiagnostic(Diagnostic.Create(Descriptor, documentedParameter.Item2 ?? identifierLocation));
+                    context.ReportDiagnostic(Diagnostic.Create(Descriptor, diagnosticLocations.First()));
                 }
-
-                index++;
             }
         }
     }