Merge pull request #3908 from bjornhellander/feature/csharp13-test-nuget-update

Update the code analysis nuget in the c# 13 test project to the official 4.12.0 version

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp13/LayoutRules/SA1504CSharp13UnitTests.cs

@@ -3,9 +3,17 @@
 
 namespace StyleCop.Analyzers.Test.CSharp13.LayoutRules
 {
+    using Microsoft.CodeAnalysis.Testing;
     using StyleCop.Analyzers.Test.CSharp12.LayoutRules;
 
     public partial class SA1504CSharp13UnitTests : SA1504CSharp12UnitTests
     {
+        protected override DiagnosticResult[] GetExpectedResultAccessorWithoutBody()
+        {
+            return new DiagnosticResult[]
+            {
+                DiagnosticResult.CompilerError("CS8652").WithMessage("The feature 'field keyword' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version.").WithLocation(4, 16),
+            };
+        }
     }
 }

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp13/StyleCop.Analyzers.Test.CSharp13.csproj

@@ -18,7 +18,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.12.0-1.24376.3" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.12.0" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.1" PrivateAssets="all" />
   </ItemGroup>

StyleCop.Analyzers/StyleCop.Analyzers.Test/LayoutRules/SA1504UnitTests.cs

@@ -303,11 +303,8 @@ public int Prop
         }
     }
 }";
-            DiagnosticResult[] expected =
-            {
-                DiagnosticResult.CompilerError("CS0501").WithMessage("'Foo.Prop.get' must declare a body because it is not marked abstract, extern, or partial").WithLocation(6, 9),
-            };
 
+            var expected = this.GetExpectedResultAccessorWithoutBody();
             await VerifyCSharpDiagnosticAsync(testCode, expected, CancellationToken.None).ConfigureAwait(false);
         }
 
@@ -387,5 +384,13 @@ public int Prop
                 CodeActionIndex = 1,
             }.RunAsync(CancellationToken.None).ConfigureAwait(false);
         }
+
+        protected virtual DiagnosticResult[] GetExpectedResultAccessorWithoutBody()
+        {
+            return new DiagnosticResult[]
+            {
+                DiagnosticResult.CompilerError("CS0501").WithMessage("'Foo.Prop.get' must declare a body because it is not marked abstract, extern, or partial").WithLocation(6, 9),
+            };
+        }
     }
 }