Skip to content

Commit 49d59ce

Browse files
committed
Move up and use declaredSymbol
1 parent 62237f3 commit 49d59ce

1 file changed

Lines changed: 11 additions & 12 deletions

File tree

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1648InheritDocMustBeUsedWithInheritingClass.cs

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -147,21 +147,10 @@ private static void HandleMemberDeclaration(SyntaxNodeAnalysisContext context)
147147
Location location;
148148

149149
ISymbol declaredSymbol = context.SemanticModel.GetDeclaredSymbol(memberSyntax, context.CancellationToken);
150-
if (declaredSymbol == null && memberSyntax.IsKind(SyntaxKind.EventFieldDeclaration))
151-
{
152-
var eventFieldDeclarationSyntax = (EventFieldDeclarationSyntax)memberSyntax;
153-
VariableDeclaratorSyntax firstVariable = eventFieldDeclarationSyntax.Declaration?.Variables.FirstOrDefault();
154-
if (firstVariable != null)
155-
{
156-
declaredSymbol = context.SemanticModel.GetDeclaredSymbol(firstVariable, context.CancellationToken);
157-
}
158-
}
159150

160151
if (memberSyntax is ConstructorDeclarationSyntax constructorDeclarationSyntax)
161152
{
162-
ISymbol symbol = context.SemanticModel.GetDeclaredSymbol(constructorDeclarationSyntax, context.CancellationToken);
163-
164-
if (symbol is IMethodSymbol constructorMethodSymbol && constructorMethodSymbol.ContainingType is INamedTypeSymbol enclosingNamedTypeSymbol)
153+
if (declaredSymbol is IMethodSymbol constructorMethodSymbol && constructorMethodSymbol.ContainingType is INamedTypeSymbol enclosingNamedTypeSymbol)
165154
{
166155
INamedTypeSymbol baseType = enclosingNamedTypeSymbol.BaseType;
167156

@@ -207,6 +196,16 @@ private static void HandleMemberDeclaration(SyntaxNodeAnalysisContext context)
207196
}
208197
}
209198

199+
if (declaredSymbol == null && memberSyntax.IsKind(SyntaxKind.EventFieldDeclaration))
200+
{
201+
var eventFieldDeclarationSyntax = (EventFieldDeclarationSyntax)memberSyntax;
202+
VariableDeclaratorSyntax? firstVariable = eventFieldDeclarationSyntax.Declaration?.Variables.FirstOrDefault();
203+
if (firstVariable != null)
204+
{
205+
declaredSymbol = context.SemanticModel.GetDeclaredSymbol(firstVariable, context.CancellationToken);
206+
}
207+
}
208+
210209
if (documentation.Content.GetFirstXmlElement(XmlCommentHelper.IncludeXmlTag) is XmlEmptyElementSyntax includeElement)
211210
{
212211
if (declaredSymbol == null)

0 commit comments

Comments
 (0)