Update SA1604 to ignore elements that do not require documentation

sharwell · sharwell · commit 5400cf3d154b · 2017-06-19T23:06:35.000-05:00
Fixes #2443
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1604UnitTests.cs b/StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1604UnitTests.cs
@@ -207,6 +207,28 @@ public void Test() { }
             await this.VerifyCSharpDiagnosticAsync(testCode, expected, CancellationToken.None).ConfigureAwait(false);
         }
 
+        [Fact]
+        [WorkItem(2443, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/2443")]
+        public async Task TestPrivateMethodWithoutSummaryAsync()
+        {
+            var testCode = @"
+/// <summary>
+/// 
+/// </summary>
+internal class ClassName
+{
+    ///
+    private void Test1() { }
+
+    /**
+     *
+     */
+    private void Test2() { }
+}";
+
+            await this.VerifyCSharpDiagnosticAsync(testCode, EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
+        }
+
         [Fact]
         public async Task TestPartialMethodWithoutDocumentationAsync()
         {
@@ -663,10 +685,10 @@ public async Task TestEventPropertyWithoutDocumentationAsync()
 public class ClassName
 {
     ///
-    event System.Action Foo { add { } remove { } }
+    public event System.Action Foo { add { } remove { } }
 }";
 
-            DiagnosticResult expected = this.CSharpDiagnostic().WithLocation(8, 25);
+            DiagnosticResult expected = this.CSharpDiagnostic().WithLocation(8, 32);
 
             await this.VerifyCSharpDiagnosticAsync(testCode, expected, CancellationToken.None).ConfigureAwait(false);
         }
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/ElementDocumentationSummaryBase.cs b/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/ElementDocumentationSummaryBase.cs
@@ -63,6 +63,8 @@ public override void Initialize(AnalysisContext context)
         /// Analyzes the top-level <c>&lt;summary&gt;</c> element of a documentation comment.
         /// </summary>
         /// <param name="context">The current analysis context.</param>
+        /// <param name="needsComment"><see langword="true"/> if the current documentation settings indicate that the
+        /// element should be documented; otherwise, <see langword="false"/>.</param>
         /// <param name="documentation">The documentation syntax associated with the element.</param>
         /// <param name="syntax">The <see cref="XmlElementSyntax"/> or <see cref="XmlEmptyElementSyntax"/> of the node
         /// to examine.</param>
@@ -71,7 +73,7 @@ public override void Initialize(AnalysisContext context)
         /// element, this value will be <see langword="null"/>, even if the XML documentation comment also included an
         /// <c>&lt;include&gt;</c> element.</param>
         /// <param name="diagnosticLocations">The location(s) where diagnostics, if any, should be reported.</param>
-        protected abstract void HandleXmlElement(SyntaxNodeAnalysisContext context, DocumentationCommentTriviaSyntax documentation, XmlNodeSyntax syntax, XElement completeDocumentation, params Location[] diagnosticLocations);
+        protected abstract void HandleXmlElement(SyntaxNodeAnalysisContext context, bool needsComment, DocumentationCommentTriviaSyntax documentation, XmlNodeSyntax syntax, XElement completeDocumentation, params Location[] diagnosticLocations);
 
         private void HandleTypeDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)
         {
@@ -87,7 +89,10 @@ private void HandleTypeDeclaration(SyntaxNodeAnalysisContext context, StyleCopSe
                 return;
             }
 
-            this.HandleDeclaration(context, node, node.Identifier.GetLocation());
+            Accessibility declaredAccessibility = node.GetDeclaredAccessibility(context.SemanticModel, context.CancellationToken);
+            Accessibility effectiveAccessibility = node.GetEffectiveAccessibility(context.SemanticModel, context.CancellationToken);
+            bool needsComment = SA1600ElementsMustBeDocumented.NeedsComment(settings.DocumentationRules, node.Kind(), node.Parent.Kind(), declaredAccessibility, effectiveAccessibility);
+            this.HandleDeclaration(context, needsComment, node, node.Identifier.GetLocation());
         }
 
         private void HandleDelegateDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)
@@ -98,7 +103,10 @@ private void HandleDelegateDeclaration(SyntaxNodeAnalysisContext context, StyleC
                 return;
             }
 
-            this.HandleDeclaration(context, node, node.Identifier.GetLocation());
+            Accessibility declaredAccessibility = node.GetDeclaredAccessibility(context.SemanticModel, context.CancellationToken);
+            Accessibility effectiveAccessibility = node.GetEffectiveAccessibility(context.SemanticModel, context.CancellationToken);
+            bool needsComment = SA1600ElementsMustBeDocumented.NeedsComment(settings.DocumentationRules, node.Kind(), node.Parent.Kind(), declaredAccessibility, effectiveAccessibility);
+            this.HandleDeclaration(context, needsComment, node, node.Identifier.GetLocation());
         }
 
         private void HandleMethodDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)
@@ -115,7 +123,10 @@ private void HandleMethodDeclaration(SyntaxNodeAnalysisContext context, StyleCop
                 return;
             }
 
-            this.HandleDeclaration(context, node, node.Identifier.GetLocation());
+            Accessibility declaredAccessibility = node.GetDeclaredAccessibility(context.SemanticModel, context.CancellationToken);
+            Accessibility effectiveAccessibility = node.GetEffectiveAccessibility(context.SemanticModel, context.CancellationToken);
+            bool needsComment = SA1600ElementsMustBeDocumented.NeedsComment(settings.DocumentationRules, node.Kind(), node.Parent.Kind(), declaredAccessibility, effectiveAccessibility);
+            this.HandleDeclaration(context, needsComment, node, node.Identifier.GetLocation());
         }
 
         private void HandleConstructorDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)
@@ -126,7 +137,10 @@ private void HandleConstructorDeclaration(SyntaxNodeAnalysisContext context, Sty
                 return;
             }
 
-            this.HandleDeclaration(context, node, node.Identifier.GetLocation());
+            Accessibility declaredAccessibility = node.GetDeclaredAccessibility(context.SemanticModel, context.CancellationToken);
+            Accessibility effectiveAccessibility = node.GetEffectiveAccessibility(context.SemanticModel, context.CancellationToken);
+            bool needsComment = SA1600ElementsMustBeDocumented.NeedsComment(settings.DocumentationRules, node.Kind(), node.Parent.Kind(), declaredAccessibility, effectiveAccessibility);
+            this.HandleDeclaration(context, needsComment, node, node.Identifier.GetLocation());
         }
 
         private void HandleDestructorDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)
@@ -137,7 +151,10 @@ private void HandleDestructorDeclaration(SyntaxNodeAnalysisContext context, Styl
                 return;
             }
 
-            this.HandleDeclaration(context, node, node.Identifier.GetLocation());
+            Accessibility declaredAccessibility = node.GetDeclaredAccessibility(context.SemanticModel, context.CancellationToken);
+            Accessibility effectiveAccessibility = node.GetEffectiveAccessibility(context.SemanticModel, context.CancellationToken);
+            bool needsComment = SA1600ElementsMustBeDocumented.NeedsComment(settings.DocumentationRules, node.Kind(), node.Parent.Kind(), declaredAccessibility, effectiveAccessibility);
+            this.HandleDeclaration(context, needsComment, node, node.Identifier.GetLocation());
         }
 
         private void HandlePropertyDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)
@@ -148,7 +165,10 @@ private void HandlePropertyDeclaration(SyntaxNodeAnalysisContext context, StyleC
                 return;
             }
 
-            this.HandleDeclaration(context, node, node.Identifier.GetLocation());
+            Accessibility declaredAccessibility = node.GetDeclaredAccessibility(context.SemanticModel, context.CancellationToken);
+            Accessibility effectiveAccessibility = node.GetEffectiveAccessibility(context.SemanticModel, context.CancellationToken);
+            bool needsComment = SA1600ElementsMustBeDocumented.NeedsComment(settings.DocumentationRules, node.Kind(), node.Parent.Kind(), declaredAccessibility, effectiveAccessibility);
+            this.HandleDeclaration(context, needsComment, node, node.Identifier.GetLocation());
         }
 
         private void HandleIndexerDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)
@@ -159,7 +179,10 @@ private void HandleIndexerDeclaration(SyntaxNodeAnalysisContext context, StyleCo
                 return;
             }
 
-            this.HandleDeclaration(context, node, node.ThisKeyword.GetLocation());
+            Accessibility declaredAccessibility = node.GetDeclaredAccessibility(context.SemanticModel, context.CancellationToken);
+            Accessibility effectiveAccessibility = node.GetEffectiveAccessibility(context.SemanticModel, context.CancellationToken);
+            bool needsComment = SA1600ElementsMustBeDocumented.NeedsComment(settings.DocumentationRules, node.Kind(), node.Parent.Kind(), declaredAccessibility, effectiveAccessibility);
+            this.HandleDeclaration(context, needsComment, node, node.ThisKeyword.GetLocation());
         }
 
         private void HandleFieldDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)
@@ -188,7 +211,10 @@ private void HandleFieldDeclaration(SyntaxNodeAnalysisContext context, StyleCopS
             // int i,;
             Array.Resize(ref locations, insertionIndex);
 
-            this.HandleDeclaration(context, node, locations);
+            Accessibility declaredAccessibility = node.GetDeclaredAccessibility(context.SemanticModel, context.CancellationToken);
+            Accessibility effectiveAccessibility = node.GetEffectiveAccessibility(context.SemanticModel, context.CancellationToken);
+            bool needsComment = SA1600ElementsMustBeDocumented.NeedsComment(settings.DocumentationRules, node.Kind(), node.Parent.Kind(), declaredAccessibility, effectiveAccessibility);
+            this.HandleDeclaration(context, needsComment, node, locations);
         }
 
         private void HandleEventDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)
@@ -199,10 +225,13 @@ private void HandleEventDeclaration(SyntaxNodeAnalysisContext context, StyleCopS
                 return;
             }
 
-            this.HandleDeclaration(context, node, node.Identifier.GetLocation());
+            Accessibility declaredAccessibility = node.GetDeclaredAccessibility(context.SemanticModel, context.CancellationToken);
+            Accessibility effectiveAccessibility = node.GetEffectiveAccessibility(context.SemanticModel, context.CancellationToken);
+            bool needsComment = SA1600ElementsMustBeDocumented.NeedsComment(settings.DocumentationRules, node.Kind(), node.Parent.Kind(), declaredAccessibility, effectiveAccessibility);
+            this.HandleDeclaration(context, needsComment, node, node.Identifier.GetLocation());
         }
 
-        private void HandleDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings, SyntaxNode node, params Location[] locations)
+        private void HandleDeclaration(SyntaxNodeAnalysisContext context, bool needsComment, SyntaxNode node, params Location[] locations)
         {
             var documentation = node.GetDocumentationCommentTriviaSyntax();
             if (documentation == null)
@@ -229,7 +258,7 @@ private void HandleDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettin
                 }
             }
 
-            this.HandleXmlElement(context, documentation, relevantXmlElement, completeDocumentation, locations);
+            this.HandleXmlElement(context, needsComment, documentation, relevantXmlElement, completeDocumentation, locations);
         }
     }
 }
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1604ElementDocumentationMustHaveSummary.cs b/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1604ElementDocumentationMustHaveSummary.cs
@@ -6,10 +6,11 @@ namespace StyleCop.Analyzers.DocumentationRules
     using System.Collections.Immutable;
     using System.Linq;
     using System.Xml.Linq;
-    using Helpers;
     using Microsoft.CodeAnalysis;
     using Microsoft.CodeAnalysis.CSharp.Syntax;
     using Microsoft.CodeAnalysis.Diagnostics;
+    using StyleCop.Analyzers.Helpers;
+    using StyleCop.Analyzers.Settings.ObjectModel;
 
     /// <summary>
     /// The XML header documentation for a C# element is missing a <c>&lt;summary&gt;</c> tag.
@@ -43,8 +44,14 @@ internal class SA1604ElementDocumentationMustHaveSummary : ElementDocumentationS
             ImmutableArray.Create(Descriptor);
 
         /// <inheritdoc/>
-        protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, DocumentationCommentTriviaSyntax documentation, XmlNodeSyntax syntax, XElement completeDocumentation, Location[] diagnosticLocations)
+        protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, bool needsComment, DocumentationCommentTriviaSyntax documentation, XmlNodeSyntax syntax, XElement completeDocumentation, Location[] diagnosticLocations)
         {
+            if (!needsComment)
+            {
+                // A missing summary is allowed for this element.
+                return;
+            }
+
             if (completeDocumentation != null)
             {
                 // We are working with an <include> element
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1606ElementDocumentationMustHaveSummaryText.cs b/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1606ElementDocumentationMustHaveSummaryText.cs
@@ -45,7 +45,7 @@ internal class SA1606ElementDocumentationMustHaveSummaryText : ElementDocumentat
             ImmutableArray.Create(Descriptor);
 
         /// <inheritdoc/>
-        protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, DocumentationCommentTriviaSyntax documentation, XmlNodeSyntax syntax, XElement completeDocumentation, Location[] diagnosticLocations)
+        protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, bool needsComment, DocumentationCommentTriviaSyntax documentation, XmlNodeSyntax syntax, XElement completeDocumentation, Location[] diagnosticLocations)
         {
             if (syntax == null)
             {

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,8 @@ public override void Initialize(AnalysisContext context)`
`63`	`63`	`/// Analyzes the top-level <c><summary></c> element of a documentation comment.`
`64`	`64`	`/// </summary>`
`65`	`65`	`/// <param name="context">The current analysis context.</param>`
	`66`	`+ /// <param name="needsComment"><see langword="true"/> if the current documentation settings indicate that the`
	`67`	`+ /// element should be documented; otherwise, <see langword="false"/>.</param>`
`66`	`68`	`/// <param name="documentation">The documentation syntax associated with the element.</param>`
`67`	`69`	`/// <param name="syntax">The <see cref="XmlElementSyntax"/> or <see cref="XmlEmptyElementSyntax"/> of the node`
`68`	`70`	`/// to examine.</param>`
`@@ -71,7 +73,7 @@ public override void Initialize(AnalysisContext context)`
`71`	`73`	`/// element, this value will be <see langword="null"/>, even if the XML documentation comment also included an`
`72`	`74`	`/// <c><include></c> element.</param>`
`73`	`75`	`/// <param name="diagnosticLocations">The location(s) where diagnostics, if any, should be reported.</param>`
`74`		`- protected abstract void HandleXmlElement(SyntaxNodeAnalysisContext context, DocumentationCommentTriviaSyntax documentation, XmlNodeSyntax syntax, XElement completeDocumentation, params Location[] diagnosticLocations);`
	`76`	`+ protected abstract void HandleXmlElement(SyntaxNodeAnalysisContext context, bool needsComment, DocumentationCommentTriviaSyntax documentation, XmlNodeSyntax syntax, XElement completeDocumentation, params Location[] diagnosticLocations);`
`75`	`77`
`76`	`78`	`private void HandleTypeDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)`
`77`	`79`	`{`
`@@ -87,7 +89,10 @@ private void HandleTypeDeclaration(SyntaxNodeAnalysisContext context, StyleCopSe`
`87`	`89`	`return;`
`88`	`90`	`}`
`89`	`91`
`90`		`- this.HandleDeclaration(context, node, node.Identifier.GetLocation());`
	`92`	`+ Accessibility declaredAccessibility = node.GetDeclaredAccessibility(context.SemanticModel, context.CancellationToken);`
	`93`	`+ Accessibility effectiveAccessibility = node.GetEffectiveAccessibility(context.SemanticModel, context.CancellationToken);`
	`94`	`+ bool needsComment = SA1600ElementsMustBeDocumented.NeedsComment(settings.DocumentationRules, node.Kind(), node.Parent.Kind(), declaredAccessibility, effectiveAccessibility);`
	`95`	`+ this.HandleDeclaration(context, needsComment, node, node.Identifier.GetLocation());`
`91`	`96`	`}`
`92`	`97`
`93`	`98`	`private void HandleDelegateDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)`
`@@ -98,7 +103,10 @@ private void HandleDelegateDeclaration(SyntaxNodeAnalysisContext context, StyleC`
`98`	`103`	`return;`
`99`	`104`	`}`
`100`	`105`
`101`		`- this.HandleDeclaration(context, node, node.Identifier.GetLocation());`
	`106`	`+ Accessibility declaredAccessibility = node.GetDeclaredAccessibility(context.SemanticModel, context.CancellationToken);`
	`107`	`+ Accessibility effectiveAccessibility = node.GetEffectiveAccessibility(context.SemanticModel, context.CancellationToken);`
	`108`	`+ bool needsComment = SA1600ElementsMustBeDocumented.NeedsComment(settings.DocumentationRules, node.Kind(), node.Parent.Kind(), declaredAccessibility, effectiveAccessibility);`
	`109`	`+ this.HandleDeclaration(context, needsComment, node, node.Identifier.GetLocation());`
`102`	`110`	`}`
`103`	`111`
`104`	`112`	`private void HandleMethodDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)`
`@@ -115,7 +123,10 @@ private void HandleMethodDeclaration(SyntaxNodeAnalysisContext context, StyleCop`
`115`	`123`	`return;`
`116`	`124`	`}`
`117`	`125`
`118`		`- this.HandleDeclaration(context, node, node.Identifier.GetLocation());`
	`126`	`+ Accessibility declaredAccessibility = node.GetDeclaredAccessibility(context.SemanticModel, context.CancellationToken);`
	`127`	`+ Accessibility effectiveAccessibility = node.GetEffectiveAccessibility(context.SemanticModel, context.CancellationToken);`
	`128`	`+ bool needsComment = SA1600ElementsMustBeDocumented.NeedsComment(settings.DocumentationRules, node.Kind(), node.Parent.Kind(), declaredAccessibility, effectiveAccessibility);`
	`129`	`+ this.HandleDeclaration(context, needsComment, node, node.Identifier.GetLocation());`
`119`	`130`	`}`
`120`	`131`
`121`	`132`	`private void HandleConstructorDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)`
`@@ -126,7 +137,10 @@ private void HandleConstructorDeclaration(SyntaxNodeAnalysisContext context, Sty`
`126`	`137`	`return;`
`127`	`138`	`}`
`128`	`139`
`129`		`- this.HandleDeclaration(context, node, node.Identifier.GetLocation());`
	`140`	`+ Accessibility declaredAccessibility = node.GetDeclaredAccessibility(context.SemanticModel, context.CancellationToken);`
	`141`	`+ Accessibility effectiveAccessibility = node.GetEffectiveAccessibility(context.SemanticModel, context.CancellationToken);`
	`142`	`+ bool needsComment = SA1600ElementsMustBeDocumented.NeedsComment(settings.DocumentationRules, node.Kind(), node.Parent.Kind(), declaredAccessibility, effectiveAccessibility);`
	`143`	`+ this.HandleDeclaration(context, needsComment, node, node.Identifier.GetLocation());`
`130`	`144`	`}`
`131`	`145`
`132`	`146`	`private void HandleDestructorDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)`
`@@ -137,7 +151,10 @@ private void HandleDestructorDeclaration(SyntaxNodeAnalysisContext context, Styl`
`137`	`151`	`return;`
`138`	`152`	`}`
`139`	`153`
`140`		`- this.HandleDeclaration(context, node, node.Identifier.GetLocation());`
	`154`	`+ Accessibility declaredAccessibility = node.GetDeclaredAccessibility(context.SemanticModel, context.CancellationToken);`
	`155`	`+ Accessibility effectiveAccessibility = node.GetEffectiveAccessibility(context.SemanticModel, context.CancellationToken);`
	`156`	`+ bool needsComment = SA1600ElementsMustBeDocumented.NeedsComment(settings.DocumentationRules, node.Kind(), node.Parent.Kind(), declaredAccessibility, effectiveAccessibility);`
	`157`	`+ this.HandleDeclaration(context, needsComment, node, node.Identifier.GetLocation());`
`141`	`158`	`}`
`142`	`159`
`143`	`160`	`private void HandlePropertyDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)`
`@@ -148,7 +165,10 @@ private void HandlePropertyDeclaration(SyntaxNodeAnalysisContext context, StyleC`
`148`	`165`	`return;`
`149`	`166`	`}`
`150`	`167`
`151`		`- this.HandleDeclaration(context, node, node.Identifier.GetLocation());`
	`168`	`+ Accessibility declaredAccessibility = node.GetDeclaredAccessibility(context.SemanticModel, context.CancellationToken);`
	`169`	`+ Accessibility effectiveAccessibility = node.GetEffectiveAccessibility(context.SemanticModel, context.CancellationToken);`
	`170`	`+ bool needsComment = SA1600ElementsMustBeDocumented.NeedsComment(settings.DocumentationRules, node.Kind(), node.Parent.Kind(), declaredAccessibility, effectiveAccessibility);`
	`171`	`+ this.HandleDeclaration(context, needsComment, node, node.Identifier.GetLocation());`
`152`	`172`	`}`
`153`	`173`
`154`	`174`	`private void HandleIndexerDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)`
`@@ -159,7 +179,10 @@ private void HandleIndexerDeclaration(SyntaxNodeAnalysisContext context, StyleCo`
`159`	`179`	`return;`
`160`	`180`	`}`
`161`	`181`
`162`		`- this.HandleDeclaration(context, node, node.ThisKeyword.GetLocation());`
	`182`	`+ Accessibility declaredAccessibility = node.GetDeclaredAccessibility(context.SemanticModel, context.CancellationToken);`
	`183`	`+ Accessibility effectiveAccessibility = node.GetEffectiveAccessibility(context.SemanticModel, context.CancellationToken);`
	`184`	`+ bool needsComment = SA1600ElementsMustBeDocumented.NeedsComment(settings.DocumentationRules, node.Kind(), node.Parent.Kind(), declaredAccessibility, effectiveAccessibility);`
	`185`	`+ this.HandleDeclaration(context, needsComment, node, node.ThisKeyword.GetLocation());`
`163`	`186`	`}`
`164`	`187`
`165`	`188`	`private void HandleFieldDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)`
`@@ -188,7 +211,10 @@ private void HandleFieldDeclaration(SyntaxNodeAnalysisContext context, StyleCopS`
`188`	`211`	`// int i,;`
`189`	`212`	`Array.Resize(ref locations, insertionIndex);`
`190`	`213`
`191`		`- this.HandleDeclaration(context, node, locations);`
	`214`	`+ Accessibility declaredAccessibility = node.GetDeclaredAccessibility(context.SemanticModel, context.CancellationToken);`
	`215`	`+ Accessibility effectiveAccessibility = node.GetEffectiveAccessibility(context.SemanticModel, context.CancellationToken);`
	`216`	`+ bool needsComment = SA1600ElementsMustBeDocumented.NeedsComment(settings.DocumentationRules, node.Kind(), node.Parent.Kind(), declaredAccessibility, effectiveAccessibility);`
	`217`	`+ this.HandleDeclaration(context, needsComment, node, locations);`
`192`	`218`	`}`
`193`	`219`
`194`	`220`	`private void HandleEventDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)`
`@@ -199,10 +225,13 @@ private void HandleEventDeclaration(SyntaxNodeAnalysisContext context, StyleCopS`
`199`	`225`	`return;`
`200`	`226`	`}`
`201`	`227`
`202`		`- this.HandleDeclaration(context, node, node.Identifier.GetLocation());`
	`228`	`+ Accessibility declaredAccessibility = node.GetDeclaredAccessibility(context.SemanticModel, context.CancellationToken);`
	`229`	`+ Accessibility effectiveAccessibility = node.GetEffectiveAccessibility(context.SemanticModel, context.CancellationToken);`
	`230`	`+ bool needsComment = SA1600ElementsMustBeDocumented.NeedsComment(settings.DocumentationRules, node.Kind(), node.Parent.Kind(), declaredAccessibility, effectiveAccessibility);`
	`231`	`+ this.HandleDeclaration(context, needsComment, node, node.Identifier.GetLocation());`
`203`	`232`	`}`
`204`	`233`
`205`		`- private void HandleDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings, SyntaxNode node, params Location[] locations)`
	`234`	`+ private void HandleDeclaration(SyntaxNodeAnalysisContext context, bool needsComment, SyntaxNode node, params Location[] locations)`
`206`	`235`	`{`
`207`	`236`	`var documentation = node.GetDocumentationCommentTriviaSyntax();`
`208`	`237`	`if (documentation == null)`
`@@ -229,7 +258,7 @@ private void HandleDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettin`
`229`	`258`	`}`
`230`	`259`	`}`
`231`	`260`
`232`		`- this.HandleXmlElement(context, documentation, relevantXmlElement, completeDocumentation, locations);`
	`261`	`+ this.HandleXmlElement(context, needsComment, documentation, relevantXmlElement, completeDocumentation, locations);`
`233`	`262`	`}`
`234`	`263`	`}`
`235`	`264`	`}`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ internal class SA1606ElementDocumentationMustHaveSummaryText : ElementDocumentat`
`45`	`45`	`ImmutableArray.Create(Descriptor);`
`46`	`46`
`47`	`47`	`/// <inheritdoc/>`
`48`		`- protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, DocumentationCommentTriviaSyntax documentation, XmlNodeSyntax syntax, XElement completeDocumentation, Location[] diagnosticLocations)`
	`48`	`+ protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, bool needsComment, DocumentationCommentTriviaSyntax documentation, XmlNodeSyntax syntax, XElement completeDocumentation, Location[] diagnosticLocations)`
`49`	`49`	`{`
`50`	`50`	`if (syntax == null)`
`51`	`51`	`{`