Validate additional cross-casting cases

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp7/Lightup/ForEachVariableStatementSyntaxWrapperTests.cs

@@ -181,6 +181,13 @@ public void TestIsInstance()
             Assert.False(ForEachVariableStatementSyntaxWrapper.IsInstance(null));
             Assert.False(ForEachVariableStatementSyntaxWrapper.IsInstance(SyntaxFactory.LiteralExpression(SyntaxKind.NullLiteralExpression)));
 
+            var forEachStatement = SyntaxFactory.ForEachStatement(
+                SyntaxFactory.PredefinedType(SyntaxFactory.Token(SyntaxKind.IntKeyword)),
+                "item",
+                SyntaxFactory.IdentifierName("collection"),
+                SyntaxFactory.EmptyStatement());
+            Assert.False(ForEachVariableStatementSyntaxWrapper.IsInstance(forEachStatement));
+
             var syntaxNode = this.CreateForEachVariableStatement();
             Assert.True(ForEachVariableStatementSyntaxWrapper.IsInstance(syntaxNode));
         }
@@ -220,6 +227,16 @@ public void TestInvalidConversion()
         {
             var syntaxNode = SyntaxFactory.LiteralExpression(SyntaxKind.NullLiteralExpression);
             Assert.Throws<InvalidCastException>(() => (ForEachVariableStatementSyntaxWrapper)syntaxNode);
+
+            var forEachStatement = SyntaxFactory.ForEachStatement(
+                SyntaxFactory.PredefinedType(SyntaxFactory.Token(SyntaxKind.IntKeyword)),
+                "item",
+                SyntaxFactory.IdentifierName("collection"),
+                SyntaxFactory.EmptyStatement());
+            Assert.Throws<InvalidCastException>(() => (ForEachVariableStatementSyntaxWrapper)forEachStatement);
+
+            var commonWrapper = (CommonForEachStatementSyntaxWrapper)forEachStatement;
+            Assert.Throws<InvalidCastException>(() => (ForEachVariableStatementSyntaxWrapper)commonWrapper);
         }
 
         private ForEachVariableStatementSyntax CreateForEachVariableStatement()

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp8/Lightup/ForEachVariableStatementSyntaxWrapperCSharp8UnitTests.cs

@@ -185,6 +185,13 @@ public void TestIsInstance()
             Assert.False(ForEachVariableStatementSyntaxWrapper.IsInstance(null));
             Assert.False(ForEachVariableStatementSyntaxWrapper.IsInstance(SyntaxFactory.LiteralExpression(SyntaxKind.NullLiteralExpression)));
 
+            var forEachStatement = SyntaxFactory.ForEachStatement(
+                SyntaxFactory.PredefinedType(SyntaxFactory.Token(SyntaxKind.IntKeyword)),
+                "item",
+                SyntaxFactory.IdentifierName("collection"),
+                SyntaxFactory.EmptyStatement());
+            Assert.False(ForEachVariableStatementSyntaxWrapper.IsInstance(forEachStatement));
+
             var syntaxNode = this.CreateForEachVariableStatement();
             Assert.True(ForEachVariableStatementSyntaxWrapper.IsInstance(syntaxNode));
         }
@@ -224,6 +231,16 @@ public void TestInvalidConversion()
         {
             var syntaxNode = SyntaxFactory.LiteralExpression(SyntaxKind.NullLiteralExpression);
             Assert.Throws<InvalidCastException>(() => (ForEachVariableStatementSyntaxWrapper)syntaxNode);
+
+            var forEachStatement = SyntaxFactory.ForEachStatement(
+                SyntaxFactory.PredefinedType(SyntaxFactory.Token(SyntaxKind.IntKeyword)),
+                "item",
+                SyntaxFactory.IdentifierName("collection"),
+                SyntaxFactory.EmptyStatement());
+            Assert.Throws<InvalidCastException>(() => (ForEachVariableStatementSyntaxWrapper)forEachStatement);
+
+            var commonWrapper = (CommonForEachStatementSyntaxWrapper)forEachStatement;
+            Assert.Throws<InvalidCastException>(() => (ForEachVariableStatementSyntaxWrapper)commonWrapper);
         }
 
         private ForEachVariableStatementSyntax CreateForEachVariableStatement()