Add unit tests for handling Windows using directives correctly for SA1208 and SA1210

Author: ali-hk

StyleCop.Analyzers/StyleCop.Analyzers.Test/OrderingRules/SA1208UnitTests.cs

@@ -115,6 +115,92 @@ class A
             await this.VerifyCSharpDiagnosticAsync(usingsInNamespaceDeclaration, expected, CancellationToken.None).ConfigureAwait(false);
         }
 
+        [Fact]
+        public async Task TestWhenSystemAndWindowsUsingDirectivesAreNotOnTopInCompilationAsync()
+        {
+            var usingsInCompilationUnit = new[]
+            {
+                "namespace Windows.Foundation {}",
+                "namespace Xyz {}",
+                "namespace AnotherNamespace {}",
+                @"using Xyz;
+using System;
+using System.IO;
+using AnotherNamespace;
+using Windows.Foundation;
+using System.Threading.Tasks;
+
+class A
+{
+}",
+            };
+
+            DiagnosticResult[] expected =
+            {
+                this.CSharpDiagnostic().WithLocation("Test3.cs", 2, 1).WithArguments("System", "Xyz"),
+                this.CSharpDiagnostic().WithLocation("Test3.cs", 3, 1).WithArguments("System.IO", "Xyz"),
+                this.CSharpDiagnostic().WithLocation("Test3.cs", 5, 1).WithArguments("Windows.Foundation", "Xyz"),
+                this.CSharpDiagnostic().WithLocation("Test3.cs", 6, 1).WithArguments("System.Threading.Tasks", "Xyz"),
+            };
+
+            await this.VerifyCSharpDiagnosticAsync(usingsInCompilationUnit, expected, CancellationToken.None).ConfigureAwait(false);
+        }
+
+        [Fact]
+        public async Task TestWhenSystemAndWindowsUsingDirectivesAreNotOnTopInNamespaceAsync()
+        {
+            var usingsInNamespaceDeclaration = new[]
+            {
+                "namespace Windows.Foundation {}",
+                "namespace Namespace {}",
+                "namespace AnotherNamespace {}",
+                @"namespace Test
+{
+    using Namespace;
+    using System.Threading;
+    using System.IO;
+    using Windows.Foundation;
+    using AnotherNamespace;
+
+    class A
+    {
+    }
+}",
+            };
+
+            DiagnosticResult[] expected =
+            {
+                this.CSharpDiagnostic().WithLocation("Test3.cs", 4, 5).WithArguments("System.Threading", "Namespace"),
+                this.CSharpDiagnostic().WithLocation("Test3.cs", 5, 5).WithArguments("System.IO", "Namespace"),
+                this.CSharpDiagnostic().WithLocation("Test3.cs", 6, 5).WithArguments("Windows.Foundation", "Namespace"),
+            };
+
+            await this.VerifyCSharpDiagnosticAsync(usingsInNamespaceDeclaration, expected, CancellationToken.None).ConfigureAwait(false);
+        }
+
+        [Fact]
+        public async Task TestWhenWindowsUsingDirectivesAreNotOnTopAsync()
+        {
+            var usingsInCompilationUnit = new[]
+            {
+                "namespace Windows.Foundation {}",
+                "namespace Namespace {}",
+                @"using Namespace;
+using Windows.Foundation;
+
+class A
+{
+}",
+            };
+
+            DiagnosticResult[] expected =
+            {
+                this.CSharpDiagnostic().WithLocation("Test2.cs", 2, 1).WithArguments("Windows.Foundation", "Namespace"),
+            };
+
+            await this.VerifyCSharpDiagnosticAsync(usingsInCompilationUnit, expected, CancellationToken.None).ConfigureAwait(false);
+        }
+
         [Fact]
         public async Task TestSystemUsingDirectivesInCompilationUnitAndInNamespaceDeclarationAsync()
         {

StyleCop.Analyzers/StyleCop.Analyzers.Test/OrderingRules/SA1210UnitTests.cs

@@ -114,6 +114,65 @@ namespace Bar
             await this.VerifyCSharpFixAsync(testCode, fixedTestCode).ConfigureAwait(false);
         }
 
+        [Fact]
+        public async Task TestInvalidOrderedUsingDirectivesWithWindowsUsingDirectiveAsync()
+        {
+            var testCode = @"namespace Windows.Foundation {}
+namespace Windows.Foundation.Collections {}
+namespace Foo
+{
+    using Windows.Foundation.Collections;
+    using Windows.Foundation;
+    using System.Threading;
+    using System;
+}
+
+namespace Bar
+{
+    using Foo;
+    using Bar;
+    using Windows.Foundation.Collections;
+    using Windows.Foundation;
+    using System.Threading;
+    using System;
+}";
+
+            var fixedTestCode = @"namespace Windows.Foundation {}
+namespace Windows.Foundation.Collections {}
+namespace Foo
+{
+    using System;
+    using System.Threading;
+    using Windows.Foundation;
+    using Windows.Foundation.Collections;
+}
+
+namespace Bar
+{
+    using System;
+    using System.Threading;
+    using Windows.Foundation;
+    using Windows.Foundation.Collections;
+    using Bar;
+    using Foo;
+}";
+
+            DiagnosticResult[] expected =
+            {
+                this.CSharpDiagnostic().WithLocation(5, 5),
+                this.CSharpDiagnostic().WithLocation(6, 5),
+                this.CSharpDiagnostic().WithLocation(7, 5),
+                this.CSharpDiagnostic().WithLocation(13, 5),
+                this.CSharpDiagnostic().WithLocation(15, 5),
+                this.CSharpDiagnostic().WithLocation(16, 5),
+                this.CSharpDiagnostic().WithLocation(17, 5),
+            };
+
+            await this.VerifyCSharpDiagnosticAsync(testCode, expected, CancellationToken.None).ConfigureAwait(false);
+            await this.VerifyCSharpDiagnosticAsync(fixedTestCode, EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
+            await this.VerifyCSharpFixAsync(testCode, fixedTestCode).ConfigureAwait(false);
+        }
+
         [Fact]
         [WorkItem(2336, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/2336")]
         public async Task TestUsingDirectivesCaseSensitivityAsync()