HashSet.Contains

ninedan · ninedan · commit 589f04026fd0 · 2023-05-02T20:43:37.000-07:00
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1625ElementDocumentationMustNotBeCopiedAndPasted.cs b/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1625ElementDocumentationMustNotBeCopiedAndPasted.cs
@@ -101,15 +101,11 @@ protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, Styl
                     continue;
                 }
 
-                if (documentationTexts.Contains(documentation))
+                if (!documentationTexts.Add(documentation))
                 {
                     // Add violation
                     context.ReportDiagnostic(Diagnostic.Create(Descriptor, documentationSyntax.GetLocation()));
                 }
-                else
-                {
-                    documentationTexts.Add(documentation);
-                }
             }
 
             objectPool.ClearAndFree(documentationTexts);
@@ -148,15 +144,11 @@ protected override void HandleCompleteDocumentation(SyntaxNodeAnalysisContext co
                     continue;
                 }
 
-                if (documentationTexts.Contains(documentation))
+                if (!documentationTexts.Add(documentation))
                 {
                     // Add violation
                     context.ReportDiagnostic(Diagnostic.Create(Descriptor, diagnosticLocations.First()));
                 }
-                else
-                {
-                    documentationTexts.Add(documentation);
-                }
             }
 
             objectPool.ClearAndFree(documentationTexts);

Original file line number	Diff line number	Diff line change
`@@ -101,15 +101,11 @@ protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, Styl`
`101`	`101`	`continue;`
`102`	`102`	`}`
`103`	`103`
`104`		`- if (documentationTexts.Contains(documentation))`
	`104`	`+ if (!documentationTexts.Add(documentation))`
`105`	`105`	`{`
`106`	`106`	`// Add violation`
`107`	`107`	`context.ReportDiagnostic(Diagnostic.Create(Descriptor, documentationSyntax.GetLocation()));`
`108`	`108`	`}`
`109`		`- else`
`110`		`- {`
`111`		`- documentationTexts.Add(documentation);`
`112`		`- }`
`113`	`109`	`}`
`114`	`110`
`115`	`111`	`objectPool.ClearAndFree(documentationTexts);`
`@@ -148,15 +144,11 @@ protected override void HandleCompleteDocumentation(SyntaxNodeAnalysisContext co`
`148`	`144`	`continue;`
`149`	`145`	`}`
`150`	`146`
`151`		`- if (documentationTexts.Contains(documentation))`
	`147`	`+ if (!documentationTexts.Add(documentation))`
`152`	`148`	`{`
`153`	`149`	`// Add violation`
`154`	`150`	`context.ReportDiagnostic(Diagnostic.Create(Descriptor, diagnosticLocations.First()));`
`155`	`151`	`}`
`156`		`- else`
`157`		`- {`
`158`		`- documentationTexts.Add(documentation);`
`159`		`- }`
`160`	`152`	`}`
`161`	`153`
`162`	`154`	`objectPool.ClearAndFree(documentationTexts);`