Merge pull request #2800 from vweijsters/fix-2799

Exclude constructor initializers from SA1101

Author: vweijsters

StyleCop.Analyzers/StyleCop.Analyzers.Test/ReadabilityRules/SA1101UnitTests.cs

@@ -363,6 +363,41 @@ public class Foo
 {
     public string Array { get; } = nameof(Array);
 }
+";
+
+            await VerifyCSharpDiagnosticAsync(testCode, DiagnosticResult.EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
+        }
+
+        [Fact]
+        [WorkItem(2799, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/2799")]
+        public async Task TestNameofInConstructorCallAsync()
+        {
+            var testCode = @"
+public class TestClass
+{
+    public TestClass()
+        : this(nameof(P))
+    {
+    }
+
+    public TestClass(string p)
+    {
+        this.P = p;
+    }
+
+    public string P { get; }
+}
+
+public class DerivedTestClass : TestClass
+{
+    public DerivedTestClass()
+        : base(nameof(Q))
+    {
+        this.Q = string.Empty;
+    }
+
+    public string Q { get; }
+}
 ";
 
             await VerifyCSharpDiagnosticAsync(testCode, DiagnosticResult.EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);

StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1101PrefixLocalCallsWithThis.cs

@@ -124,6 +124,10 @@ private static void HandleSimpleName(SyntaxNodeAnalysisContext context)
 
                 break;
 
+            case SyntaxKind.Argument when IsPartOfConstructorInitializer((SimpleNameSyntax)context.Node):
+                // constructor invocations cannot contain this.
+                return;
+
             default:
                 break;
             }
@@ -264,5 +268,20 @@ private static bool HasThis(SyntaxNode node)
 
             return false;
         }
+
+        private static bool IsPartOfConstructorInitializer(SyntaxNode node)
+        {
+            for (; node != null; node = node.Parent)
+            {
+                switch (node.Kind())
+                {
+                case SyntaxKind.ThisConstructorInitializer:
+                case SyntaxKind.BaseConstructorInitializer:
+                    return true;
+                }
+            }
+
+            return false;
+        }
     }
 }