Merge pull request #3543 from bjornhellander/feature/sa1023-inside-foreach-without-braces

Update SA1023 to not trigger first in line, inside a foreach without braces

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test/SpacingRules/SA1023UnitTests.cs

@@ -52,6 +52,33 @@ unsafe void TestMethod()
             await VerifyCSharpDiagnosticAsync(testCode, DiagnosticResult.EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
         }
 
+        /// <summary>
+        /// Verifies that the analyzer will properly handle valid dereference.
+        /// </summary>
+        /// <returns>A <see cref="Task"/> representing the asynchronous unit test.</returns>
+        [Fact]
+        [WorkItem(3538, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3538")]
+        public async Task TestNotReportedWhenFirstInForeachWithoutBracesAsync()
+        {
+            var testCode = @"
+public unsafe class TestClass
+{
+    internal void TestMethod(Obj[] objs)
+    {
+        foreach (var o in objs)
+            *o.I = 1;
+    }
+
+    internal struct Obj
+    {
+        public int* I;
+    }
+}
+";
+
+            await VerifyCSharpDiagnosticAsync(testCode, DiagnosticResult.EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
+        }
+
         /// <summary>
         /// Verifies that the analyzer will properly handle invalid dereference and access of symbols.
         /// </summary>

StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1023DereferenceAndAccessOfSymbolsMustBeSpacedCorrectly.cs

@@ -198,6 +198,10 @@ private static void HandleAsteriskToken(SyntaxTreeAnalysisContext context, Synta
                 context.ReportDiagnostic(Diagnostic.Create(DescriptorNotAtBeginningOfLine, token.GetLocation(), properties));
 #pragma warning restore RS1005 // ReportDiagnostic invoked with an unsupported DiagnosticDescriptor
             }
+            else if (allowAtLineStart && firstInLine)
+            {
+                // The case below should not trigger
+            }
             else if (!allowPrecedingSpace && precededBySpace)
             {
                 // Dereference symbol '*' should {not be preceded by a space}.